Skip to contentSkip to conversation

selftests: bpf: notification about privilege required to run test_lirc_mode2.sh testing script

PATCH In review Jeffrin Jose T 3 participants 3 messages Jun 22, 2018 – Jun 26, 2018

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: bpf: notification about privilege required to run test_lirc_mode2.sh testing script

The test_lirc_mode2.sh script require root privilege for the successful execution of the test.

This patch is to notify the user about the privilege the script demands for the successful execution of the test.

Signed-off-by Jeffrin Jose T (Rajagiri SET) <ahiliation at gmail.com>
---
 tools/testing/selftests/bpf/test_lirc_mode2.sh | 9 +++++++++
 1 file changed, 9 insertions(+)
tools/testing/selftests/bpf/test_lirc_mode2.sh +9 -0
index ce2e15e4f976..51184f8f9e64 100755
@@ -1,6 +1,15 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+msg="skip all tests:"
+if [ $UID != 0 ]; then
+    echo $msg please run this as root >&2
+    exit $ksft_skip
+fi
+
 GREEN='\033[0;92m'
 RED='\033[0;31m'
 NC='\033[0m' # No Color
Signature · 6 lines
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jeffrin Jose T

The test_lirc_mode2.sh script require root privilege for the successful execution of the test.

This patch is to notify the user about the privilege the script demands for the successful execution of the test.

Signed-off-by Jeffrin Jose T (Rajagiri SET) <ahiliation at gmail.com>
Acked-by Song Liu <songliubraving at fb.com>
Quoted 25 lines
---
 tools/testing/selftests/bpf/test_lirc_mode2.sh | 9 +++++++++
 1 file changed, 9 insertions(+)
tools/testing/selftests/bpf/test_lirc_mode2.sh +9 -1
index ce2e15e4f976..51184f8f9e64 100755
@@ -1,6 +1,15 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
 
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+msg="skip all tests:"
+if [ $UID != 0 ]; then
+    echo $msg please run this as root >&2
+    exit $ksft_skip
+fi
+
 GREEN='\033[0;92m'
 RED='\033[0;31m'
 NC='\033[0m' # No Color
--
Quoted 2 lines

2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
In reply to Jeffrin Jose T
Quoted 7 lines · Jeffrin Jose T

The test_lirc_mode2.sh script require root privilege for the successful execution of the test.

This patch is to notify the user about the privilege the script demands for the successful execution of the test.

Signed-off-by Jeffrin Jose T (Rajagiri SET) <ahiliation at gmail.com>

Applied to bpf, thanks Jeffrin!
--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html