Skip to contentSkip to conversation

arm: dts: pxa3xx: provide correct clk-names property for nand controller node

PATCH New Daniel Mack 2 participants 4 messages Jun 24, 2018 – Sep 20, 2018 Device tree bindings

lore
Share & tools
lore

Daniel Mack

author
#0 lore raw

PATCH 1/1 arm: dts: pxa3xx: provide correct clk-names property for nand controller node

The NAND driver looks for a clock named "core" and falls back to a pdev clock that has a wrong rate if not set.

Signed-off-by Daniel Mack <[email protected]>
---
 arch/arm/boot/dts/pxa3xx.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/pxa3xx.dtsi +1 -0
index 3851057bc77d..7f65791c0559 100644
@@ -134,6 +134,7 @@
 			compatible = "marvell,pxa3xx-nand-controller";
 			reg = <0x43100000 90>;
 			interrupts = <45>;
+			clock-names = "core";
 			clocks = <&clks CLK_NAND>;
 			dmas = <&pdma 97 3>;
 			dma-names = "data";
Signature · 1 line
2.17.1
Applied
#1 lore raw

PATCH 1/1 arm: dts: pxa3xx: provide correct clk-names property for nand controller node

Quoted 4 lines · Daniel Mack

The NAND driver looks for a clock named "core" and falls back to a pdev clock that has a wrong rate if not set.

Signed-off-by Daniel Mack <[email protected]>

Applied to pxa/dt with a small "line swap", ie. clock-names is one line below "clocks" line.

Cheers.

Signature · 1 line
Robert
author
#2 lore raw

PATCH 1/1 arm: dts: pxa3xx: provide correct clk-names property for nand controller node

Hi Robert,

Quoted 8 lines · Robert Jarzmik
Quoted 4 lines · Daniel Mack

The NAND driver looks for a clock named "core" and falls back to a pdev clock that has a wrong rate if not set.

Signed-off-by Daniel Mack <[email protected]>

Applied to pxa/dt with a small "line swap", ie. clock-names is one line below "clocks" line.

This patch got applied twice in mainline, as ce4313f318de and as 267a113cec97. Not sure what went wrong here, but the same property npow occurs twice in the node, which leads to an error during dtb complication.

Could you queue a revert for ce4313f318de?

Thanks,
Daniel

author
#3 lore raw

PATCH 1/1 arm: dts: pxa3xx: provide correct clk-names property for nand controller node

Quoted 6 lines · Daniel Mack
Quoted 5 lines · Robert Jarzmik
Quoted 3 lines · Daniel Mack

The NAND driver looks for a clock named "core" and falls back to a pdev clock that has a wrong rate if not set.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Daniel Mack <[email protected]>

Applied to pxa/dt with a small "line swap", ie. clock-names is one line below "clocks" line.

This patch got applied twice in mainline, as ce4313f318de and as 267a113cec97. Not sure what went wrong here, but the same property npow occurs twice in the node, which leads to an error during dtb complication.

Ooops, sorry. Forget it, all is good. I've messed up a local branch.

Sorry for the noise. :(

Daniel