Skip to contentSkip to conversation

ARM: dts: omap3: Fix am3517 mdio and emac clock references

PATCH In review Adam Ford 3 participants 3 messages Jun 25, 2018 – Jul 3, 2018

Subsystems (3)
lore
Share & tools
lore

Adam Ford

author
#0 lore raw

PATCH v3 1/1 ARM: dts: omap3: Fix am3517 mdio and emac clock references

A previous patch removed OMAP clock aliases that were perceived to be unnecessary. Unfortunately, it broke the ethernet on the am3517-evm. This patch enables the MDIO clock and EMAC clock.

Fixes 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")

---
V3: Fix subject heading since we're no longer modifying the clk driver

V2: Instead of modifying clk-3xxx.c, this patch modifie the device tree
to work like the original patch intended.

arch/arm/boot/dts/am3517.dtsi +4 -0
index ca294914bbb1..4b6062b631b1 100644
@@ -39,6 +39,8 @@
 			ti,davinci-ctrl-ram-size = <0x2000>;
 			ti,davinci-rmii-en = /bits/ 8 <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
+			clocks = <&emac_ick>;
+			clock-names = "ick";
 		};
 
 		davinci_mdio: ethernet@5c030000 {
@@ -49,6 +51,8 @@
 			bus_freq = <1000000>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+			clocks = <&emac_fck>;
+			clock-names = "fck";
 		};
 
 		uart4: serial@4809e000 {
Signature · 1 line
2.17.1
Tested-by on v3 1/1
#1 lore raw
Quoted 4 lines · Adam Ford

A previous patch removed OMAP clock aliases that were perceived to be unnecessary. Unfortunately, it broke the ethernet on the am3517-evm. This patch enables the MDIO clock and EMAC clock.

Quoted 35 lines
Fixes 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")

---
V3: Fix subject heading since we're no longer modifying the clk driver

V2: Instead of modifying clk-3xxx.c, this patch modifie the device tree
to work like the original patch intended.

arch/arm/boot/dts/am3517.dtsi +4 -0
index ca294914bbb1..4b6062b631b1 100644
@@ -39,6 +39,8 @@
 			ti,davinci-ctrl-ram-size = <0x2000>;
 			ti,davinci-rmii-en = /bits/ 8 <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
+			clocks = <&emac_ick>;
+			clock-names = "ick";
 		};
 
 		davinci_mdio: ethernet@5c030000 {
@@ -49,6 +51,8 @@
 			bus_freq = <1000000>;
 			#address-cells = <1>;
 			#size-cells = <0>;
+			clocks = <&emac_fck>;
+			clock-names = "fck";
 		};
 
 		uart4: serial@4809e000 {
Signature · 1 line
2.17.1
#2 lore raw
In reply to Adam Ford
Quoted 7 lines · Adam Ford

A previous patch removed OMAP clock aliases that were perceived to be unnecessary. Unfortunately, it broke the ethernet on the am3517-evm. This patch enables the MDIO clock and EMAC clock.

Fixes 0ed266d7ae5e ("clk: ti: omap3: cleanup unnecessary clock aliases")
Quoted 6 lines

---
V3: Fix subject heading since we're no longer modifying the clk driver

V2: Instead of modifying clk-3xxx.c, this patch modifie the device tree
to work like the original patch intended.

Thanks applying into omap-for-v4.18/fixes.

Tony