usb: typec: ucsi: Fix for incorrect status data issue

Quoted 21 lines · Greg Kroah-Hartman

Quoted 19 lines · Heikki Krogerus

According to UCSI Specification, Connector Change Event only means a change in the Connector Status and Operation Mode fields of the STATUS data structure. So any other change should create another event.

Unfortunately on some platforms the firmware acting as PPM (platform policy manager - usually embedded controller firmware) still does not report any other status changes if there is a connector change event. So if the connector power or data role was changed when a device was plugged to the connector, the driver does not get any indication about that. The port will show wrong roles if that happens.

To fix the issue, always checking the data and power role together with a connector change event.

Fixes c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")

Signed-off-by Heikki Krogerus <[email protected]>

---

Quoted 1 line

No stable kernel marking for this? odd...

I forgot to put it there. Sorry.

I noticed you picked this patch already, but can I still resend it?