Skip to contentSkip to conversation

chromium: new package

RFC PATCH Superseded Joseph Kogut 3 participants 12 messages Jun 22, 2018 – Jun 25, 2018

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover chromium: new package

Changes since v4:
- at-spi2-{core,atk}: rework dependencies
- libgtk3: make atk-bridge an optional dependency
- at-spi2-core: convert to meson-package infrastructure
- chromium: define BR2_PACKAGE_CHROMIUM_ARCH_SUPPORTS
- chromium: add host gcc >= 4.9.0 to depends
- lld: convert to host-only package
- fix check-package issues

Changes since v3:
- llvm: add separate TARGETS_TO_BUILD for host only
- chromium: add upstream patch to fix ARM build w/ glibc 2.27
- chromium: disabled v8 snapshotting until the toolchain can be figured out
- chromium: add missing dependencies when use_gtk3=false
- chromium: check-package fixes

Changes since v2:
- patch chromium toolchain config for buildroot

Changes since v1:
- fix some cross compilation issues
- chromium: bump version to 67.0.3396.79
- atk: bump version to 2.28.1
- lld: new package
- chromium: use lld for linking
- minor tweaks to variable naming and quotes

Joseph Kogut (6):
at-spi2-core: new package
at-spi2-atk: new package
libgtk3: convert atk-bridge to optional dependency
llvm: add config to build backend for host arch
lld: new package
chromium: new package

 DEVELOPERS                                    |   4 +
 package/Config.in                             |   3 +
 package/Config.in.host                        |   2 +
 package/at-spi2-atk/Config.in                 |  21 +++
 package/at-spi2-atk/at-spi2-atk.hash          |   3 +
 package/at-spi2-atk/at-spi2-atk.mk            |  17 +++
 package/at-spi2-core/Config.in                |  24 ++++
 package/at-spi2-core/at-spi2-core.hash        |   3 +
 package/at-spi2-core/at-spi2-core.mk          |  16 +++
 ...iler_cpu_abi-for-buildroot-toolchain.patch | 102 ++++++++++++++
 .../0002-Fix-arm-build-with-glibc-2.27.patch  |  28 ++++
 package/chromium/Config.in                    |  56 ++++++++
 package/chromium/chromium.hash                |   3 +
 package/chromium/chromium.mk                  | 127 ++++++++++++++++++
 package/chromium/toolchain/BUILD.gn           |  71 ++++++++++
 ...3-convert-atk-bridge-to-optional-dep.patch |  76 +++++++++++
 package/libgtk3/0003-disable-atk-bridge.patch |  45 -------
 package/libgtk3/libgtk3.mk                    |   4 +
 package/lld/Config.in.host                    |  16 +++
 package/lld/lld.hash                          |   3 +
 package/lld/lld.mk                            |  15 +++
 package/llvm/Config.in.host                   |  18 +++
 package/llvm/llvm.mk                          |   9 +-
 23 files changed, 620 insertions(+), 46 deletions(-)
 create mode 100644 package/at-spi2-atk/Config.in
 create mode 100644 package/at-spi2-atk/at-spi2-atk.hash
 create mode 100644 package/at-spi2-atk/at-spi2-atk.mk
 create mode 100644 package/at-spi2-core/Config.in
 create mode 100644 package/at-spi2-core/at-spi2-core.hash
 create mode 100644 package/at-spi2-core/at-spi2-core.mk
 create mode 100644 package/chromium/0001-modify-compiler_cpu_abi-for-buildroot-toolchain.patch
 create mode 100644 package/chromium/0002-Fix-arm-build-with-glibc-2.27.patch
 create mode 100644 package/chromium/Config.in
 create mode 100644 package/chromium/chromium.hash
 create mode 100644 package/chromium/chromium.mk
 create mode 100644 package/chromium/toolchain/BUILD.gn
 create mode 100644 package/libgtk3/0003-convert-atk-bridge-to-optional-dep.patch
 delete mode 100644 package/libgtk3/0003-disable-atk-bridge.patch
 create mode 100644 package/lld/Config.in.host
 create mode 100644 package/lld/lld.hash
 create mode 100644 package/lld/lld.mk
 create mode 100644 package/llvm/Config.in.host
Signature · 1 line
2.17.1
#1 lore raw

RFC PATCH v5 1/6 at-spi2-core: new package

---
 DEVELOPERS                             |  1 +
 package/Config.in                      |  1 +
 package/at-spi2-core/Config.in         | 24 ++++++++++++++++++++++++
 package/at-spi2-core/at-spi2-core.hash |  3 +++
 package/at-spi2-core/at-spi2-core.mk   | 16 ++++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/at-spi2-core/Config.in
 create mode 100644 package/at-spi2-core/at-spi2-core.hash
 create mode 100644 package/at-spi2-core/at-spi2-core.mk
DEVELOPERS +1 -0
index d22ac527fa..b721b3592a 100644
@@ -974,6 +974,7 @@ F:	board/qemu/ppc64le-pseries/
 F:	configs/qemu_ppc64le_pseries_defconfig
 
 N:	Joseph Kogut <[email protected]>
+F:	package/at-spi2-core/
 F:	package/gconf/
 F:	package/libnss/
 F:	package/python-cython/
package/Config.in +1 -0
index a5ecfecbf9..56e6b2f2bd 100644
@@ -1130,6 +1130,7 @@ endmenu
 
 menu "Graphics"
 	source "package/assimp/Config.in"
+	source "package/at-spi2-core/Config.in"
 	source "package/atk/Config.in"
 	source "package/atkmm/Config.in"
 	source "package/bullet/Config.in"
package/at-spi2-core/Config.in new file +24 -0
new file mode 100644
index 0000000000..43110e0bf4
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_AT_SPI2_CORE
+	bool "at-spi2-core"
+	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_XLIB_LIBXTST
+	help
+	  The At-Spi2 Core package is a part of the GNOME
+	  Accessibility Project. It provides a Service Provider
+	  Interface for the Assistive Technologies available on the
+	  GNOME platform and a library against which applications
+	  can be linked.
+
+	  https://wiki.gnome.org/Accessibility
+
+comment "at-spi2-core needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-core depends on X.org"
+	depends on !BR2_PACKAGE_XORG7
package/at-spi2-core/at-spi2-core.hash new file +3 -0
new file mode 100644
index 0000000000..9c96da312b
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 42a2487ab11ce43c288e73b2668ef8b1ab40a0e2b4f94e80fca04ad27b6f1c87  at-spi2-core-2.28.0.tar.xz
+sha256 c6105b34ab6829ff5c70eba234f40053215fa9f8383ced271b0e370a1923624b  COPYING
package/at-spi2-core/at-spi2-core.mk new file +16 -0
new file mode 100644
index 0000000000..243c9192be
@@ -0,0 +1,16 @@
+################################################################################
+#
+# at-spi2-core
+#
+################################################################################
+
+AT_SPI2_CORE_VERSION_MAJOR = 2.28
+AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
+AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
+AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
+AT_SPI2_CORE_LICENSE = LGPL-2.0+
+AT_SPI2_CORE_LICENSE_FILES = COPYING
+AT_SPI2_CORE_INSTALL_STAGING = YES
+AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst
+
+$(eval $(meson-package))
Signature · 1 line
2.17.1
#2 lore raw

RFC PATCH v5 1/6 at-spi2-core: new package

Hello,

Quoted 1 line · Joseph Kogut

I've applied your patch, after doing a few additional fixes. See below.

Quoted 19 lines
package/at-spi2-core/Config.in new file +13 -0
new file mode 100644
index 0000000000..43110e0bf4
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_AT_SPI2_CORE
+	bool "at-spi2-core"
+	depends on BR2_PACKAGE_XORG7 # xlib-libxtst
+	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_DBUS
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_XLIB_LIBXTST
+	help
+	  The At-Spi2 Core package is a part of the GNOME
+	  Accessibility Project. It provides a Service Provider
+	  Interface for the Assistive Technologies available on the

package/at-spi2-core/Config.in line 23

Quoted 10 lines
package/at-spi2-core/Config.in new file +10 -0
+	  GNOME platform and a library against which applications
+	  can be linked.
+
+	  https://wiki.gnome.org/Accessibility
+
+comment "at-spi2-core needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-core depends on X.org"

I've added:

depends on BR2_USE_MMU

here, so that the comment doesn't show up on noMMU architectures where at-spi2-core will anyway not be available regardless of X.org availability.

package/at-spi2-core/Config.in

Quoted 10 lines
package/at-spi2-core/Config.in new file +9 -0
+	depends on !BR2_PACKAGE_XORG7
 
+AT_SPI2_CORE_VERSION_MAJOR = 2.28
+AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
+AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
+AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
+AT_SPI2_CORE_LICENSE = LGPL-2.0+
+AT_SPI2_CORE_LICENSE_FILES = COPYING
+AT_SPI2_CORE_INSTALL_STAGING = YES
+AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst

Having host-meson in the DEPENDENCIES variable is useless, because the meson-package infrastructure takes care of that.

Also, I had to specify -Ddbus_daemon=/usr/bin/dbus-daemon, otherwise it tries to search for the dbus-daemon program on the host machine, and errors out if it cannot find it.

Applied with those changes. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

RFC PATCH v5 1/6 at-spi2-core: new package

Hi Thomas,

Quoted 40 lines · Thomas Petazzoni

Hello,

Quoted 1 line · Joseph Kogut

I've applied your patch, after doing a few additional fixes. See below.

Quoted 19 lines
package/at-spi2-core/Config.in new file +13 -0
new file mode 100644
index 0000000000..43110e0bf4
@@ -0,0 +1,24 @@
+config BR2_PACKAGE_AT_SPI2_CORE
+     bool "at-spi2-core"
+     depends on BR2_PACKAGE_XORG7 # xlib-libxtst
+     depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, glib2
+     depends on BR2_USE_MMU # glib2
+     depends on BR2_USE_WCHAR # glib2
+     select BR2_PACKAGE_DBUS
+     select BR2_PACKAGE_LIBGLIB2
+     select BR2_PACKAGE_XLIB_LIBXTST
+     help
+       The At-Spi2 Core package is a part of the GNOME
+       Accessibility Project. It provides a Service Provider
+       Interface for the Assistive Technologies available on the

package/at-spi2-core/Config.in line 23

Quoted 10 lines
package/at-spi2-core/Config.in new file +10 -0
+       GNOME platform and a library against which applications
+       can be linked.
+
+       https://wiki.gnome.org/Accessibility
+
+comment "at-spi2-core needs a toolchain w/ wchar, threads"
+     depends on BR2_USE_MMU
+     depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-core depends on X.org"

I've added:

Quoted 8 lines

depends on BR2_USE_MMU

here, so that the comment doesn't show up on noMMU architectures where at-spi2-core will anyway not be available regardless of X.org availability.

Quoted 1 line
package/at-spi2-core/Config.in new file +1 -0
+     depends on !BR2_PACKAGE_XORG7

I'll keep that in mind.

Quoted 12 lines

package/at-spi2-core/Config.in

Quoted 8 lines
package/at-spi2-core/Config.in new file +8 -0
+AT_SPI2_CORE_VERSION_MAJOR = 2.28
+AT_SPI2_CORE_VERSION = $(AT_SPI2_CORE_VERSION_MAJOR).0
+AT_SPI2_CORE_SOURCE = at-spi2-core-$(AT_SPI2_CORE_VERSION).tar.xz
+AT_SPI2_CORE_SITE = http://ftp.gnome.org/pub/gnome/sources/at-spi2-core/$(AT_SPI2_CORE_VERSION_MAJOR)
+AT_SPI2_CORE_LICENSE = LGPL-2.0+
+AT_SPI2_CORE_LICENSE_FILES = COPYING
+AT_SPI2_CORE_INSTALL_STAGING = YES
+AT_SPI2_CORE_DEPENDENCIES = host-meson host-pkgconf dbus libglib2 xlib_libXtst

Having host-meson in the DEPENDENCIES variable is useless, because the meson-package infrastructure takes care of that.

Good point, I missed that.

Quoted 6 lines

Also, I had to specify -Ddbus_daemon=/usr/bin/dbus-daemon, otherwise it tries to search for the dbus-daemon program on the host machine, and errors out if it cannot find it.

Applied with those changes. Thanks!

Thanks for the fixes.

#4 lore raw

RFC PATCH v5 2/6 at-spi2-atk: new package

In reply to Joseph Kogut
---
 DEVELOPERS                           |  1 +
 package/Config.in                    |  1 +
 package/at-spi2-atk/Config.in        | 21 +++++++++++++++++++++
 package/at-spi2-atk/at-spi2-atk.hash |  3 +++
 package/at-spi2-atk/at-spi2-atk.mk   | 17 +++++++++++++++++
 5 files changed, 43 insertions(+)
 create mode 100644 package/at-spi2-atk/Config.in
 create mode 100644 package/at-spi2-atk/at-spi2-atk.hash
 create mode 100644 package/at-spi2-atk/at-spi2-atk.mk
DEVELOPERS +1 -0
index b721b3592a..9116db39cb 100644
@@ -974,6 +974,7 @@ F:	board/qemu/ppc64le-pseries/
 F:	configs/qemu_ppc64le_pseries_defconfig
 
 N:	Joseph Kogut <[email protected]>
+F:	package/at-spi2-atk/
 F:	package/at-spi2-core/
 F:	package/gconf/
 F:	package/libnss/
package/Config.in +1 -0
index 56e6b2f2bd..d18b542cc5 100644
@@ -1130,6 +1130,7 @@ endmenu
 
 menu "Graphics"
 	source "package/assimp/Config.in"
+	source "package/at-spi2-atk/Config.in"
 	source "package/at-spi2-core/Config.in"
 	source "package/atk/Config.in"
 	source "package/atkmm/Config.in"
package/at-spi2-atk/Config.in new file +21 -0
new file mode 100644
index 0000000000..599913c7df
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_AT_SPI2_ATK
+	bool "at-spi2-atk"
+	depends on BR2_PACKAGE_XORG7 # at-spi2-core
+	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_ATK
+	select BR2_PACKAGE_AT_SPI2_CORE
+	select BR2_PACKAGE_LIBGLIB2
+	help
+	  The At-Spi2 Atk package contains a library that bridges
+	  ATK to At-Spi2 D-Bus service.
+
+	  https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/
+
+comment "at-spi2-atk needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-atk depends on X.org"
+	depends on !BR2_PACKAGE_XORG7
package/at-spi2-atk/at-spi2-atk.hash new file +3 -0
new file mode 100644
index 0000000000..77c8f68e47
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 61891f0abae1689f6617a963105a3f1dcdab5970c4a36ded9c79a7a544b16a6e  at-spi2-atk-2.26.2.tar.xz
+sha256 c6105b34ab6829ff5c70eba234f40053215fa9f8383ced271b0e370a1923624b  COPYING
package/at-spi2-atk/at-spi2-atk.mk new file +17 -0
new file mode 100644
index 0000000000..0e9b39e8b8
@@ -0,0 +1,17 @@
+################################################################################
+#
+# at-spi2-atk
+#
+################################################################################
+
+AT_SPI2_ATK_VERSION_MAJOR = 2.26
+AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2
+AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz
+AT_SPI2_ATK_SITE =  http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR)
+AT_SPI2_ATK_LICENSE = LGPL-2.0+
+AT_SPI2_ATK_LICENSE_FILES = COPYING
+AT_SPI2_ATK_INSTALL_STAGING = YES
+AT_SPI2_ATK_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install
+AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf
+
+$(eval $(autotools-package))
Signature · 1 line
2.17.1
#5 lore raw

RFC PATCH v5 2/6 at-spi2-atk: new package

Hello,

Quoted 16 lines · Joseph Kogut
package/at-spi2-atk/Config.in new file +10 -0
new file mode 100644
index 0000000000..599913c7df
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_AT_SPI2_ATK
+	bool "at-spi2-atk"
+	depends on BR2_PACKAGE_XORG7 # at-spi2-core
+	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
+	depends on BR2_USE_MMU # glib2
+	depends on BR2_USE_WCHAR # glib2
+	select BR2_PACKAGE_ATK
+	select BR2_PACKAGE_AT_SPI2_CORE
+	select BR2_PACKAGE_LIBGLIB2
+	help

package/at-spi2-atk/Config.in line 20

Quoted 10 lines
package/at-spi2-atk/Config.in new file +10 -0
+	  The At-Spi2 Atk package contains a library that bridges
+	  ATK to At-Spi2 D-Bus service.
+
+	  https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/
+
+comment "at-spi2-atk needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-atk depends on X.org"

Just like at-spi2-core, I've added:

depends on BR2_USE_MMU

for the same reason.

package/at-spi2-atk/Config.in

Quoted 10 lines
package/at-spi2-atk/Config.in new file +9 -0
+	depends on !BR2_PACKAGE_XORG7
 
+AT_SPI2_ATK_VERSION_MAJOR = 2.26
+AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2
+AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz
+AT_SPI2_ATK_SITE =  http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR)
+AT_SPI2_ATK_LICENSE = LGPL-2.0+
+AT_SPI2_ATK_LICENSE_FILES = COPYING
+AT_SPI2_ATK_INSTALL_STAGING = YES
+AT_SPI2_ATK_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install

This line was not needed, it's the default behavior of the autotools-package infrastructure for staging installation.

package/at-spi2-atk/Config.in

Quoted 3 lines
package/at-spi2-atk/Config.in new file +3 -0
+AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf
+
+$(eval $(autotools-package))

Any reason to use autotools here instead of meson ?

Anyway, I've applied to master with the fixes detailed above.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

RFC PATCH v5 2/6 at-spi2-atk: new package

Hi Thomas,

Quoted 52 lines · Thomas Petazzoni

Hello,

Quoted 16 lines · Joseph Kogut
package/at-spi2-atk/Config.in new file +10 -0
new file mode 100644
index 0000000000..599913c7df
@@ -0,0 +1,21 @@
+config BR2_PACKAGE_AT_SPI2_ATK
+     bool "at-spi2-atk"
+     depends on BR2_PACKAGE_XORG7 # at-spi2-core
+     depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
+     depends on BR2_USE_MMU # glib2
+     depends on BR2_USE_WCHAR # glib2
+     select BR2_PACKAGE_ATK
+     select BR2_PACKAGE_AT_SPI2_CORE
+     select BR2_PACKAGE_LIBGLIB2
+     help

package/at-spi2-atk/Config.in line 20

Quoted 10 lines
package/at-spi2-atk/Config.in new file +10 -0
+       The At-Spi2 Atk package contains a library that bridges
+       ATK to At-Spi2 D-Bus service.
+
+       https://www.freedesktop.org/wiki/Accessibility/AT-SPI2/
+
+comment "at-spi2-atk needs a toolchain w/ wchar, threads"
+     depends on BR2_USE_MMU
+     depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "at-spi2-atk depends on X.org"

Just like at-spi2-core, I've added:

depends on BR2_USE_MMU

for the same reason.

package/at-spi2-atk/Config.in

Quoted 10 lines
package/at-spi2-atk/Config.in new file +9 -0
+     depends on !BR2_PACKAGE_XORG7
 
+AT_SPI2_ATK_VERSION_MAJOR = 2.26
+AT_SPI2_ATK_VERSION = $(AT_SPI2_ATK_VERSION_MAJOR).2
+AT_SPI2_ATK_SOURCE = at-spi2-atk-$(AT_SPI2_ATK_VERSION).tar.xz
+AT_SPI2_ATK_SITE =  http://ftp.gnome.org/pub/gnome/sources/at-spi2-atk/$(AT_SPI2_ATK_VERSION_MAJOR)
+AT_SPI2_ATK_LICENSE = LGPL-2.0+
+AT_SPI2_ATK_LICENSE_FILES = COPYING
+AT_SPI2_ATK_INSTALL_STAGING = YES
+AT_SPI2_ATK_INSTALL_STAGING_OPTS = DESTDIR=$(STAGING_DIR) install

This line was not needed, it's the default behavior of the autotools-package infrastructure for staging installation.

Quoted 6 lines

package/at-spi2-atk/Config.in

Quoted 3 lines
package/at-spi2-atk/Config.in new file +3 -0
+AT_SPI2_ATK_DEPENDENCIES = atk at-spi2-core libglib2 host-pkgconf
+
+$(eval $(autotools-package))

Any reason to use autotools here instead of meson ?

No, I think this is an artifact of my initial patch using an older version of the package that didn't offer meson support. I'll convert it and send a patch.

Quoted 2 lines

Anyway, I've applied to master with the fixes detailed above.

Thanks!

#7 lore raw

RFC PATCH v5 3/6 libgtk3: convert atk-bridge to optional dependency

In reply to Joseph Kogut
---
 ...3-convert-atk-bridge-to-optional-dep.patch | 76 +++++++++++++++++++
 package/libgtk3/0003-disable-atk-bridge.patch | 45 -----------
 package/libgtk3/libgtk3.mk                    |  4 +
 3 files changed, 80 insertions(+), 45 deletions(-)
 create mode 100644 package/libgtk3/0003-convert-atk-bridge-to-optional-dep.patch
 delete mode 100644 package/libgtk3/0003-disable-atk-bridge.patch
package/libgtk3/0003-convert-atk-bridge-to-optional-dep.patch new file +76 -0
new file mode 100644
index 0000000000..d92bc96d5e
@@ -0,0 +1,76 @@
+From 83aaf47828d40dbafc315c5184ff62fe9914e80a Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Thu, 21 Jun 2018 10:55:04 -0700
+Subject: [PATCH] convert atk-bridge to optional dep
+
+Signed-off-by: Joseph Kogut <[email protected]>
+---
+ configure                   | 2 +-
+ configure.ac                | 9 ++++++---
+ gtk/a11y/gtkaccessibility.c | 4 ++--
+ 3 files changed, 9 insertions(+), 6 deletions(-)
+
+diff --git a/configure b/configure
+index 9a68486..6504451 100755
+--- a/configure
++++ b/configure
+@@ -27037,7 +27037,7 @@ $as_echo "yes" >&6; }
+ fi
+ 
+ GTK_PACKAGES="atk >= 2.15.1 cairo >= 1.14.0 cairo-gobject >= 1.14.0 gdk-pixbuf-2.0 >= 2.30.0 gio-2.0 >= 2.49.4"
+-GTK_PRIVATE_PACKAGES="$ATK_PACKAGES $WAYLAND_PACKAGES $MIR_PACKAGES epoxy >= 1.0"
++GTK_PRIVATE_PACKAGES="$ATK_PACKAGES $ATK_BRIDGE_PACKAGE $WAYLAND_PACKAGES $MIR_PACKAGES epoxy >= 1.0"
+ if test "x$enable_x11_backend" = xyes -o "x$enable_wayland_backend" = xyes; then
+   GTK_PRIVATE_PACKAGES="$GTK_PRIVATE_PACKAGES pangoft2"
+ fi
+diff --git a/configure.ac b/configure.ac
+index fef0ece..ddb4e04 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -1394,15 +1394,18 @@ AC_SUBST(GDK_DEP_CFLAGS)
+ ########################################
+ 
+ if test x$enable_x11_backend = xyes; then
+-   ATK_PACKAGES="atk atk-bridge-2.0"
+-else
+    ATK_PACKAGES="atk"
++   PKG_CHECK_MODULES(ATK_BRIDGE, atk-bridge-2.0,
++      AC_DEFINE([HAVE_ATK_BRIDGE], [1], [Define to 1 if atk-bridge is available])
++      ATK_BRIDGE_PACKAGE="atk-bridge-2.0",
++      []
++   )
+ fi
+ 
+ PKG_CHECK_MODULES(ATK, $ATK_PACKAGES)
+ 
+ GTK_PACKAGES="atk >= atk_required_version cairo >= cairo_required_version cairo-gobject >= cairo_required_version gdk-pixbuf-2.0 >= gdk_pixbuf_required_version gio-2.0 >= glib_required_version"
+-GTK_PRIVATE_PACKAGES="$ATK_PACKAGES $WAYLAND_PACKAGES $MIR_PACKAGES epoxy >= epoxy_required_version"
++GTK_PRIVATE_PACKAGES="$ATK_PACKAGES $ATK_BRIDGE_PACKAGE $WAYLAND_PACKAGES $MIR_PACKAGES epoxy >= epoxy_required_version"
+ if test "x$enable_x11_backend" = xyes -o "x$enable_wayland_backend" = xyes; then
+   GTK_PRIVATE_PACKAGES="$GTK_PRIVATE_PACKAGES pangoft2"
+ fi
+diff --git a/gtk/a11y/gtkaccessibility.c b/gtk/a11y/gtkaccessibility.c
+index 7f0e520..f2ef2eb 100644
+--- a/gtk/a11y/gtkaccessibility.c
++++ b/gtk/a11y/gtkaccessibility.c
+@@ -37,7 +37,7 @@
+ #include <gtk/gtktogglebutton.h>
+ #include <gtk/gtkaccessible.h>
+ 
+-#ifdef GDK_WINDOWING_X11
++#ifdef HAVE_ATK_BRIDGE
+ #include <atk-bridge.h>
+ #endif
+ 
+@@ -988,7 +988,7 @@ _gtk_accessibility_init (void)
+   _gtk_accessibility_override_atk_util ();
+   do_window_event_initialization ();
+ 
+-#ifdef GDK_WINDOWING_X11
++#ifdef HAVE_ATK_BRIDGE
+   atk_bridge_adaptor_init (NULL, NULL);
+ #endif
+ 
+-- 
+2.17.1
+
package/libgtk3/0003-disable-atk-bridge.patch deleted +0 -45

45 lines not on this page · raw message

package/libgtk3/libgtk3.mk +4 -0
index 1b85d00aae..75624a4203 100644
@@ -31,6 +31,10 @@ LIBGTK3_DEPENDENCIES = host-pkgconf host-libgtk3 atk libglib2 cairo pango gdk-pi
 ifeq ($(BR2_PACKAGE_LIBGTK3_X11),y)
 LIBGTK3_DEPENDENCIES += fontconfig xlib_libX11 xlib_libXext xlib_libXrender xlib_libXi
 
+ifeq ($(BR2_PACKAGE_AT_SPI2_ATK),y)
+LIBGTK3_DEPENDENCIES += at-spi2-atk
+endif
+
 LIBGTK3_CONF_OPTS += \
 	--enable-x11-backend \
 	--x-includes=$(STAGING_DIR)/usr/include/X11 \
Signature · 1 line
2.17.1
#8 lore raw

RFC PATCH v5 4/6 llvm: add config to build backend for host arch

In reply to Joseph Kogut
---
 package/Config.in.host      |  1 +
 package/llvm/Config.in.host | 18 ++++++++++++++++++
 package/llvm/llvm.mk        |  9 ++++++++-
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 package/llvm/Config.in.host
package/Config.in.host +1 -0
index 38543e7390..d0374d351e 100644
@@ -30,6 +30,7 @@ menu "Host utilities"
 	source "package/jsmin/Config.in.host"
 	source "package/lpc3250loader/Config.in.host"
 	source "package/lttng-babeltrace/Config.in.host"
+	source "package/llvm/Config.in.host"
 	source "package/mfgtools/Config.in.host"
 	source "package/mkpasswd/Config.in.host"
 	source "package/mtd/Config.in.host"
package/llvm/Config.in.host new file +18 -0
new file mode 100644
index 0000000000..4d73fb8c75
@@ -0,0 +1,18 @@
+config BR2_PACKAGE_HOST_LLVM
+	bool "host llvm"
+	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
+	depends on BR2_HOST_GCC_AT_LEAST_4_8
+	help
+	  The LLVM Project is a collection of modular and reusable
+	  compiler and toolchain technologies.
+
+	  http://llvm.org
+
+config BR2_PACKAGE_HOST_LLVM_HOST_ARCH
+	string
+	default "AArch64" if BR2_HOSTARCH="aarch64"
+	default "X86" if BR2_HOSTARCH = "x86" || BR2_HOSTARCH = "x86_64"
+	default "ARM" if BR2_HOSTARCH = "arm"
+
+config BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH
+	bool
package/llvm/llvm.mk +8 -1
index fb0ae4ce5c..31c31630ad 100644
@@ -39,8 +39,9 @@ LLVM_CONF_OPTS += -DLLVM_BUILD_GLOBAL_ISEL=OFF
 LLVM_TARGET_ARCH = $(call qstrip,$(BR2_PACKAGE_LLVM_TARGET_ARCH))
 
 # Build backend for target architecture. This include backends like AMDGPU.
+HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
 LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
-HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
+HOST_LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(HOST_LLVM_TARGETS_TO_BUILD))"
 LLVM_CONF_OPTS += -DLLVM_TARGETS_TO_BUILD="$(subst $(space),;,$(LLVM_TARGETS_TO_BUILD))"
 
 # LLVM target to use for native code generation. This is required for JIT generation.
@@ -56,9 +57,15 @@ LLVM_CONF_OPTS += -DLLVM_TARGET_ARCH=$(LLVM_TARGET_ARCH)
 # output only $(LLVM_TARGET_ARCH) if not, and mesa3d won't build as
 # it thinks AMDGPU backend is not installed on the target.
 ifeq ($(BR2_PACKAGE_LLVM_AMDGPU),y)
+HOST_LLVM_TARGETS_TO_BUILD += AMDGPU
 LLVM_TARGETS_TO_BUILD += AMDGPU
 endif
 
+# Build backend for host architecture
+ifeq ($(BR2_PACKAGE_HOST_LLVM_ENABLE_HOST_ARCH),y)
+HOST_LLVM_TARGETS_TO_BUILD += $(call qstrip,$(BR2_PACKAGE_HOST_LLVM_HOST_ARCH))
+endif
+
 # Use native llvm-tblgen from host-llvm (needed for cross-compilation)
 LLVM_CONF_OPTS += -DLLVM_TABLEGEN=$(HOST_DIR)/bin/llvm-tblgen
 
Signature · 1 line
2.17.1
#9 lore raw

RFC PATCH v5 4/6 llvm: add config to build backend for host arch

Hi Joseph,

package/llvm/Config.in.host line 10

Quoted 10 lines · Joseph Kogut
package/llvm/Config.in.host new file +10 -0
+config BR2_PACKAGE_HOST_LLVM
+	bool "host llvm"
+	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
+	depends on BR2_HOST_GCC_AT_LEAST_4_8
+	help
+	  The LLVM Project is a collection of modular and reusable
+	  compiler and toolchain technologies.
+
+	  http://llvm.org
+

I was asked to remove this option from my first patch series, I think mainly because host-llvm was just a dependency of llvm. But in this case, as we are using llvm as a compiler, I think we should have it but we should also add "select BR2_PACKAGE_HOST_LLVM" in Config.in (same for Clang).

Quoted 3 lines

# Build backend for target architecture. This include backends like AMDGPU.
+HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)
LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)

Thomas's suggestion:

LLVM_TARGETS_TO_BUILD = $(LLVM_TARGET_ARCH)

HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGETS_TO_BUILD)

Quoted 4 lines

ifeq ($(BR2_PACKAGE_LLVM_AMDGPU),y)
+HOST_LLVM_TARGETS_TO_BUILD += AMDGPU
LLVM_TARGETS_TO_BUILD += AMDGPU
endif

Thomas's suggestion:

Delete HOST_LLVM_TARGETS_TO_BUILD += AMDGPU

Something I'm not sure of is the default backend for host.

We have HOST_LLVM_CONF_OPTS += -DLLVM_TARGET_ARCH=$(LLVM_TARGET_ARCH)

But now that there is a backend for the host, I don't know if we should select this one as default. I haven't tested with Clang yet but I think that if the target triple is correctly specified there shouldn't be any problem.

Best regards,

Valentin

#10 lore raw

RFC PATCH v5 5/6 lld: new package

In reply to Joseph Kogut
---
 DEVELOPERS                 |  1 +
 package/Config.in.host     |  1 +
 package/lld/Config.in.host | 16 ++++++++++++++++
 package/lld/lld.hash       |  3 +++
 package/lld/lld.mk         | 15 +++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/lld/Config.in.host
 create mode 100644 package/lld/lld.hash
 create mode 100644 package/lld/lld.mk
DEVELOPERS +1 -0
index 9116db39cb..7179a70f30 100644
@@ -978,6 +978,7 @@ F:	package/at-spi2-atk/
 F:	package/at-spi2-core/
 F:	package/gconf/
 F:	package/libnss/
+F:	package/lld/
 F:	package/python-cython/
 F:	package/python-raven/
 F:	package/python-schedule/
package/Config.in.host +1 -0
index d0374d351e..943ceff6e5 100644
@@ -30,6 +30,7 @@ menu "Host utilities"
 	source "package/jsmin/Config.in.host"
 	source "package/lpc3250loader/Config.in.host"
 	source "package/lttng-babeltrace/Config.in.host"
+	source "package/lld/Config.in.host"
 	source "package/llvm/Config.in.host"
 	source "package/mfgtools/Config.in.host"
 	source "package/mkpasswd/Config.in.host"
package/lld/Config.in.host new file +16 -0
new file mode 100644
index 0000000000..c04b7924fa
@@ -0,0 +1,16 @@
+config BR2_PACKAGE_HOST_LLD
+	bool "host lld"
+	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS # llvm
+	depends on BR2_HOST_GCC_AT_LEAST_4_8 # llvm
+	select BR2_PACKAGE_HOST_LLVM
+	help
+	  LLD is a linker from the LLVM project that is a drop-in
+	  replacement for system linkers, and runs much faster than
+	  them. It also provides features that are useful for
+	  toolchain developers.
+
+	  https://lld.llvm.org/
+
+comment "lld needs a toolchain w/ host gcc >= 4.8"
+	depends on BR2_PACKAGE_LLVM_ARCH_SUPPORTS
+	depends on !BR2_HOST_GCC_AT_LEAST_4_8
package/lld/lld.hash new file +3 -0
new file mode 100644
index 0000000000..ce81c7baca
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 6b8c4a833cf30230c0213d78dbac01af21387b298225de90ab56032ca79c0e0b  lld-6.0.0.src.tar.xz
+sha256 f0502d2d0e19748c534ee95ea486c092273303dbef76404c8b17dc8bf6ca441b  LICENSE.TXT
package/lld/lld.mk new file +15 -0
new file mode 100644
index 0000000000..e82970c844
@@ -0,0 +1,15 @@
+################################################################################
+#
+# lld
+#
+################################################################################
+
+LLD_VERSION = 6.0.0
+LLD_SITE = https://llvm.org/releases/$(LLD_VERSION)
+LLD_SOURCE = lld-$(LLD_VERSION).src.tar.xz
+LLD_LICENSE = NCSA
+LLD_LICENSE_FILES = LICENSE.TXT
+LLD_SUPPORTS_IN_SOURCE_BUILD = NO
+HOST_LLD_DEPENDENCIES = host-llvm
+
+$(eval $(host-cmake-package))
Signature · 1 line
2.17.1
#11 lore raw

RFC PATCH v5 6/6 chromium: new package

In reply to Joseph Kogut
---
 DEVELOPERS                                    |   1 +
 package/Config.in                             |   1 +
 ...iler_cpu_abi-for-buildroot-toolchain.patch | 102 ++++++++++++++
 .../0002-Fix-arm-build-with-glibc-2.27.patch  |  28 ++++
 package/chromium/Config.in                    |  56 ++++++++
 package/chromium/chromium.hash                |   3 +
 package/chromium/chromium.mk                  | 127 ++++++++++++++++++
 package/chromium/toolchain/BUILD.gn           |  71 ++++++++++
 8 files changed, 389 insertions(+)
 create mode 100644 package/chromium/0001-modify-compiler_cpu_abi-for-buildroot-toolchain.patch
 create mode 100644 package/chromium/0002-Fix-arm-build-with-glibc-2.27.patch
 create mode 100644 package/chromium/Config.in
 create mode 100644 package/chromium/chromium.hash
 create mode 100644 package/chromium/chromium.mk
 create mode 100644 package/chromium/toolchain/BUILD.gn
DEVELOPERS +1 -0
index 7179a70f30..6565e676e1 100644
@@ -976,6 +976,7 @@ F:	configs/qemu_ppc64le_pseries_defconfig
 N:	Joseph Kogut <[email protected]>
 F:	package/at-spi2-atk/
 F:	package/at-spi2-core/
+F:	package/chromium/
 F:	package/gconf/
 F:	package/libnss/
 F:	package/lld/
package/Config.in +1 -0
index d18b542cc5..b94b11496b 100644
@@ -14,6 +14,7 @@ menu "Audio and video applications"
 	source "package/aumix/Config.in"
 	source "package/bellagio/Config.in"
 	source "package/bluez-alsa/Config.in"
+	source "package/chromium/Config.in"
 	source "package/dvblast/Config.in"
 	source "package/dvdauthor/Config.in"
 	source "package/dvdrw-tools/Config.in"
package/chromium/0001-modify-compiler_cpu_abi-for-buildroot-toolchain.patch new file +102 -0

102 lines not on this page · raw message

package/chromium/0002-Fix-arm-build-with-glibc-2.27.patch new file +28 -0
new file mode 100644
index 0000000000..8aebbd06c8
@@ -0,0 +1,28 @@
+From aed4599c18586dfac46139a3c32011f804fdaef6 Mon Sep 17 00:00:00 2001
+From: Joseph Kogut <[email protected]>
+Date: Wed, 13 Jun 2018 13:59:24 -0700
+Subject: [PATCH] Fix arm build with glibc 2.27
+
+Upstream patch from: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1060155
+
+Signed-off-by: Joseph Kogut <[email protected]>
+---
+ third_party/crashpad/crashpad/compat/linux/sys/ptrace.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h b/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h
+index 73861576d..e5c95c7cc 100644
+--- a/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h
++++ b/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h
+@@ -34,7 +34,7 @@ static constexpr __ptrace_request PTRACE_GET_THREAD_AREA =
+ #endif  // !PTRACE_GET_THREAD_AREA && !PT_GET_THREAD_AREA && defined(__GLIBC__)
+ 
+ // https://sourceware.org/bugzilla/show_bug.cgi?id=22433
+-#if !defined(PTRACE_GETVFPREGS) && \
++#if !defined(PTRACE_GETVFPREGS) && !defined(PT_GETVFPREGS) && \
+     defined(__GLIBC__) && (defined(__arm__) || defined(__arm64__))
+ static constexpr __ptrace_request PTRACE_GETVFPREGS =
+     static_cast<__ptrace_request>(27);
+-- 
+2.17.1
+
package/chromium/Config.in new file +56 -0

56 lines not on this page · raw message

package/chromium/chromium.hash new file +3 -0
new file mode 100644
index 0000000000..4c39ac5c08
@@ -0,0 +1,3 @@
+# locally calculated
+sha256 f8b1e5319163e378027826b12cf256b97423bb90e10e2013469d96e03bc9db8a  chromium-67.0.3396.79.tar.xz
+sha256 845022e0c1db1abb41a6ba4cd3c4b674ec290f3359d9d3c78ae558d4c0ed9308  LICENSE
package/chromium/chromium.mk new file +127 -0

127 lines not on this page · raw message

package/chromium/toolchain/BUILD.gn new file +71 -0

71 lines not on this page · raw message

Signature · 1 line
2.17.1