drivers/bus: arm-cci: Use SPDX license information
A message that is not in the archive (sent off-list or not yet received): 20180622110628.GA23452@sesnaco
PATCH 3/4 drivers/bus: arm-cci: Use SPDX license information
[ + alkml, will ]
Please make sure to cc linux-arm-kernel and the appropriate maintainers (see scripts/get_maintainer.pl) for Arm related patches.
Quoted 2 lines · Mawanda Henry
SPDX licence header helps developers and machines to know the right license governing a particular file
It's good practice to update the commit log if you change the commit. Something like -
"While we are at it, also update the MODULE_LICENSE() to reflect the license version - GPL v2"
Quoted 1 line
Signed-off-by Mawanda Henry <[email protected]>
With that change,
Quoted 21 lines
--- drivers/bus/arm-cci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/bus/arm-cci.c +2
-2@@ -1,4 +1,4 @@ -// SPDX-License-Identifier: GPL-2.0-or-later +// SPDX-License-Identifier: GPL-2.0 /* * CCI cache coherent interconnect driver * @@ -575,5 +575,5 @@ EXPORT_SYMBOL_GPL(cci_probed);early_initcall (cci_init);core_initcall (cci_platform_init); -MODULE_LICENSE ("GPL" ); +MODULE_LICENSE ("GPL v2" );MODULE_DESCRIPTION ("ARM CCI support" );
PATCH 3/4 drivers/bus: arm-cci: Use SPDX license information
Quoted 13 lines · Punit Agrawal
[ + alkml, will ]
Please make sure to cc linux-arm-kernel and the appropriate maintainers (see
scripts/get_maintainer.pl) for Arm related patches.Quoted 2 lines · Mawanda Henry
SPDX licence header helps developers and machines to know the right license governing a particular file
It's good practice to update the commit log if you change the commit. Something like -
Quoted 8 lines
"While we are at it, also update the
MODULE_LICENSE()to reflect the license version - GPL v2"Quoted 1 line
Signed-off-by Mawanda Henry <[email protected]>With that change,
Acked-by Punit Agrawal <[email protected]>
Is there a v2 of this patch that I can pick up?
Will