Skip to contentSkip to conversation

ALSA: intel_hdmi: Use strlcpy() instead of strncpy()

PATCH New Takashi Iwai 1 participant 1 message Jun 27, 2018 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: intel_hdmi: Use strlcpy() instead of strncpy()

hdmi_lpe_audio_probe() copies the pcm name string via strncpy(), but as a gcc8 warning suggests, it misses a NUL terminator, and unlikely the expected result.

Use the proper one, strlcpy() instead.

---
 sound/x86/intel_hdmi_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/x86/intel_hdmi_audio.c +1 -1
index 4ed9d0c41843..edc9f5a34eff 100644
@@ -1854,7 +1854,7 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev)
 		/* setup private data which can be retrieved when required */
 		pcm->private_data = ctx;
 		pcm->info_flags = 0;
-		strncpy(pcm->name, card->shortname, strlen(card->shortname));
+		strlcpy(pcm->name, card->shortname, strlen(card->shortname));
 		/* setup the ops for playabck */
 		snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);
 
Signature · 1 line
2.17.1