Skip to contentSkip to conversation

Revert "gssd.c: Remomved a couple of warning errors"

PATCH In review Steve Dickson 1 participant 2 messages Jun 27, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "gssd.c: Remomved a couple of warning errors"

This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d. Added back the 'm' character which cause memory to be allocated for the string convertions.

---
 utils/gssd/gssd.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
utils/gssd/gssd.c +10 -10
index 7b21ee2..2c14e5f 100644
@@ -279,16 +279,16 @@ gssd_read_service_info(int dirfd, struct clnt_info *clp)
 	 * (commit bf19aacecbeebccb2c3d150a8bd9416b7dba81fe)
 	 */
 	numfields = fscanf(info,
-			   "RPC server: %s\n"
-			   "service: %s (%d) version %d\n"
-			   "address: %s\n"
-			   "protocol: %s\n"
-			   "port: %s\n",
-			   (char *)&server,
-			   (char *)&service, &program, &version,
-			   (char *)&address,
-			   (char *)&protoname,
-			   (char *)&port);
+			   "RPC server: %ms\n"
+			   "service: %ms (%d) version %d\n"
+			   "address: %ms\n"
+			   "protocol: %ms\n"
+			   "port: %ms\n",
+			   &server,
+			   &service, &program, &version,
+			   &address,
+			   &protoname,
+			   &port);
 
 
 	switch (numfields) {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 5 lines · Steve Dickson

This reverts commit 98118f5e382cdeb1acf25370768d5dfdc254ba5d. Added back the 'm' character which cause memory to be allocated for the string convertions.

Committed...

steved.

Quoted 36 lines
---
 utils/gssd/gssd.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
utils/gssd/gssd.c +10 -10
index 7b21ee2..2c14e5f 100644
@@ -279,16 +279,16 @@ gssd_read_service_info(int dirfd, struct clnt_info *clp)
 	 * (commit bf19aacecbeebccb2c3d150a8bd9416b7dba81fe)
 	 */
 	numfields = fscanf(info,
-			   "RPC server: %s\n"
-			   "service: %s (%d) version %d\n"
-			   "address: %s\n"
-			   "protocol: %s\n"
-			   "port: %s\n",
-			   (char *)&server,
-			   (char *)&service, &program, &version,
-			   (char *)&address,
-			   (char *)&protoname,
-			   (char *)&port);
+			   "RPC server: %ms\n"
+			   "service: %ms (%d) version %d\n"
+			   "address: %ms\n"
+			   "protocol: %ms\n"
+			   "port: %ms\n",
+			   &server,
+			   &service, &program, &version,
+			   &address,
+			   &protoname,
+			   &port);
 
 
 	switch (numfields) {