ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
Subsystems (3)
PATCH 1/1 ASoC: Intel: kbl_da7219_max98357a: Map BTN_0 to KEY_PLAYPAUSE
From: Mac Chiang <[email protected]>
On kbl_rt5663_max98927, commit 38a5882e4292
("ASoC: Intel: kbl_rt5663_max98927: Map BTN_0 to KEY_PLAYPAUSE") This key pair mapping to play/pause when playing Youtube
The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support.
For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA.
Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-spec
The same fix is required on Chrome kbl_da7219_max98357a.
--- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/boards/kbl_da7219_max98357a.c +1 -1
@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; -snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_MEDIA ); +snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_PLAYPAUSE );snd_jack_set_key (jack->jack,SND_JACK_BTN_1 ,KEY_VOLUMEUP );snd_jack_set_key (jack->jack,SND_JACK_BTN_2 ,KEY_VOLUMEDOWN );snd_jack_set_key (jack->jack,SND_JACK_BTN_3 ,KEY_VOICECOMMAND );
Signature · 1 line
2.7.4
Hi Mac,
Quoted 13 lines · On Thu, Jun 28, 2018 at 02:11:07PM +0800, [email protected] wrote:
From: Mac Chiang <[email protected]>
On
kbl_rt5663_max98927, commit38a5882e4292
("ASoC: Intel:kbl_rt5663_max98927: MapBTN_0toKEY_PLAYPAUSE") This key pair mapping to play/pause when playing YoutubeThe Android 3.5mm Headset jack specification mentions that
BTN_0should be mapped toKEY_MEDIA, but this is less logical thanKEY_PLAYPAUSE, which has much broader userspace support.For example, the Chrome OS userspace now supports
KEY_PLAYPAUSEto toggle play/pause of videos and audio, but does not handleKEY_MEDIA.
Quoted 7 lines
Furthermore, Android itself now supports
KEY_PLAYPAUSEequivalently, as the new USB headset spec requiresKEY_PLAYPAUSEforBTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-specThe same fix is required on Chrome
kbl_da7219_max98357a.Signed-off-by Mac Chiang <[email protected]>
Signature · 7 lines
Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. [email protected] Chromium OS Project [email protected]
Quoted 13 lines · On 6/27/18 11:11 PM, [email protected] wrote:
From: Mac Chiang <[email protected]>
On
kbl_rt5663_max98927, commit38a5882e4292
("ASoC: Intel:kbl_rt5663_max98927: MapBTN_0toKEY_PLAYPAUSE") This key pair mapping to play/pause when playing YoutubeThe Android 3.5mm Headset jack specification mentions that
BTN_0should be mapped toKEY_MEDIA, but this is less logical thanKEY_PLAYPAUSE, which has much broader userspace support.For example, the Chrome OS userspace now supports
KEY_PLAYPAUSEto toggle play/pause of videos and audio, but does not handleKEY_MEDIA.
Quoted 7 lines
Furthermore, Android itself now supports
KEY_PLAYPAUSEequivalently, as the new USB headset spec requiresKEY_PLAYPAUSEforBTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-specThe same fix is required on Chrome
kbl_da7219_max98357a.Signed-off-by Mac Chiang <[email protected]>
this is aligned with a recent patch for the same headset for an AMD platform. We'd need the same fix for the bxt_da7219 machine driver btw. Naveen, is this something you can look into? Thanks!
Quoted 18 lines
--- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/intel/boards/kbl_da7219_max98357a.c +1
-1@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; -snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_MEDIA ); +snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_PLAYPAUSE );snd_jack_set_key (jack->jack,SND_JACK_BTN_1 ,KEY_VOLUMEUP );snd_jack_set_key (jack->jack,SND_JACK_BTN_2 ,KEY_VOLUMEDOWN );snd_jack_set_key (jack->jack,SND_JACK_BTN_3 ,KEY_VOICECOMMAND );
Quoted 20 lines · Pierre-Louis Bossart
Quoted 19 lines · On 6/27/18 11:11 PM, [email protected] wrote:
From: Mac Chiang <[email protected]>
On
kbl_rt5663_max98927, commit38a5882e4292
("ASoC: Intel:kbl_rt5663_max98927: MapBTN_0toKEY_PLAYPAUSE") This key pair mapping to play/pause when playing YoutubeThe Android 3.5mm Headset jack specification mentions that
BTN_0should be mapped toKEY_MEDIA, but this is less logical thanKEY_PLAYPAUSE, which has much broader userspace support.For example, the Chrome OS userspace now supports
KEY_PLAYPAUSEto toggle play/pause of videos and audio, but does not handleKEY_MEDIA.Furthermore, Android itself now supports
KEY_PLAYPAUSEequivalently, as the new USB headset spec requiresKEY_PLAYPAUSEforBTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-specThe same fix is required on Chrome
kbl_da7219_max98357a.
Quoted 9 lines
Quoted 1 line
Signed-off-by Mac Chiang <[email protected]>this is aligned with a recent patch for the same headset for an AMD platform. We'd need the same fix for the
bxt_da7219machine driver btw. Naveen, is this something you can look into? Thanks!
Agreed Pierre, earlier I have submitted a patch on this for bxt_da7219 -
https://patchwork.kernel.org/patch/10335295/
Also I have updated the same for recently ack'd glk_rt5682_max machine.
Quoted 17 lines
Quoted 16 lines
--- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/intel/boards/kbl_da7219_max98357a.c +1
-1@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; -snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_MEDIA ); +snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_PLAYPAUSE );snd_jack_set_key (jack->jack,SND_JACK_BTN_1 ,KEY_VOLUMEUP );snd_jack_set_key (jack->jack,SND_JACK_BTN_2 ,KEY_VOLUMEDOWN );snd_jack_set_key (jack->jack,SND_JACK_BTN_3 ,KEY_VOICECOMMAND );
Quoted 25 lines · On 6/29/18 12:59 AM, [email protected] wrote:
Quoted 24 lines · Pierre-Louis Bossart
Quoted 13 lines · On 6/27/18 11:11 PM, [email protected] wrote:
From: Mac Chiang <[email protected]>
On
kbl_rt5663_max98927, commit38a5882e4292
("ASoC: Intel:kbl_rt5663_max98927: MapBTN_0toKEY_PLAYPAUSE") This key pair mapping to play/pause when playing YoutubeThe Android 3.5mm Headset jack specification mentions that
BTN_0should be mapped toKEY_MEDIA, but this is less logical thanKEY_PLAYPAUSE, which has much broader userspace support.For example, the Chrome OS userspace now supports
KEY_PLAYPAUSEto toggle play/pause of videos and audio, but does not handleKEY_MEDIA.Quoted 7 lines
Furthermore, Android itself now supports
KEY_PLAYPAUSEequivalently, as the new USB headset spec requiresKEY_PLAYPAUSEforBTN_0.
https://source.android.com/devices/accessories/headset/usb-headset-specThe same fix is required on Chrome
kbl_da7219_max98357a.Signed-off-by Mac Chiang <[email protected]>
Quoted 8 lines
Quoted 5 lines
this is aligned with a recent patch for the same headset for an AMD platform. We'd need the same fix for the
bxt_da7219machine driver btw. Naveen, is this something you can look into? Thanks!Agreed Pierre, earlier I have submitted a patch on this for
bxt_da7219-
https://patchwork.kernel.org/patch/10335295/
Also I have updated the same for recently ack'dglk_rt5682_maxmachine.
Right, but neither of those patches were merged? I may be mistaken but this code wasn't in Mark's tree when I looked yesterday.
Quoted 18 lines
Quoted 17 lines
Quoted 16 lines
--- sound/soc/intel/boards/kbl_da7219_max98357a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/soc/intel/boards/kbl_da7219_max98357a.c +1
-1@@ -188,7 +188,7 @@ static int kabylake_da7219_codec_init(struct snd_soc_pcm_runtime *rtd) jack = &ctx->kabylake_headset; -snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_MEDIA ); +snd_jack_set_key (jack->jack,SND_JACK_BTN_0 ,KEY_PLAYPAUSE );snd_jack_set_key (jack->jack,SND_JACK_BTN_1 ,KEY_VOLUMEUP );snd_jack_set_key (jack->jack,SND_JACK_BTN_2 ,KEY_VOLUMEDOWN );snd_jack_set_key (jack->jack,SND_JACK_BTN_3 ,KEY_VOICECOMMAND );