ARM: dts: armada388-clearfog: enable spi flash

The current device-tree description of the SolidRun Armada 38x platforms has been successfully tested with production systems.

Quoted 2 lines · Baruch Siach

The current device-tree description of the SolidRun Armada 38x platforms has been successfully tested with production systems.

Hi Baruch

For a change link this, we should have an acknowledgement from SolidRun, or maybe Russell King.

Andrew

Quoted 5 lines · Andrew Lunn

Quoted 2 lines · Baruch Siach

The current device-tree description of the SolidRun Armada 38x platforms has been successfully tested with production systems.

Quoted 6 lines

Hi Baruch

For a change link this, we should have an acknowledgement from SolidRun, or maybe Russell King.

Andrew

Acked-by Jon Nettleton <[email protected]>

The current device-tree description of the SolidRun Armada 38x platforms has been successfully tested with production systems.

Signed-off-by Baruch Siach <[email protected]>

The current device-tree description of the SolidRun Armada 38x platforms has been successfully tested with production systems.

Signed-off-by Baruch Siach <[email protected]>

---
 arch/arm/boot/dts/armada-388-clearfog-base.dts      | 5 -----
 arch/arm/boot/dts/armada-388-clearfog-pro.dts       | 5 -----
 arch/arm/boot/dts/armada-388-clearfog.dts           | 5 -----
 arch/arm/boot/dts/armada-388-clearfog.dtsi          | 5 -----
 arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 5 -----
 5 files changed, 25 deletions(-)

arch/arm/boot/dts/armada-388-clearfog-base.dts +0 -5

index 50ed4ae5c621..53b4bd35522a 100644
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Base revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 /dts-v1/;

arch/arm/boot/dts/armada-388-clearfog-pro.dts +0 -5

index 24e4b5a509be..ff890c09c3ed 100644
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 #include "armada-388-clearfog.dts"
 

arch/arm/boot/dts/armada-388-clearfog.dts +0 -5

index 5fd0f6f61e77..32b1e09b8293 100644
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Clearfog Pro revision A1 rev 2.0 (88F6828)
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 /dts-v1/;

arch/arm/boot/dts/armada-388-clearfog.dtsi +0 -5

index 0d9dfdfe977e..1da40bdfcef1 100644
@@ -3,11 +3,6 @@
  * Device Tree include file for SolidRun Clearfog 88F6828 based boards
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 
 #include "armada-388.dtsi"

arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi +0 -5

index c990d502d9a4..3a7f9c1ac346 100644
@@ -3,11 +3,6 @@
  * Device Tree file for SolidRun Armada 38x Microsom
  *
  *  Copyright (C) 2015 Russell King
- *
- * This board is in development; the contents of this file work with
- * the A1 rev 2.0 of the board, which does not represent final
- * production board.  Things will change, don't expect this file to
- * remain compatible info the future.
  */
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/gpio/gpio.h>

Signature · 7 lines

2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Signed-off-by Baruch Siach <[email protected]>

---
 arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi | 1 -
 1 file changed, 1 deletion(-)

arch/arm/boot/dts/armada-38x-solidrun-microsom.dtsi +0 -1

index 2d1cea131e71..c990d502d9a4 100644
@@ -99,7 +99,6 @@
 		compatible = "w25q32", "jedec,spi-nor";
 		reg = <0>; /* Chip select 0 */
 		spi-max-frequency = <3000000>;
-		status = "disabled";
 	};
 };
 

Signature · 7 lines

2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Hi Baruch,

Quoted 5 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Signed-off-by Baruch Siach <[email protected]>

Applied on mvebu/dt

Quoted 8 lines · Gregory CLEMENT

Hi Baruch,

Quoted 4 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Quoted 3 lines

Quoted 1 line

Signed-off-by Baruch Siach <[email protected]>

Applied on mvebu/dt

It would be nice if you waited for acks or review before picking up patches. Only patch 2 has been acked and reviewed.

Signature · 4 lines

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Quoted 3 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Are you sure about that - at least some of my boards do not have the SPI flash populated.

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */

...
&spi1 {
/*
* Add SPI CS pins for clearfog:
* CS0: W25Q32 (not populated on uSOM)

* CS1: PIC microcontroller (Pro models)
* CS2: mikrobus
*/

I wouldn't have written "not populated on uSOM" without having first taken the uSOM off and physically checked.

Hi Russell,

Thanks for reviewing.

Quoted 8 lines · Russell King - ARM Linux

Quoted 3 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Are you sure about that - at least some of my boards do not have the SPI flash populated.

Quoted 7 lines

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */

...
&spi1 {
/*
* Add SPI CS pins for clearfog:
* CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

Quoted 6 lines

* CS1: PIC microcontroller (Pro models)
* CS2: mikrobus
*/

I wouldn't have written "not populated on uSOM" without having first taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

Ilya Viten from the SolidRun commercial department told me that all production SOMs that were shipped to customers have the SPI flash populated.

This is just the default value for the common case.

Quoted 21 lines · Baruch Siach

Thanks for reviewing.

Quoted 8 lines · Russell King - ARM Linux

Quoted 3 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Are you sure about that - at least some of my boards do not have the SPI flash populated.

Quoted 7 lines

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */

...
&spi1 {
/*
* Add SPI CS pins for clearfog:
* CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

Quoted 8 lines

Quoted 6 lines

* CS1: PIC microcontroller (Pro models)
* CS2: mikrobus
*/

I wouldn't have written "not populated on uSOM" without having first taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

I don't remember.

Quoted 2 lines

Ilya Viten from the SolidRun commercial department told me that all production SOMs that were shipped to customers have the SPI flash populated.

Yes, Jon confirms that.

Quoted 1 line

This is just the default value for the common case.

Has it been tested with boards that don't have the SPI flash populated? That needs to happen to make sure that this doesn't cause a regression.

Hi Russell,

Quoted 36 lines · Russell King - ARM Linux

Quoted 21 lines · Baruch Siach

Thanks for reviewing.

Quoted 8 lines · Russell King - ARM Linux

Quoted 3 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Are you sure about that - at least some of my boards do not have the SPI flash populated.

Quoted 7 lines

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */

...
&spi1 {
/*
* Add SPI CS pins for clearfog:
* CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

Quoted 8 lines

Quoted 6 lines

* CS1: PIC microcontroller (Pro models)
* CS2: mikrobus
*/

I wouldn't have written "not populated on uSOM" without having first taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

I don't remember.

Quoted 2 lines

Ilya Viten from the SolidRun commercial department told me that all production SOMs that were shipped to customers have the SPI flash populated.

Quoted 6 lines

Yes, Jon confirms that.

Quoted 1 line

This is just the default value for the common case.

Has it been tested with boards that don't have the SPI flash populated? That needs to happen to make sure that this doesn't cause a regression.

I don't have such a SOM handy. I can try to "produce" one next week.

I tested a modified DT with the 'reg' property set to 1 to simulate an unpopulated SPI flash. The driver probe seems to fail gracefully:

m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff

Is this test sufficient to ensure the safety of this patch?

Quoted 53 lines · Baruch Siach

Hi Russell,

Quoted 36 lines · Russell King - ARM Linux

Quoted 21 lines · Baruch Siach

Thanks for reviewing.

Quoted 8 lines · Russell King - ARM Linux

Quoted 3 lines · Baruch Siach

The SolidRun Armada 388 SOM has the SPI flash populated by default unless the customer explicitly asks otherwise. Enable support by default.

Are you sure about that - at least some of my boards do not have the SPI flash populated.

Quoted 7 lines

&spi1 {
        /* The microsom has an optional W25Q32 on board, connected to CS0 */

...
&spi1 {
/*
* Add SPI CS pins for clearfog:
* CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

Quoted 8 lines

Quoted 6 lines

* CS1: PIC microcontroller (Pro models)
* CS2: mikrobus
*/

I wouldn't have written "not populated on uSOM" without having first taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

I don't remember.

Quoted 2 lines

Ilya Viten from the SolidRun commercial department told me that all production SOMs that were shipped to customers have the SPI flash populated.

Quoted 6 lines

Yes, Jon confirms that.

Quoted 1 line

This is just the default value for the common case.

Has it been tested with boards that don't have the SPI flash populated? That needs to happen to make sure that this doesn't cause a regression.

I don't have such a SOM handy. I can try to "produce" one next week.

I tested a modified DT with the 'reg' property set to 1 to simulate an unpopulated SPI flash. The driver probe seems to fail gracefully:

m25p80 spi1.1: unrecognized JEDEC id bytes: ff, ff, ff

Quoted 1 line

Is this test sufficient to ensure the safety of this patch?

Yes, that's fine, thanks for checking.

Acked-by Russell King <[email protected]>

Gregory, please add my acked-by to your hasty commit, thanks.

Signature · 4 lines

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up