Skip to contentSkip to conversation

trousers/tpm-tools: enable on ARC

PATCH New Evgeniy Didin 2 participants 2 messages Jun 28, 2018

lore
Share & tools
lore

Evgeniy Didin

author
#0 lore raw

PATCH 1/1 trousers/tpm-tools: enable on ARC

With the latest ARC toolchain arc-2018.03 builds of "trousers" and "tpm-tools" packages perform without errors.
Lets enable these packages for ARC.

With the exception, building tpm-tools for ARC770/750 requires to pass "-mno-compact-casesi" as it was made for trousers before:
see patch f4cd8ceb9cfa "trousers: Pass "-mno-compact-casesi" when building for ARCv1".
This change is a temporary workaround and the feature is going to be fixed in the next ARC toolchain release version.

Signed-off-by Evgeniy Didin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc arc-buildroot at synopsys.com
---
 package/tpm-tools/Config.in    | 2 --
 package/tpm-tools/tpm-tools.mk | 4 ++++
 package/trousers/Config.in     | 3 ---
 3 files changed, 4 insertions(+), 5 deletions(-)
package/tpm-tools/Config.in +0 -2
index e115687281..ca70adc80c 100644
@@ -2,7 +2,6 @@ config BR2_PACKAGE_TPM_TOOLS
 	bool "tpm-tools"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # trousers
 	depends on !BR2_STATIC_LIBS # trousers
-	depends on !BR2_arc # trousers
 	select BR2_PACKAGE_TROUSERS
 	select BR2_PACKAGE_OPENSSL
 	help

@@ -12,4 +11,3 @@ config BR2_PACKAGE_TPM_TOOLS
 
 comment "tpm-tools needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-	depends on !BR2_arc
package/tpm-tools/tpm-tools.mk +4 -0
index b6738251ff..623e06fb98 100644
@@ -16,4 +16,8 @@ ifeq ($(BR2_PACKAGE_LIBICONV),y)
 TPM_TOOLS_CONF_ENV += LIBS='-liconv'
 endif
 
+ifeq ($(BR2_arc770d)$(BR2_arc750d),y)
+TPM_TOOLS_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -mno-compact-casesi"
+endif
+
 $(eval $(autotools-package))
package/trousers/Config.in +0 -3
index 7a1470629a..998df98398 100644
@@ -3,8 +3,6 @@ config BR2_PACKAGE_TROUSERS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# doesn't build properly in static only configurations
 	depends on !BR2_STATIC_LIBS
-	# ARC toolchain issue
-	depends on !BR2_arc
 	select BR2_PACKAGE_OPENSSL
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
 	help

@@ -18,4 +16,3 @@ config BR2_PACKAGE_TROUSERS
 
 comment "trousers needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
-	depends on !BR2_arc
Signature · 1 line
2.17.1
Applied
#1 lore raw

PATCH 1/1 trousers/tpm-tools: enable on ARC

Hello,

Quoted 11 lines · Evgeniy Didin

With the latest ARC toolchain arc-2018.03 builds of "trousers" and "tpm-tools" packages perform without errors.
Lets enable these packages for ARC.

With the exception, building tpm-tools for ARC770/750 requires to pass "-mno-compact-casesi" as it was made for trousers before:
see patch f4cd8ceb9cfa "trousers: Pass "-mno-compact-casesi" when building for ARCv1".
This change is a temporary workaround and the feature is going to be fixed in the next ARC toolchain release version.

Quoted 8 lines
Signed-off-by Evgeniy Didin <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc arc-buildroot at synopsys.com
---
 package/tpm-tools/Config.in    | 2 --
 package/tpm-tools/tpm-tools.mk | 4 ++++
 package/trousers/Config.in     | 3 ---
 3 files changed, 4 insertions(+), 5 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com