dmaengine: fsl-edma: add ColdFire mcf5441x edma support
PATCH v5 2/2 dmaengine: fsl-edma: add ColdFire mcf5441x edma support
Hi Vinod and Geert,
Quoted 19 lines · Vinod
Quoted 18 lines · Geert Uytterhoeven
Hi Vinod,
Quoted 14 lines · Vinod
Quoted 11 lines · Geert Uytterhoeven
Quoted 7 lines · Vinod
Quoted 4 lines · Angelo Dureghello
obj-$(CONFIG_EP93XX_DMA) += ep93xx_dma.o obj-$(CONFIG_FSL_DMA) += fsldma.o obj-$(CONFIG_FSL_EDMA) += fsl-edma.o fsl-edma-common.o
+obj-$(CONFIG_MCF_EDMA) += mcf-edma.o fsl-edma-common.othat makes kernel have two copies of common.o one in thsi driver and one
Does it? It's a common pattern in several Makefiles (e.g.
drivers/net/ethernet/8390/Makefileanddrivers/scsi/Makefile)won't each static symbol be part each one?
Quoted 8 lines
Quoted 5 lines
Remember, obj-y is a list, and IIRC it's filtered for duplicates.
Quoted 1 line
What about when they are modules?
Same thing, you'll have fsl-edma-common.ko, and fsl-edma.ko and/or mcf-edma.ko.
Yeah that is right, I missed the list part
Ok, so if i understand, i'll fix all the Vinod points except the Kconfig/makefile part that seems ok as is.
Vinod,
what do you think, am i near to a possible "accept" in a v6 or v7 ? Or do you see any additional great job to do or other important blocking points ?
Thanks,
regards,
Angelo Dureghello
Quoted 6 lines
Signature · 5 lines
~Vinod -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html