wampcc: new package
PATCH 1/1 wampcc: new package
Signed-off-by Sven Neumann <[email protected]>
--- package/Config.in | 1 + package/wampcc/Config.in | 13 +++++++++++++ package/wampcc/wampcc.hash | 2 ++ package/wampcc/wampcc.mk | 14 ++++++++++++++ 4 files changed, 30 insertions(+) create mode 100644 package/wampcc/Config.in create mode 100644 package/wampcc/wampcc.hash create mode 100644 package/wampcc/wampcc.mk
package/Config.in +1 -0
@@ -1487,6 +1487,7 @@ menu "Networking" source "package/sofia-sip/Config.in" source "package/thrift/Config.in" source "package/usbredir/Config.in" + source "package/wampcc/Config.in" source "package/zeromq/Config.in" source "package/zmqpp/Config.in" source "package/zyre/Config.in"
package/wampcc/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_WAMPCC + bool "wampcc" + depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_LIBUV + select BR2_PACKAGE_JANSSON + select BR2_PACKAGE_OPENSSL + help + wampcc is C++ library that implements the Web Application Messaging Protocol protocol. + + https://github.com/darrenjs/wampcc + +comment "wampcc needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
package/wampcc/wampcc.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated +sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz
package/wampcc/wampcc.mk new file +14 -0
@@ -0,0 +1,14 @@ +################################################################################ +# +# wampcc +# +################################################################################ + +WAMPCC_VERSION = v1.6 +WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION)) +WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl +WAMPCC_INSTALL_STAGING = YES +WAMPCC_LICENSE = MIT +WAMPCC_LICENSE_FILES = LICENSE + +$(eval $(cmake-package))
Signature · 1 line
2.14.4
PATCH 1/1 wampcc: new package
Hello,
Quoted 6 lines · Sven Neumann
Signed-off-by Sven Neumann <[email protected]>--- package/Config.in | 1 + package/wampcc/Config.in | 13 +++++++++++++ package/wampcc/wampcc.hash | 2 ++ package/wampcc/wampcc.mk | 14 ++++++++++++++
Missing entry in DEVELOPERS file.
package/wampcc/Config.in line 4
Quoted 10 lines
package/wampcc/Config.in new file +4
-0@@ -0,0 +1,13 @@ +config BR2_PACKAGE_WAMPCC + bool "wampcc" + depends on !BR2_STATIC_LIBS + select BR2_PACKAGE_LIBUV
You need to replicate the dependencies of libuv.
package/wampcc/Config.in line 8
Quoted 4 lines
package/wampcc/Config.in new file +4
-0+ select BR2_PACKAGE_JANSSON + select BR2_PACKAGE_OPENSSL + help + wampcc is C++ library that implements the Web Application Messaging Protocol protocol.
This line needs to be wrapped. Please run ./utils/check-package on your package submissions, it detects a few coding style issues.
package/wampcc/wampcc.hash line 2
Quoted 8 lines
package/wampcc/wampcc.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated +sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz
A hash for the license file would be nice to have.
Quoted 10 lines
package/wampcc/wampcc.mk new file +4
-0@@ -0,0 +1,14 @@ +################################################################################ +# +# wampcc +#
package/wampcc/wampcc.mk line 14
Quoted 10 lines
package/wampcc/wampcc.mk new file +10
-0+################################################################################ + +WAMPCC_VERSION = v1.6 +WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION)) +WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl +WAMPCC_INSTALL_STAGING = YES +WAMPCC_LICENSE = MIT +WAMPCC_LICENSE_FILES = LICENSE + +$(eval $(cmake-package))
Otherwise, looks good to me.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 wampcc: new package
Signed-off-by Sven Neumann <[email protected]>
--- package/Config.in | 1 + package/wampcc/Config.in | 19 +++++++++++++++++++ package/wampcc/wampcc.hash | 3 +++ package/wampcc/wampcc.mk | 14 ++++++++++++++ 4 files changed, 37 insertions(+) create mode 100644 package/wampcc/Config.in create mode 100644 package/wampcc/wampcc.hash create mode 100644 package/wampcc/wampcc.mk
package/Config.in +1 -0
@@ -1487,6 +1487,7 @@ menu "Networking" source "package/sofia-sip/Config.in" source "package/thrift/Config.in" source "package/usbredir/Config.in" + source "package/wampcc/Config.in" source "package/zeromq/Config.in" source "package/zmqpp/Config.in" source "package/zyre/Config.in"
package/wampcc/Config.in new file +19 -0
@@ -0,0 +1,19 @@ +config BR2_PACKAGE_WAMPCC + bool "wampcc" + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_barrier_* + depends on BR2_USE_MMU # fork() + depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_SYNC_4 + select BR2_PACKAGE_LIBUV + select BR2_PACKAGE_JANSSON + select BR2_PACKAGE_OPENSSL + help + wampcc is a C++ library that implements the Web Application + Messaging Protocol. + + https://github.com/darrenjs/wampcc + +comment "wampcc needs a toolchain w/ NPTL, dynamic library" + depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS + depends on BR2_USE_MMU + depends on BR2_TOOLCHAIN_HAS_SYNC_4
package/wampcc/wampcc.hash new file +3 -0
@@ -0,0 +1,3 @@ +# Locally calculated +sha256 b3c3633b4c6a74d7ac8a676a7ea30fbfde7ae19aa1fc37de3b8aa3a553b674a2 wampcc-v1.6.tar.gz +sha256 bd185b1ec8a292d42b42346757ff6e198073e13c1e080e9ea548d34dd42d30d8 LICENSE
package/wampcc/wampcc.mk new file +14 -0
@@ -0,0 +1,14 @@ +################################################################################ +# +# wampcc +# +################################################################################ + +WAMPCC_VERSION = v1.6 +WAMPCC_SITE = $(call github,darrenjs,wampcc,$(WAMPCC_VERSION)) +WAMPCC_DEPENDENCIES = host-pkgconf libuv jansson openssl +WAMPCC_INSTALL_STAGING = YES +WAMPCC_LICENSE = MIT +WAMPCC_LICENSE_FILES = LICENSE + +$(eval $(cmake-package))
Signature · 1 line
2.14.4
PATCH 2/2 DEVELOPERS: add myself for wampcc
Also move packages from my old email company address to the new one.
Signed-off-by Sven Neumann <[email protected]>
--- DEVELOPERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
DEVELOPERS +2 -3
@@ -1880,12 +1880,11 @@ F: package/lcdproc/ F: package/python-influxdb/ N: Sven Neumann <[email protected]> -F: package/gstreamer1/gst1-libav/ - -N: Sven Neumann <[email protected]> F: package/glib-networking/ +F: package/gstreamer1/gst1-libav/ F: package/libmms/ F: package/orc/ +F: package/wampcc/ N: S?bastien Szymanski <[email protected]> F: package/mmc-utils/
Signature · 1 line
2.14.4
PATCH 2/2 DEVELOPERS: add myself for wampcc
Hello,
Quoted 6 lines · Sven Neumann
Also move packages from my old email company address to the new one.
Signed-off-by Sven Neumann <[email protected]>--- DEVELOPERS | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
I've applied, after reworking the commit to not add wampcc (done in the previous commit) and adjusting the commit log accordingly.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 wampcc: new package
In reply to Sven NeumannHello,
I've applied, after fixing a few issues, see below.
Quoted 10 lines · Sven Neumann
Signed-off-by Sven Neumann <[email protected]>--- package/Config.in | 1 + package/wampcc/Config.in | 19 +++++++++++++++++++ package/wampcc/wampcc.hash | 3 +++ package/wampcc/wampcc.mk | 14 ++++++++++++++ 4 files changed, 37 insertions(+) create mode 100644 package/wampcc/Config.in create mode 100644 package/wampcc/wampcc.hash create mode 100644 package/wampcc/wampcc.mk
The entry to the DEVELOPERS file was still missing. I know it was in your second patch, but the addition of wampcc to DEVELOPERS should have been with this patch.
package/wampcc/Config.in line 6
Quoted 12 lines
package/wampcc/Config.in new file +6
-0@@ -0,0 +1,19 @@ +config BR2_PACKAGE_WAMPCC + bool "wampcc" + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_barrier_* + depends on BR2_USE_MMU # fork() + depends on !BR2_STATIC_LIBS + depends on BR2_TOOLCHAIN_HAS_SYNC_4
Those dependencies come from libuv, some instead of "fork()" and "pthread_barrier_" which are the reason for libuv to have those dependencies, we prefer to have the reason for wampcc to have those dependencies, i.e the fact that it selects libuv. So:
depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
and so on.
Also, another dependency was missing: BR2_TOOLCHAIN_HAS_GCC_BUG_64735. The C++ code uses std::shared_future, which doesn't work on gcc < 7.x on some architectures.
As I said above, I fixed those issues and applied.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com