Skip to contentSkip to conversation

kni: Fix kni_autotest for new Rx/Tx offloads API

PATCH In review Dan Gora 3 participants 5 messages Jun 28, 2018 – Aug 8, 2018

lore
Share & tools
lore

Dan Gora

author
#0 lore raw

PATCH 1/1 kni: Fix kni_autotest for new Rx/Tx offloads API

Fixed a bug where kni_autotest would not start due to the lack of the ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to old offloads API helpers")

Signed-off-by Dan Gora <[email protected]>
---
 test/test/test_kni.c | 1 +
 1 file changed, 1 insertion(+)
test/test/test_kni.c +1 -0
index ec051c07e..0b08e9d66 100644
@@ -67,6 +67,7 @@ static const struct rte_eth_txconf tx_conf = {
 	},
 	.tx_free_thresh = 0,
 	.tx_rs_thresh = 0,
+	.txq_flags = ETH_TXQ_FLAGS_IGNORE,
 };
 
 static const struct rte_eth_conf port_conf = {
Signature · 1 line
2.18.0.rc1.1.g6f333ff2f
#1 lore raw

29/06/2018 01:02, Dan Gora:

Quoted 6 lines

Fixed a bug where kni_autotest would not start due to the lack of the ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to old offloads API helpers")

The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.

author
#2 lore raw

Hi Thomas,

thanks... Is it worthwhile to mark this patch as eligible for backporting?

d

Quoted 12 lines · Thomas Monjalon

29/06/2018 01:02, Dan Gora:

Quoted 6 lines

Fixed a bug where kni_autotest would not start due to the lack of the ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to old offloads API helpers")

The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.

#3 lore raw

01/08/2018 21:50, Dan Gora:

Quoted 3 lines

Hi Thomas,

thanks... Is it worthwhile to mark this patch as eligible for backporting?

I don't think so.
Ferruh?

Quoted 14 lines · Thomas Monjalon
Quoted 12 lines

29/06/2018 01:02, Dan Gora:

Quoted 6 lines

Fixed a bug where kni_autotest would not start due to the lack of the ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to old offloads API helpers")

The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.

#4 lore raw
Quoted 7 lines · Thomas Monjalon

01/08/2018 21:50, Dan Gora:

Quoted 3 lines

Hi Thomas,

thanks... Is it worthwhile to mark this patch as eligible for backporting?

I don't think so.
Ferruh?

Same here, I don't think required to backport this.

Quoted 21 lines
Quoted 16 lines · Thomas Monjalon
Quoted 12 lines

29/06/2018 01:02, Dan Gora:

Quoted 6 lines

Fixed a bug where kni_autotest would not start due to the lack of the ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure passed to rte_eth_tx_queue_setup.

This was introduced in commit 4b954bb16747 ("ethdev: remove new to old offloads API helpers")

The flag ETH_TXQ_FLAGS_IGNORE has been removed in 18.08.