Skip to contentSkip to conversation

qt5base: remove unused definition

PATCH New Gaël PORTAY 4 participants 4 messages Jun 30, 2018 – Jul 19, 2018

lore
Share & tools
lore

Gaël PORTAY

author
#0 lore raw

PATCH 1/1 qt5base: remove unused definition

Since commit 81fb33af2a (qt5base: correct eglfs support in qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left unused.

Remove it since it is not used anymore.

Signed-off-by Ga?l PORTAY <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)
package/qt5/qt5base/qt5base.mk +0 -1
index d5b25abcb8..9eafd593f1 100644
@@ -269,7 +269,6 @@ define QT5BASE_CONFIGURE_CMDS
 	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
 		$(QT5BASE_PKGDIR)/qmake.conf.in > \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
-	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
 	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
 	$(QT5BASE_CONFIGURE_CONFIG_FILE)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 qt5base: remove unused definition

Ga?l, All,

On 2018-06-30 08:57 -0400, Ga?l PORTAY spake thusly:

Quoted 7 lines

Since commit 81fb33af2a (qt5base: correct eglfs support in qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left unused.

Remove it since it is not used anymore.

Signed-off-by Ga?l PORTAY <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)
package/qt5/qt5base/qt5base.mk +0 -1
index d5b25abcb8..9eafd593f1 100644
@@ -269,7 +269,6 @@ define QT5BASE_CONFIGURE_CMDS
 	sed 's/@EGLFS_DEVICE@/$(QT5BASE_EGLFS_DEVICE)/g' \
 		$(QT5BASE_PKGDIR)/qmake.conf.in > \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qmake.conf
-	$(QT5BASE_CONFIGURE_QMAKE_CONFIG)
 	$(INSTALL) -m 0644 -D $(QT5BASE_PKGDIR)/qplatformdefs.h \
 		$(@D)/mkspecs/devices/linux-buildroot-g++/qplatformdefs.h
 	$(QT5BASE_CONFIGURE_CONFIG_FILE)
Signature · 6 lines
2.17.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
Applied
#2 lore raw

PATCH 1/1 qt5base: remove unused definition

In reply to Gaël PORTAY

Hello,

Quoted 10 lines · Ga?l PORTAY

Since commit 81fb33af2a (qt5base: correct eglfs support in qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left unused.

Remove it since it is not used anymore.

Signed-off-by Ga?l PORTAY <[email protected]>
---
 package/qt5/qt5base/qt5base.mk | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 qt5base: remove unused definition

In reply to Gaël PORTAY
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Ga?l" == Ga?l PORTAY <[email protected]> writes:

Since commit 81fb33af2a (qt5base: correct eglfs support in qmake.conf.in) the definition QT5BASE_CONFIGURE_QMAKE_CONFIG is left unused.

Remove it since it is not used anymore.

Signed-off-by Ga?l PORTAY <[email protected]>

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard