Skip to contentSkip to conversation

ARM: imx_v6_v7_defconfig: Re-sync defconfig

PATCH New Fabio Estevam 3 participants 10 messages Jun 25, 2018 – Jul 3, 2018

Subsystems (2)
Arm (32-bit) Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 ARM: imx_v6_v7_defconfig: Re-sync defconfig

From: Fabio Estevam <[email protected]>

Re-sync imx_v6_v7_defconfig by doing:

make savedefconfig
cp defconfig arch/arm/configs/imx_v6_v7_defconfig

CONFIG_BT_HCIUART_H4 option is selected via Kconfig logic.

CONFIG_SND_SOC_IMX_WM8962 no longer exists as the imx-wm8962 audio machine layer has been removed.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/imx_v6_v7_defconfig | 2 --
 1 file changed, 2 deletions(-)
arch/arm/configs/imx_v6_v7_defconfig +0 -2
index f70507a..d14de86 100644
@@ -81,7 +81,6 @@ CONFIG_CAN=y
 CONFIG_CAN_FLEXCAN=y
 CONFIG_BT=y
 CONFIG_BT_HCIUART=y
-CONFIG_BT_HCIUART_H4=y
 CONFIG_BT_HCIUART_LL=y
 CONFIG_CFG80211=y
 CONFIG_CFG80211_WEXT=y

@@ -282,7 +281,6 @@ CONFIG_SND_SOC_FSL_ASRC=y
 CONFIG_SND_IMX_SOC=y
 CONFIG_SND_SOC_PHYCORE_AC97=y
 CONFIG_SND_SOC_EUKREA_TLV320=y
-CONFIG_SND_SOC_IMX_WM8962=y
 CONFIG_SND_SOC_IMX_ES8328=y
 CONFIG_SND_SOC_IMX_SGTL5000=y
 CONFIG_SND_SOC_IMX_SPDIF=y
Signature · 1 line
2.7.4
author reviewer
#1 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/imx_v6_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +2 -0
index d14de86..2da678c 100644
@@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m

@@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

Am Montag, den 25.06.2018, 09:34 -0300 schrieb Fabio Estevam:

Quoted 7 lines

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

If the kernel hangs without those options, we might want to have a check for them in the driver, so it aborts the initialization with a big warning if the port is using ULPI mode and those options aren't selected.

Regards,
Lucas

Quoted 27 lines
Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

---
?arch/arm/configs/imx_v6_v7_defconfig | 2 ++
?1 file changed, 2 insertions(+)

arch/arm/configs/imx_v6_v7_defconfig +0 -0
index d14de86..2da678c 100644
@@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y

?CONFIG_USB_CHIPIDEA=y
?CONFIG_USB_CHIPIDEA_UDC=y
?CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
?CONFIG_USB_SERIAL=m
?CONFIG_USB_SERIAL_GENERIC=y
?CONFIG_USB_SERIAL_FTDI_SIO=m

arch/arm/configs/imx_v6_v7_defconfig +0 -0
@@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m

?CONFIG_USB_FUNCTIONFS=m
?CONFIG_USB_MASS_STORAGE=m
?CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
?CONFIG_MMC=y
?CONFIG_MMC_SDHCI=y
?CONFIG_MMC_SDHCI_PLTFM=y

author reviewer
#3 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

Hi Lucas,

Quoted 4 lines · Lucas Stach

If the kernel hangs without those options, we might want to have a check for them in the driver, so it aborts the initialization with a big warning if the port is using ULPI mode and those options aren't selected.

That's a good idea. Will do as suggested.

Thanks

#4 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Is this hang a regression or what?

Shawn

Quoted 30 lines
Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/configs/imx_v6_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/imx_v6_v7_defconfig +2 -0
index d14de86..2da678c 100644
@@ -300,6 +300,7 @@ CONFIG_USB_STORAGE=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_CHIPIDEA_ULPI=y
 CONFIG_USB_SERIAL=m
 CONFIG_USB_SERIAL_GENERIC=y
 CONFIG_USB_SERIAL_FTDI_SIO=m

@@ -336,6 +337,7 @@ CONFIG_USB_GADGETFS=m
 CONFIG_USB_FUNCTIONFS=m
 CONFIG_USB_MASS_STORAGE=m
 CONFIG_USB_G_SERIAL=m
+CONFIG_USB_ULPI_BUS=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
 CONFIG_MMC_SDHCI_PLTFM=y
Signature · 1 line
2.7.4
author reviewer
#5 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

Hi Shawn,

Quoted 10 lines · Shawn Guo
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Is this hang a regression or what?

Yes, it is a regression in 4.18-rc1 caused by commit 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51")

I have also sent a USB kernel patch that avoids the hang, but we need both the USB patch + the defconfig change in 4.18.

Thanks

#6 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Applied this one as a fix.

Shawn

#7 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

Quoted 6 lines · Shawn Guo
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

Quoted 7 lines
Quoted 5 lines

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Applied this one as a fix.

Dropped for now, as I suspect that such selection should be done by driver Kconfig as a dependency.

Shawn

#8 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Select CONFIG_USB_CHIPIDEA_ULPI and CONFIG_USB_ULPI_BUS so that USB ULPI can be functional on some boards like imx51-babbge.

This fixes a kernel hang in 4.18-rc1 on i.mx51-babbage when the bootloader does not initialize USB.

Suggested-by Andrey Smirnov <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Applied with editing the commit log a bit to mention commit 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51").

Shawn

author reviewer
#9 lore raw

PATCH 2/2 ARM: imx_v6_v7_defconfig: Select ULPI support

Quoted 2 lines · Shawn Guo

Applied with editing the commit log a bit to mention commit 03e6275ae381 ("usb: chipidea: Fix ULPI on imx51").

Thanks a lot, Shawn!