Skip to contentSkip to conversation

network-manager: sync kernel headers comment with actual dependency

PATCH New Thomas Petazzoni 4 participants 5 messages Jun 30, 2018 – Jul 19, 2018

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 network-manager: sync kernel headers comment with actual dependency

In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49 ("package/network-manager: add patches to build with kernel headers 3.2"), network-manager was changed to build with kernel headers as old as 3.2, instead of 3.7 before. The dependency was changed accordingly, but the Config.in comment was not.

This commit fixes this inconsistency.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/network-manager/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/network-manager/Config.in +2 -2
index 9602cc4a1a..ca508185f0 100644
@@ -64,8 +64,8 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
 
 endif
 
-comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7, dynamic library"
+comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_HAS_UDEV || \
-		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 || \
+		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
 		!BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS
Signature · 1 line
2.14.4
#1 lore raw

PATCH 1/1 network-manager: sync kernel headers comment with actual dependency

Thomas, All,

On 2018-07-01 00:19 +0200, Thomas Petazzoni spake thusly:

Quoted 9 lines

In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49 ("package/network-manager: add patches to build with kernel headers 3.2"), network-manager was changed to build with kernel headers as old as 3.2, instead of 3.7 before. The dependency was changed accordingly, but the Config.in comment was not.

This commit fixes this inconsistency.

Signed-off-by Thomas Petazzoni <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 package/network-manager/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/network-manager/Config.in +2 -2
index 9602cc4a1a..ca508185f0 100644
@@ -64,8 +64,8 @@ config BR2_PACKAGE_NETWORK_MANAGER_OVS
 
 endif
 
-comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.7, dynamic library"
+comment "NetworkManager needs udev /dev management and a glibc toolchain w/ headers >= 3.2, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_HAS_UDEV || \
-		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7 || \
+		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2 || \
 		!BR2_TOOLCHAIN_USES_GLIBC || BR2_STATIC_LIBS
Signature · 6 lines
2.14.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author Applied
#2 lore raw

PATCH 1/1 network-manager: sync kernel headers comment with actual dependency

In reply to Thomas Petazzoni

Hello,

Quoted 6 lines · Thomas Petazzoni

In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49 ("package/network-manager: add patches to build with kernel headers 3.2"), network-manager was changed to build with kernel headers as old as 3.2, instead of 3.7 before. The dependency was changed accordingly, but the Config.in comment was not.

Quoted 6 lines

This commit fixes this inconsistency.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/network-manager/Config.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 network-manager: sync kernel headers comment with actual dependency

Hi Thomas,

Quoted 10 lines

Hello,

Quoted 7 lines · Thomas Petazzoni

In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49 ("package/network-manager: add patches to build with kernel headers 3.2"), network-manager was changed to build with kernel headers as old as 3.2, instead of 3.7 before. The dependency was changed accordingly, but the Config.in comment was not.

This commit fixes this inconsistency.

thanks for my old error.

Kind regards,
Petr

#4 lore raw

PATCH 1/1 network-manager: sync kernel headers comment with actual dependency

In reply to Thomas Petazzoni
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

In commit 52282828f06dc8aa3f721727f68a5096b9ed8b49 ("package/network-manager: add patches to build with kernel headers 3.2"), network-manager was changed to build with kernel headers as old as 3.2, instead of 3.7 before. The dependency was changed accordingly, but the Config.in comment was not.

This commit fixes this inconsistency.

Signed-off-by Thomas Petazzoni <[email protected]>

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard