Skip to contentSkip to conversation

vfs fixes

GIT PULL Al Viro 2 participants 4 messages Jul 1, 2018 VFS

lore
Share & tools
lore

Al Viro

author maintainer
#0 lore raw

Followup to procfs-seq_file series this window

The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40:

Linux 4.18-rc1 (2018-06-17 08:04:49 +0900)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git fixes

for you to fetch changes up to 877f919e192a09e77962a13d7165783027dee5fd:

proc: add proc_seq_release (2018-06-27 20:44:38 -0400)

----------------------------------------------------------------
Chunyu Hu (1):
proc: add proc_seq_release

 fs/proc/generic.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)
#1 lore raw
Quoted 2 lines · Al Viro

Followup to procfs-seq_file series this window

That was a singularly unhelpful "description" of what is going on.

As is the one-liner shortlog:

Quoted 2 lines

Chunyu Hu (1):
proc: add proc_seq_release

which also says *nothing* about what is actually going on here and what is fixed.

Please make your pull requests actually describe what the hell is going on, and why.

Linus

author maintainer
#2 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 2 lines · Al Viro

Followup to procfs-seq_file series this window

That was a singularly unhelpful "description" of what is going on.

As is the one-liner shortlog:

Quoted 8 lines
Quoted 2 lines

Chunyu Hu (1):
proc: add proc_seq_release

which also says *nothing* about what is actually going on here and what is fixed.

Please make your pull requests actually describe what the hell is going on, and why.

Point taken... Would something along the lines of "fixing a leak introduced in procfs-seq_file series" be OK, or do you prefer more details?

#3 lore raw
Quoted 4 lines · Al Viro

Point taken... Would something along the lines of "fixing a leak introduced in procfs-seq_file series" be OK, or do you prefer more details?

That would have been sufficient. As it was now, it looked to all intents and purposes like adding a new function. So I went and looked what was going on, and found the "oh, fix a leak" and wrote my own merge message.

But it's the kind of thing I would really want to just get in the pull request - an explanation of why I should pull.

Linus