busybox: Update udhcpc.script for stateful DHCPv6
PATCH v3 1/1 busybox: Update udhcpc.script for stateful DHCPv6
udhcpc6 will call the default script with the address set in the "ipv6" variable. Set "ip" to this address if present.
Also from Rob, if handling a DHCPv6 address wait a moment for the IPv6 route to be configured; this doesn't come from DHCPv6 but rather the IPv6 Router Advertisement (RA).
(wait for IPv6 route)
From: Robert Lippert <[email protected]>
---
v3: Point out 'stateful' DHCPv6 in commit, send to the correct list...
v2: Avoid bashisms
package/busybox/udhcpc.script | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
package/busybox/udhcpc.script +14 -0
@@ -8,6 +8,16 @@ RESOLV_CONF="/etc/resolv.conf" [ -e $RESOLV_CONF ] || touch $RESOLV_CONF [ -n "$broadcast" ] && BROADCAST="broadcast $broadcast" [ -n "$subnet" ] && NETMASK="netmask $subnet" +[ -n "$ipv6" ] && ip="$ipv6/128" + +wait_for_ipv6_default_route() { + attempts=10 + while [ $attempts != 0 ] && [ -z "$(ip -6 route list | grep default)" ] ; do + sleep 1 + attempts=$(($attempts-1)) + done + [ $attempts = 0 ] && echo "failed to get default ipv6 route" +} case "$1" in deconfig)
@@ -37,6 +47,10 @@ case "$1" in /usr/sbin/avahi-autoipd -k $interface fi /sbin/ifconfig $interface $ip $BROADCAST $NETMASK + if [ -n "$ipv6" ] ; then + echo "waiting for default ipv6 route set" + wait_for_ipv6_default_route + fi if [ -n "$router" ] ; then echo "deleting routers"
Signature · 1 line
2.18.0
PATCH v3 1/1 busybox: Update udhcpc.script for stateful DHCPv6
Quoted 6 lines · Samuel Mendoza-Jonas
udhcpc6 will call the default script with the address set in the "ipv6" variable. Set "ip" to this address if present.
Also from Rob, if handling a DHCPv6 address wait a moment for the IPv6 route to be configured; this doesn't come from DHCPv6 but rather the IPv6 Router Advertisement (RA).
Point being that you want to *delete* the route coming from the RA, and keep
only the DHCPv6 route, correct? That's not entirely clear from the commit message. Then, you would only need to do that if the DHCPv6 actually announces a router, no?
Quoted 6 lines
(wait for IPv6 route)
From: Robert Lippert <[email protected]>Signed-off-by Samuel Mendoza-Jonas <[email protected]>---
v3: Point out 'stateful' DHCPv6 in commit, send to the correct list...
I don't see 'stateful' in the commit message :-)
Quoted 27 lines
v2: Avoid bashisms
package/busybox/udhcpc.script | 14 ++++++++++++++ 1 file changed, 14 insertions(+)package/busybox/udhcpc.script +10
-0@@ -8,6 +8,16 @@ RESOLV_CONF="/etc/resolv.conf" [ -e $RESOLV_CONF ] || touch $RESOLV_CONF [ -n "$broadcast" ] && BROADCAST="broadcast $broadcast" [ -n "$subnet" ] && NETMASK="netmask $subnet" +[ -n "$ipv6" ] && ip="$ipv6/128" + +wait_for_ipv6_default_route() { + attempts=10 + while [ $attempts != 0 ] && [ -z "$(ip -6 route list | grep default)" ] ; do + sleep 1 + attempts=$(($attempts-1)) + done + [ $attempts = 0 ] && echo "failed to get default ipv6 route" +} case "$1" in deconfig)
package/busybox/udhcpc.script case "$1" in · line 50
Quoted 4 lines
package/busybox/udhcpc.script +1
-0@@ -37,6 +47,10 @@ case "$1" in /usr/sbin/avahi-autoipd -k $interface fi /sbin/ifconfig $interface $ip $BROADCAST $NETMASK + if [ -n "$ipv6" ] ; then
So I would move this bit...
package/busybox/udhcpc.script case "$1" in · line 55
Quoted 5 lines
package/busybox/udhcpc.script +3
-0+ echo "waiting for default ipv6 route set" + wait_for_ipv6_default_route + fi if [ -n "$router" ] ; then
... here, so it only happens if routers are present.
Regards,
Arnout
Quoted 2 lines
package/busybox/udhcpc.script +0
-0echo "deleting routers"
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v3 1/1 busybox: Update udhcpc.script for stateful DHCPv6
Quoted 5 lines · Arnout Vandecappelle
Quoted 3 lines · Samuel Mendoza-Jonas
udhcpc6 will call the default script with the address set in the "ipv6" variable. Set "ip" to this address if present.
Quoted 8 lines
Quoted 3 lines
Also from Rob, if handling a DHCPv6 address wait a moment for the IPv6 route to be configured; this doesn't come from DHCPv6 but rather the IPv6 Router Advertisement (RA).
Point being that you want to *delete* the route coming from the RA, and keep
only the DHCPv6 route, correct? That's not entirely clear from the commit message. Then, you would only need to do that if the DHCPv6 actually announces a router, no?
No the aim is to check if we've received a route from the RA, since DHCPv6 does not advertise any route. Rob can correct me if needed but the goal here is to have udhcpc6 behave as much like udhcpc as possible in that once it configures an address you would usually expect the network to also be routable. We can't determine that from the DHCPv6 response so we check to see if the RA has set one before setting the address.
Quoted 9 lines
Quoted 7 lines
(wait for IPv6 route)
From: Robert Lippert <[email protected]>Signed-off-by Samuel Mendoza-Jonas <[email protected]>---
v3: Point out 'stateful' DHCPv6 in commit, send to the correct list...I don't see 'stateful' in the commit message :-)
Message, title... :)
Quoted 50 lines
Quoted 28 lines
v2: Avoid bashisms
package/busybox/udhcpc.script | 14 ++++++++++++++ 1 file changed, 14 insertions(+)package/busybox/udhcpc.script +10
-0@@ -8,6 +8,16 @@ RESOLV_CONF="/etc/resolv.conf" [ -e $RESOLV_CONF ] || touch $RESOLV_CONF [ -n "$broadcast" ] && BROADCAST="broadcast $broadcast" [ -n "$subnet" ] && NETMASK="netmask $subnet" +[ -n "$ipv6" ] && ip="$ipv6/128" + +wait_for_ipv6_default_route() { + attempts=10 + while [ $attempts != 0 ] && [ -z "$(ip -6 route list | grep default)" ] ; do + sleep 1 + attempts=$(($attempts-1)) + done + [ $attempts = 0 ] && echo "failed to get default ipv6 route" +} case "$1" in deconfig)package/busybox/udhcpc.script case "$1" in · line 50
Quoted 4 lines
package/busybox/udhcpc.script +1
-0@@ -37,6 +47,10 @@ case "$1" in /usr/sbin/avahi-autoipd -k $interface fi /sbin/ifconfig $interface $ip $BROADCAST $NETMASK + if [ -n "$ipv6" ] ; thenSo I would move this bit...
package/busybox/udhcpc.script case "$1" in · line 55
Quoted 5 lines
package/busybox/udhcpc.script +3
-0+ echo "waiting for default ipv6 route set" + wait_for_ipv6_default_route + fi if [ -n "$router" ] ; then... here, so it only happens if routers are present.
Regards,
ArnoutQuoted 2 lines
package/busybox/udhcpc.script +0
-0echo "deleting routers"