USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
PATCH v2 1/1 USB: chipidea: Do not hang when CONFIG_USB_CHIPIDEA_ULPI is not selected
Quoted 13 lines · Fabio Estevam
Hi Shawn,
Quoted 2 lines · Shawn Guo
A second thought on this - shouldn't such dependency be solved by
Kconfigselect clause?I suspect we are not able to fix it via
Kconfigas we really don't know if a system uses ULPI interface or not viaKconfigperspective.If we always select the chipidea ULPI driver, then it will be dead code for boards that do not use ULPI.
Quoted 8 lines
Currently there are some defconfigs that explicitly select the chipidea ulpi driver:
arch/arm/configs/qcom_defconfig:CONFIG_USB_CHIPIDEA_ULPI=y arch/arm64/configs/defconfig:CONFIG_USB_CHIPIDEA_ULPI=y
I would be interested to get feedback whether it would be possible to fix it on a different way.
We can have the options in defconfig, but they can still be turned off for whatever reason and we get the hang. Really, missing a user selectable option in defconfig shouldn't result in a system hang.
Shawn
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html