Skip to contentSkip to conversation

ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

PATCH New Robert Nelson 3 participants 4 messages Jul 2, 2018 – Jul 3, 2018 Device tree bindings

lore
Share & tools
lore

Robert Nelson

author
#0 lore raw

PATCH 1/1 ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write Protect.

Signed-off-by Robert Nelson <[email protected]>
CC Faiz Abbas <[email protected]>
CC Tony Lindgren <[email protected]>
CC Jason Kridner <[email protected]>
CC Drew Fustini <[email protected]>
---
 arch/arm/boot/dts/am335x-bone-common.dtsi | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/am335x-bone-common.dtsi +0 -1
index f9e8667f5886..73b514dddf65 100644
@@ -168,7 +168,6 @@
 			AM33XX_IOPAD(0x8f0, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_dat3.mmc0_dat3 */
 			AM33XX_IOPAD(0x904, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_cmd.mmc0_cmd */
 			AM33XX_IOPAD(0x900, PIN_INPUT_PULLUP | MUX_MODE0)	/* mmc0_clk.mmc0_clk */
-			AM33XX_IOPAD(0x9a0, PIN_INPUT | MUX_MODE4)		/* mcasp0_aclkr.mmc0_sdwp */
 		>;
 	};
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

Quoted 4 lines · Robert Nelson

Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write Protect.

Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for it.

Regards,

Tony

#2 lore raw

PATCH 1/1 ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

Hi,

Quoted 9 lines · Tony Lindgren
Quoted 4 lines · Robert Nelson

Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write Protect.

Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for it.

The evm sk sdwp needs to be removed as well. I guess I'll post a separate patch as this is already applied.

Thanks,
Faiz

author
#3 lore raw

PATCH 1/1 ARM: dts: am335x-bone-common: Fix mmc0 Write Protect

Quoted 9 lines · Faiz Abbas

Hi,

Quoted 6 lines · Tony Lindgren
Quoted 4 lines · Robert Nelson

Mainline Commit b74c2b21e1551018af53ee6c1efc051dfce2d788 added the pinmux settings for mmc1, however this pin (0x9a0) is routed to P9_42 on the cape header. Thus any BeagleBone cape that utilizes P9_42 triggers mmc0's Write Protect.

Quoted 6 lines
Quoted 3 lines

Thanks applying into omap-for-v4.18/fixes. I'll also add a Fixes tag for it.

The evm sk sdwp needs to be removed as well. I guess I'll post a separate patch as this is already applied.

Yeah, i don't have an evm sk, while i found found one schematic that made it look okay, wasn't 100% sure on all the revisions..

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/