Skip to contentSkip to conversation

qt5charts: fix license

PATCH New Sébastien Szymanski 3 participants 5 messages Jul 2, 2018 – Jul 19, 2018

lore
Share & tools
lore

Sébastien Szymanski

author
#0 lore raw

PATCH 1/1 qt5charts: fix license

qt5charts-2.1.3 (build with Qt 5.6) doesn't contain any license files so remove LICENSE.GPL3 from QT5CHARTS_LICENSE_FILES when building Qt 5.6.

Fixes:
http://autobuild.buildroot.net/results/c95d34129902a0511b8d64c9d50f1ffa293b33fd
http://autobuild.buildroot.net/results/b9c14ce7c2fdaa412eb6416ae12a0376aaf05770
http://autobuild.buildroot.net/results/1bde69c515d9140ef0f9a5571475c2850c7b8dee

Signed-off-by S?bastien Szymanski <[email protected]>
---
 package/qt5/qt5charts/qt5charts.mk | 2 ++
 1 file changed, 2 insertions(+)
package/qt5/qt5charts/qt5charts.mk +2 -0
index 71d0e54027..9e2e6de881 100644
@@ -16,7 +16,9 @@ QT5CHARTS_DEPENDENCIES = qt5base
 QT5CHARTS_INSTALL_STAGING = YES
 
 QT5CHARTS_LICENSE = GPL-3.0
+ifeq ($(BR2_PACKAGE_QT5_VERSION_LATEST),y)
 QT5CHARTS_LICENSE_FILES = LICENSE.GPL3
+endif
 
 ifeq ($(BR2_PACKAGE_QT5DECLARATIVE),y)
 QT5CHARTS_DEPENDENCIES += qt5declarative
Signature · 1 line
2.16.4
Applied
#1 lore raw

PATCH 1/1 qt5charts: fix license

Hello,

Thanks for this fix!

Quoted 7 lines · S?bastien Szymanski

qt5charts-2.1.3 (build with Qt 5.6) doesn't contain any license files so remove LICENSE.GPL3 from QT5CHARTS_LICENSE_FILES when building Qt 5.6.

Fixes:
http://autobuild.buildroot.net/results/c95d34129902a0511b8d64c9d50f1ffa293b33fd
http://autobuild.buildroot.net/results/b9c14ce7c2fdaa412eb6416ae12a0376aaf05770
http://autobuild.buildroot.net/results/1bde69c515d9140ef0f9a5571475c2850c7b8dee

Please leave a blank line before the Signed-off-by.

Quoted 1 line
Signed-off-by S?bastien Szymanski <[email protected]>

I've applied to master, however...

package/qt5/qt5charts/qt5charts.mk QT5CHARTS_DEPENDENCIES = qt5base · line 18

Quoted 12 lines
---
 package/qt5/qt5charts/qt5charts.mk | 2 ++
 1 file changed, 2 insertions(+)
package/qt5/qt5charts/qt5charts.mk +0 -0
index 71d0e54027..9e2e6de881 100644
@@ -16,7 +16,9 @@ QT5CHARTS_DEPENDENCIES = qt5base
 QT5CHARTS_INSTALL_STAGING = YES
 
 QT5CHARTS_LICENSE = GPL-3.0

... are we sure the license is GPL-3.0 for both versions of qt5charts ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 qt5charts: fix license

Hello,

Quoted 30 lines · Thomas Petazzoni

Hello,

Thanks for this fix!

Quoted 7 lines · S?bastien Szymanski

qt5charts-2.1.3 (build with Qt 5.6) doesn't contain any license files so remove LICENSE.GPL3 from QT5CHARTS_LICENSE_FILES when building Qt 5.6.

Fixes:
http://autobuild.buildroot.net/results/c95d34129902a0511b8d64c9d50f1ffa293b33fd
http://autobuild.buildroot.net/results/b9c14ce7c2fdaa412eb6416ae12a0376aaf05770
http://autobuild.buildroot.net/results/1bde69c515d9140ef0f9a5571475c2850c7b8dee

Please leave a blank line before the Signed-off-by.

Quoted 1 line
Signed-off-by S?bastien Szymanski <[email protected]>

I've applied to master, however...

Quoted 11 lines
---
 package/qt5/qt5charts/qt5charts.mk | 2 ++
 1 file changed, 2 insertions(+)
package/qt5/qt5charts/qt5charts.mk +0 -0
index 71d0e54027..9e2e6de881 100644
@@ -16,7 +16,9 @@ QT5CHARTS_DEPENDENCIES = qt5base
 QT5CHARTS_INSTALL_STAGING = YES
Quoted 3 lines

package/qt5/qt5charts/qt5charts.mk QT5CHARTS_DEPENDENCIES = qt5base · line 18

Quoted 1 line
package/qt5/qt5charts/qt5charts.mk +0 -0
 QT5CHARTS_LICENSE = GPL-3.0

... are we sure the license is GPL-3.0 for both versions of qt5charts ?

I wondered the same thing.

According to the Qt blog [1], Qt Charts is available under GPLv3 (and commercial license) since Qt 5.6.0:

"As announced recently, the Qt Add-ons licensing will be changed so that the Qt Charts module becomes available under both GPLv3 and commercial license terms."

[1] http://blog.qt.io/blog/2016/01/18/qt-charts-2-1-0-release/

Regards,

Quoted 5 lines

Thanks!

Thomas

Signature · 4 lines
S?bastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
#3 lore raw

PATCH 1/1 qt5charts: fix license

Hello,

Quoted 4 lines · S?bastien Szymanski
Quoted 1 line

... are we sure the license is GPL-3.0 for both versions of qt5charts ?

I wondered the same thing.

Quoted 8 lines

According to the Qt blog [1], Qt Charts is available under GPLv3 (and commercial license) since Qt 5.6.0:

"As announced recently, the Qt Add-ons licensing will be changed so that the Qt Charts module becomes available under both GPLv3 and commercial license terms."

[1] http://blog.qt.io/blog/2016/01/18/qt-charts-2-1-0-release/

OK, thanks for the confirmation.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 qt5charts: fix license

In reply to Sébastien Szymanski
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"S?bastien" == S?bastien Szymanski <[email protected]> writes:

qt5charts-2.1.3 (build with Qt 5.6) doesn't contain any license files so remove LICENSE.GPL3 from QT5CHARTS_LICENSE_FILES when building Qt 5.6.

Fixes:
http://autobuild.buildroot.net/results/c95d34129902a0511b8d64c9d50f1ffa293b33fd
http://autobuild.buildroot.net/results/b9c14ce7c2fdaa412eb6416ae12a0376aaf05770
http://autobuild.buildroot.net/results/1bde69c515d9140ef0f9a5571475c2850c7b8dee

Signed-off-by S?bastien Szymanski <[email protected]>

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard