Skip to contentSkip to conversation

ARM: dts: sun8i: h3: Enable dwmac-sun8i on the Beelink X2

linux-sunxi codekipper at gmail.com 2 participants 5 messages Jun 30, 2018 – Jul 4, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Marcus Cooper <[email protected]>

The enabling of the emac was reverted when stability issues were discovered.

This reverts partially commit 6b0e06df5cad (Revert "ARM: dts:
sun8i: h3: Enable dwmac-sun8i on the Beelink X2")

---
 arch/arm/boot/dts/sun8i-h3-beelink-x2.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun8i-h3-beelink-x2.dts +7 -0
index cf1f970b0c6f..5d23667dc2d2 100644
@@ -123,6 +123,13 @@
 	status = "okay";
 };
 
+&emac {
+	phy-handle = <&int_mii_phy>;
+	phy-mode = "mii";
+	allwinner,leds-active-low;
+	status = "okay";
+};
+
 &hdmi {
 	status = "okay";
 };
Signature · 1 line
2.18.0
#1 lore raw

Hi,

Quoted 4 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

The enabling of the emac was reverted when stability issues were discovered.

What stability issues exactly? Have they been fixed? If so, by which commit?

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180703/4a705a6f/attachment.sig>
#2 lore raw
Quoted 10 lines · Maxime Ripard

Hi,

Quoted 4 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

The enabling of the emac was reverted when stability issues were discovered.

What stability issues exactly? Have they been fixed? If so, by which commit?

They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes (boards)) but this board was missed.
CK

Quoted 7 lines

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

#3 lore raw
Quoted 6 lines · Code Kipper
Quoted 5 lines · Maxime Ripard

Hi,

Quoted 2 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

The enabling of the emac was reverted when stability issues were discovered.

What stability issues exactly? Have they been fixed? If so, by which commit?

They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes (boards)) but this board was missed.

Please add that to the commit log, and what the issue was.

Maxime

Signature · 10 lines
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180704/98da5e68/attachment.sig>
#4 lore raw
Quoted 10 lines · Maxime Ripard
Quoted 9 lines · Code Kipper
Quoted 8 lines · Maxime Ripard

Hi,

Quoted 4 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

The enabling of the emac was reverted when stability issues were discovered.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

What stability issues exactly? Have they been fixed? If so, by which commit?

They were fixed by 4904337fe34f (ARM: dts: sunxi: Restore EMAC changes (boards)) but this board was missed.

Please add that to the commit log, and what the issue was.

(A)CK

Quoted 7 lines

Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com