iio:imu:adis: Mark expected switch fall-throughs
PATCH 1/1 iio:imu:adis: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/iio/imu/adis.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/iio/imu/adis.c +3 -0
@@ -81,9 +81,11 @@ int adis_write_reg(struct adis *adis, unsigned int reg, adis->tx[9 ] = (value >>24 ) &0xff ; adis->tx[6 ] =ADIS_WRITE_REG (reg +2 ); adis->tx[7 ] = (value >>16 ) &0xff ; +/* fall through */ case 2 : adis->tx[4 ] =ADIS_WRITE_REG (reg +1 ); adis->tx[5 ] = (value >>8 ) &0xff ; +/* fall through */ case 1 : adis->tx[2 ] =ADIS_WRITE_REG (reg); adis->tx[3 ] = value &0xff ;
@@ -167,6 +169,7 @@ int adis_read_reg(struct adis *adis, unsigned int reg, adis->tx[2 ] =ADIS_READ_REG (reg +2 ); adis->tx[3 ] =0 ;spi_message_add_tail (&xfers[1 ], &msg); +/* fall through */ case 2 : adis->tx[4 ] =ADIS_READ_REG (reg); adis->tx[5 ] =0 ;
Signature · 1 line
2.7.4
Quoted 4 lines · On Tue, 3 Jul 2018 14:35:50 -0500 "Gustavo A. R. Silva"…
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to hopefully ignore!
Thanks,
Jonathan
Quoted 28 lines
--- drivers/iio/imu/adis.c | 3 +++ 1 file changed, 3 insertions(+)drivers/iio/imu/adis.c +3
-0@@ -81,9 +81,11 @@ int adis_write_reg(struct adis *adis, unsigned int reg, adis->tx[9 ] = (value >>24 ) &0xff ; adis->tx[6 ] =ADIS_WRITE_REG (reg +2 ); adis->tx[7 ] = (value >>16 ) &0xff ; +/* fall through */ case 2 : adis->tx[4 ] =ADIS_WRITE_REG (reg +1 ); adis->tx[5 ] = (value >>8 ) &0xff ; +/* fall through */ case 1 : adis->tx[2 ] =ADIS_WRITE_REG (reg); adis->tx[3 ] = value &0xff ;@@ -167,6 +169,7 @@ int adis_read_reg(struct adis *adis, unsigned int reg, adis->tx[2 ] =ADIS_READ_REG (reg +2 ); adis->tx[3 ] =0 ;spi_message_add_tail (&xfers[1 ], &msg); +/* fall through */ case 2 : adis->tx[4 ] =ADIS_READ_REG (reg); adis->tx[5 ] =0 ;