Skip to contentSkip to conversation

kf5-modemmanager-qt: correct dependencies comment display conditions

PATCH New Baruch Siach 2 participants 3 messages Jul 3, 2018

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH 1/2 kf5-modemmanager-qt: correct dependencies comment display conditions

Display the dependencies comment only when modem-manager is enabled. Otherwise, a toolchain configuration change would not make the package selectable.

Cc Pierre Ducroquet <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/kf5/kf5-modemmanager-qt/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/kf5/kf5-modemmanager-qt/Config.in +1 -0
index c291b886f5cd..f08de5567220 100644
@@ -16,4 +16,5 @@ config BR2_PACKAGE_KF5_MODEMMANAGER_QT
 
 comment "kf5-modemmanager-qt needs toolchain w/ threads"
 	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_MODEM_MANAGER
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH 2/2 kf5-networkmanager-qt: correct dependencies comment display conditions

Display the dependencies comment only when network-manager is enabled. Otherwise, a toolchain configuration change would not make the package selectable.

Cc Pierre Ducroquet <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/kf5/kf5-networkmanager-qt/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/kf5/kf5-networkmanager-qt/Config.in +1 -0
index 277e08866a1b..6b309f08047a 100644
@@ -16,4 +16,5 @@ config BR2_PACKAGE_KF5_NETWORKMANAGER_QT
 
 comment "kf5-networkmanager-qt needs toolchain w/ threads"
 	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_NETWORK_MANAGER
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.18.0
#2 lore raw

PATCH 1/2 kf5-modemmanager-qt: correct dependencies comment display conditions

In reply to Baruch Siach

Hello,

Quoted 9 lines · Baruch Siach

Display the dependencies comment only when modem-manager is enabled. Otherwise, a toolchain configuration change would not make the package selectable.

Cc Pierre Ducroquet <[email protected]>
Signed-off-by Baruch Siach <[email protected]>
---
 package/kf5/kf5-modemmanager-qt/Config.in | 1 +
 1 file changed, 1 insertion(+)

Series applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com