Skip to contentSkip to conversation

mmc: sdhci-xenon: mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 2 participants 2 messages Jul 3, 2018 – Jul 5, 2018

Subsystems (3)
MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver Marvell xenon MMC/SD/SDIO host controller driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 mmc: sdhci-xenon: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 2 was used: -Wimplicit-fallthrough=2

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/mmc/host/sdhci-xenon-phy.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-xenon-phy.c +1 -0
index a35804b..c335052 100644
@@ -526,6 +526,7 @@ static bool xenon_emmc_phy_slow_mode(struct sdhci_host *host,
 			ret = true;
 			break;
 		}
+		/* else: fall through */
 	default:
 		reg &= ~XENON_TIMING_ADJUST_SLOW_MODE;
 		ret = false;
Signature · 1 line
2.7.4
Applied
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Warning level 2 was used: -Wimplicit-fallthrough=2

Signed-off-by Gustavo A. R. Silva <[email protected]>

Thanks, applied for next!

Kind regards
Uffe

Quoted 19 lines
---
 drivers/mmc/host/sdhci-xenon-phy.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mmc/host/sdhci-xenon-phy.c +1 -1
index a35804b..c335052 100644
@@ -526,6 +526,7 @@ static bool xenon_emmc_phy_slow_mode(struct sdhci_host *host,
                        ret = true;
                        break;
                }
+               /* else: fall through */
        default:
                reg &= ~XENON_TIMING_ADJUST_SLOW_MODE;
                ret = false;
--

2.7.4