Skip to contentSkip to conversation

dmaengine: fsl-edma: fix the error return code in mcf_edma_probe()

-next Angelo Dureghello 1 participant 1 message Jul 4, 2018

Subsystems (2)
lore
Share & tools
lore

Angelo Dureghello

author Reviewed-by
#0 lore raw

Thanks for the fix.

Quoted 24 lines · Wei Yongjun

The error return code PTR_ERR(pdata) is always 0 since pdata is NULL in this error handling case.

Fixes 5c1355ad87a2 ("dmaengine: fsl-edma: add ColdFire mcf5441x edma support")
---
 drivers/dma/mcf-edma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/mcf-edma.c +1 -2
index 31e5317..787b7b6 100644
@@ -175,7 +175,7 @@ static int mcf_edma_probe(struct platform_device *pdev)
 
 	pdata = dev_get_platdata(&pdev->dev);
 	if (!pdata)
-		return PTR_ERR(pdata);
+		return -EINVAL;
 
 	chans = pdata->dma_channels;
 	len = sizeof(*mcf_edma) + sizeof(*mcf_chan) * chans;
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html