tipc: mark expected switch fall-throughs
Subsystems (3)
PATCH 1/1 tipc: mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 2 was used: -Wimplicit-fallthrough=2
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- net/tipc/bearer.c | 1 + net/tipc/link.c | 1 + 2 files changed, 2 insertions(+)
net/tipc/bearer.c +1 -0
@@ -610,6 +610,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,case NETDEV_CHANGE :if (netif_carrier_ok (dev))break ; +/* else: fall through */ case NETDEV_UP :test_and_set_bit_lock (0 , &b->up);break ;
net/tipc/link.c +1 -0
@@ -1063,6 +1063,7 @@ static bool tipc_data_input(struct tipc_link *l, struct sk_buff *skb,skb_queue_tail (mc_inputq, skb);return true; } +/* else: fall through */ case CONN_MANAGER :skb_queue_tail (inputq, skb);return true;
Signature · 1 line
2.7.4
Quoted 6 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 2 was used: -Wimplicit-fallthrough=2
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Ying Xue <[email protected]>
Quoted 30 lines
--- net/tipc/bearer.c | 1 + net/tipc/link.c | 1 + 2 files changed, 2 insertions(+)net/tipc/bearer.c +1
-0@@ -610,6 +610,7 @@ static int tipc_l2_device_event(struct notifier_block *nb, unsigned long evt,case NETDEV_CHANGE :if (netif_carrier_ok (dev))break ; +/* else: fall through */ case NETDEV_UP :test_and_set_bit_lock (0 , &b->up);break ;net/tipc/link.c +1
-0@@ -1063,6 +1063,7 @@ static bool tipc_data_input(struct tipc_link *l, struct sk_buff *skb,skb_queue_tail (mc_inputq, skb);return true; } +/* else: fall through */ case CONN_MANAGER :skb_queue_tail (inputq, skb);return true;
From: "Gustavo A. R. Silva" <[email protected]>
Date: Wed, 4 Jul 2018 16:13:59 -0500
Quoted 6 lines
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Warning level 2 was used: -Wimplicit-fallthrough=2
Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied.