Skip to contentSkip to conversation

alsa-utils: bat needs fftw single precision

PATCH New Baruch Siach 2 participants 2 messages Jul 3, 2018 – Jul 4, 2018

lore
Share & tools
lore

Baruch Siach

author
#0 lore raw

PATCH v2 1/1 alsa-utils: bat needs fftw single precision

Otherwise the configure check for fftw fails, and alsabat does not link with libfftw. Instead of selecting fftw unconditionally, make fftw single precision an optional dependency. Add a help text comment about that.

Cc Bernd Kuhls <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

---
v2: Make fftw single precision an optional dependency (Thomas P)

---
 package/alsa-utils/Config.in     | 3 ++-
 package/alsa-utils/alsa-utils.mk | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
package/alsa-utils/Config.in +2 -1
index 1a48fc0315ef..df6cfdac34d3 100644
@@ -76,7 +76,8 @@ config BR2_PACKAGE_ALSA_UTILS_ASEQNET
 
 config BR2_PACKAGE_ALSA_UTILS_BAT
 	bool "bat"
-	select BR2_PACKAGE_FFTW
+	help
+	  Analysis support in alsabat requires fftw single precision
 
 config BR2_PACKAGE_ALSA_UTILS_IECSET
 	bool "iecset"
package/alsa-utils/alsa-utils.mk +2 -1
index 9b2e64b1d3e4..e9a45c675f94 100644
@@ -40,7 +40,8 @@ endif
 
 ifeq ($(BR2_PACKAGE_ALSA_UTILS_BAT),y)
 ALSA_UTILS_CONF_OPTS += --enable-bat
-ALSA_UTILS_DEPENDENCIES += fftw
+# Analysis support requires fftw single precision
+ALSA_UTILS_DEPENDENCIES += $(if $(BR2_PACKAGE_FFTW_PRECISION_SINGLE),fftw)
 else
 ALSA_UTILS_CONF_OPTS += --disable-bat
 endif
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/1 alsa-utils: bat needs fftw single precision

Hello,

Quoted 5 lines · Baruch Siach

Otherwise the configure check for fftw fails, and alsabat does not link with libfftw. Instead of selecting fftw unconditionally, make fftw single precision an optional dependency. Add a help text comment about that.

Quoted 8 lines
Cc Bernd Kuhls <[email protected]>
Signed-off-by Baruch Siach <[email protected]>

---
v2: Make fftw single precision an optional dependency (Thomas P)

---
 package/alsa-utils/Config.in     | 3 ++-
 package/alsa-utils/alsa-utils.mk | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

The commit title and commit log were no longer really suitable for what the patch does now. I've reworked them, extended the Config.in help text and applied.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com