USB: serial: kl5kusb105 clean ups
Subsystems (3)
Johan Hovold
maintainercover USB: serial: kl5kusb105 clean ups
As reported by Chris, the kl5kusb105 does not work with KLSI devices so remove the device-id entry which even had a typo in it.
In fact, the sole remaining Palmconnect device is also listed in the visor driver (PALM_M100_ID), but the protocol used there looks different from what the one kl5kusb105 uses so we can't simply remove the driver.
Let's just leave this for now...
Johan
Johan Hovold (2):
USB: serial: kl5kusb105: remove KLSI device id
USB: serial: clean up kl5kusb105 documentation
Documentation/usb/usb-serial.txt | 9 --------- drivers/usb/serial/kl5kusb105.c | 1 - drivers/usb/serial/kl5kusb105.h | 3 --- 3 files changed, 13 deletions(-)
Signature · 6 lines
2.18.0 -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Johan Hovold
maintainerPATCH 1/2 USB: serial: kl5kusb105: remove KLSI device id
This driver was apparently never tested with an actual KLSI device. In fact, even the device-id entry which was supposed to allow for this had a typo in it.
Tests now reveal that the predicted firmware differences with the PalmConnect adapters are real and that the driver does not support KLSI devices with PID 0x000c, so let's remove the broken entry.
--- drivers/usb/serial/kl5kusb105.c | 1 - drivers/usb/serial/kl5kusb105.h | 3 --- 2 files changed, 4 deletions(-)
drivers/usb/serial/kl5kusb105.c +0 -1
@@ -67,7 +67,6 @@ static int klsi_105_prepare_write_buffer(struct usb_serial_port *port,*/ static const struct usb_device_id id_table[] = { {USB_DEVICE (PALMCONNECT_VID ,PALMCONNECT_PID ) }, - {USB_DEVICE (KLSI_VID ,KLSI_KL5KUSB105D_PID ) }, { }/* Terminating entry */ };
drivers/usb/serial/kl5kusb105.h +0 -3
@@ -7,9 +7,6 @@#define PALMCONNECT_VID 0x0830#define PALMCONNECT_PID 0x0080 -#define KLSI_VID 0x05e9 -#define KLSI_KL5KUSB105D_PID 0x00c0 -/* Vendor commands: */
Johan Hovold
maintainerPATCH 2/2 USB: serial: clean up kl5kusb105 documentation
In reply to Johan HovoldRemove references to long-gone kl5kusb105 module parameters in the usb-serial documentation.
--- Documentation/usb/usb-serial.txt | 9 --------- 1 file changed, 9 deletions(-)
Documentation/usb/usb-serial.txt +0 -9
@@ -418,15 +418,6 @@ Current status: why it is wise to cut down on the rate used is wise for large transfers until this is settled. -Options supported: - If this driver is compiled as a module you can pass the following - options to it: - debug - extra verbose debugging info - (default: 0; nonzero enables) - use_lowlatency - use low_latency flag to speed up tty layer - when reading from the device. - (default: 0; nonzero enables) - See http://www.uuhaus.de/linux/palmconnect.html for up-to-date information on this driver.