Skip to contentSkip to conversation

drm/amdgpu/gmc7: simplify logic in firmware message

PATCH In review Alex Deucher 4 participants 5 messages Jul 5, 2018 – Jul 6, 2018 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/gmc7: simplify logic in firmware message

Switching the firmware paths for CIK parts resulted in no need for this anymore.

Fixes "drm/amdgpu: switch firmware path for CIK parts"
---
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1 -4
index 2c2b93d4d63b..78339309a00c 100644
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
 	default: BUG();
 	}
 
-	if (adev->asic_type == CHIP_TOPAZ)
-		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
-	else
-		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+	snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
 
 	err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
 	if (err)
Signature · 6 lines
2.13.6

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by Jim Qu
#2 lore raw

Thanks
JimQu

________________________________________
发件人: amd-gfx <[email protected]> 代表 Alex Deucher <[email protected]> 发送时间: 2018年7月6日 4:46:33
收件人: [email protected]
抄送: Deucher, Alexander
主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message

Switching the firmware paths for CIK parts resulted in no need for this anymore.

Fixes "drm/amdgpu: switch firmware path for CIK parts"
---
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1 -4
index 2c2b93d4d63b..78339309a00c 100644
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
        default: BUG();
        }
 
-       if (adev->asic_type == CHIP_TOPAZ)
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
-       else
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
 
        err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
        if (err)

--
2.13.6

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

Reviewed-by
#4 lore raw

Am 06.07.2018 um 05:12 schrieb Qu, Jim:

Quoted 41 lines

Thanks
JimQu

________________________________________
发件人: amd-gfx <[email protected]> 代表 Alex Deucher <[email protected]> 发送时间: 2018年7月6日 4:46:33
收件人: [email protected]
抄送: Deucher, Alexander
主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message

Switching the firmware paths for CIK parts resulted in no need for this anymore.

Fixes "drm/amdgpu: switch firmware path for CIK parts"
---
  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1 -5
index 2c2b93d4d63b..78339309a00c 100644
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
         default: BUG();
         }
 
-       if (adev->asic_type == CHIP_TOPAZ)
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
-       else
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
 
         err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
         if (err)
--

2.13.6

Quoted 8 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#5 lore raw
In reply to a message not in the archive

Am 06.07.2018 um 05:12 schrieb Qu, Jim:

Quoted 41 lines

Thanks
JimQu

________________________________________
发件人: amd-gfx <[email protected]> 代表 Alex Deucher <[email protected]> 发送时间: 2018年7月6日 4:46:33
收件人: [email protected]
抄送: Deucher, Alexander
主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message

Switching the firmware paths for CIK parts resulted in no need for this anymore.

Fixes "drm/amdgpu: switch firmware path for CIK parts"
---
  drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1 -5
index 2c2b93d4d63b..78339309a00c 100644
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
         default: BUG();
         }
 
-       if (adev->asic_type == CHIP_TOPAZ)
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
-       else
-               snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+       snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
 
         err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
         if (err)
--

2.13.6

Quoted 8 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Reviewed-by
#6 lore raw
In reply to a message not in the archive
Quoted 6 lines · Alex Deucher

Switching the firmware paths for CIK parts resulted in no need for this anymore.

Fixes "drm/amdgpu: switch firmware path for CIK parts"
Quoted 27 lines
---
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +1 -4
index 2c2b93d4d63b..78339309a00c 100644
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
 	default: BUG();
 	}
 
-	if (adev->asic_type == CHIP_TOPAZ)
-		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
-	else
-		snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+	snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
 
 	err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
 	if (err)
Signature · 6 lines
2.13.6

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx