Skip to contentSkip to conversation

tracing: Optimize trace_buffer_iter() logic

PATCH New Steven Rostedt 1 participant 1 message Jul 6, 2018 Tracing

lore
Share & tools
lore

Steven Rostedt

author maintainer
#0 lore raw

PATCH 3/6 tracing: Optimize trace_buffer_iter() logic

From: yuan linyu <[email protected]>

Simplify and optimize the logic in trace_buffer_iter() to use a conditional operation instead of an if conditional.

---
 kernel/trace/trace.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
kernel/trace/trace.h +1 -3
index 630c5a24b2b2..f8f86231ad90 100644
@@ -583,9 +583,7 @@ static __always_inline void trace_clear_recursion(int bit)
 static inline struct ring_buffer_iter *
 trace_buffer_iter(struct trace_iterator *iter, int cpu)
 {
-	if (iter->buffer_iter && iter->buffer_iter[cpu])
-		return iter->buffer_iter[cpu];
-	return NULL;
+	return iter->buffer_iter ? iter->buffer_iter[cpu] : NULL;
 }
 
 int tracer_init(struct tracer *t, struct trace_array *tr);
Signature · 1 line
2.17.1