mmc: add SDHCI OF Synopsys DWC MSHC dirver

PATCH Applied Jisheng Zhang 3 participants 7 messages Jul 6, 2018 – Jul 16, 2018

Subsystems (3)

Device tree bindings MMC, SD and SDIO Secure digital host controller interface (SDHCI) driver

lore

Share & tools

lore

Jisheng Zhang

author

2018-07-06 07:19 UTC #0 lore raw

v2 cover mmc: add SDHCI OF Synopsys DWC MSHC dirver

Add support for Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller which can support eMMC/SD/SDIO.

Since v1:
- move the dt bindings into a separate patch

Jisheng Zhang (2):
dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC
mmc: sdhci-of-dwcmshc: add SDHCI OF Synopsys DWC MSHC dirver

 .../bindings/mmc/sdhci-of-dwcmshc.txt         |  20 +++
 drivers/mmc/host/Kconfig                      |  11 ++
 drivers/mmc/host/Makefile                     |   1 +
 drivers/mmc/host/sdhci-of-dwcmshc.c           | 116 ++++++++++++++++++
 4 files changed, 148 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
 create mode 100644 drivers/mmc/host/sdhci-of-dwcmshc.c

Signature · 1 line

2.18.0

Jisheng Zhang

author

2018-07-06 07:20 UTC #1 lore raw

PATCH v2 1/2 dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC

Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller can support eMMC/SD/SDIO. Add the bindings.

Signed-off-by Jisheng Zhang <[email protected]>

---
 .../bindings/mmc/sdhci-of-dwcmshc.txt         | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt

Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +20 -0

new file mode 100644
index 000000000000..ee4253b33be2
@@ -0,0 +1,20 @@
+* Synopsys DesignWare Cores Mobile Storage Host Controller
+
+Required properties:
+- compatible: should be one of the following:
+    "snps,dwcmshc-sdhci"
+- reg: offset and length of the register set for the device.
+- interrupts: a single interrupt specifier.
+- clocks: Array of clocks required for SDHCI; requires at least one for
+    core clock.
+- clock-names: Array of names corresponding to clocks property; shall be
+    "core" for core clock and "bus" for optional bus clock.
+
+Example:
+	sdhci2: sdhci at aa0000 {
+		compatible = "snps,dwcmshc-sdhci";
+		reg = <0xaa0000 0x1000>;
+		interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&emmcclk>;
+		bus-width = <8>;
+	}

Signature · 1 line

2.18.0

Rob Herring

maintainer

2018-07-11 16:12 UTC #2 lore raw

Re: [PATCH v2 1/2] dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC

Quoted 15 lines · Jisheng Zhang

Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller can support eMMC/SD/SDIO. Add the bindings.
Signed-off-by Jisheng Zhang <[email protected]>
---
 .../bindings/mmc/sdhci-of-dwcmshc.txt         | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +0 -0
new file mode 100644
index 000000000000..ee4253b33be2

Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt line 5

Quoted 5 lines

Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +5 -0

@@ -0,0 +1,20 @@
+* Synopsys DesignWare Cores Mobile Storage Host Controller
+
+Required properties:
+- compatible: should be one of the following:
+    "snps,dwcmshc-sdhci"

Needs to note that there must also be an SoC specific compatible.

Quoted 23 lines

Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +15 -0

+- reg: offset and length of the register set for the device.
+- interrupts: a single interrupt specifier.
+- clocks: Array of clocks required for SDHCI; requires at least one for
+    core clock.
+- clock-names: Array of names corresponding to clocks property; shall be
+    "core" for core clock and "bus" for optional bus clock.
+
+Example:
+	sdhci2: sdhci at aa0000 {
+		compatible = "snps,dwcmshc-sdhci";
+		reg = <0xaa0000 0x1000>;
+		interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&emmcclk>;
+		bus-width = <8>;
+	}

Signature · 7 lines

2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Jisheng Zhang

author

2018-07-12 02:06 UTC #3 lore raw

Re: [PATCH v2 1/2] dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC

Hi Rob,

Quoted 10 lines · On Wed, 11 Jul 2018 10:12:06 -0600 Rob Herring wrote:

Quoted 9 lines · Jisheng Zhang
Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller can support eMMC/SD/SDIO. Add the bindings.
Signed-off-by Jisheng Zhang <[email protected]>
---
 .../bindings/mmc/sdhci-of-dwcmshc.txt         | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt

Quoted 13 lines

Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt line 5
Quoted 11 lines
Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +5 -0
new file mode 100644
index 000000000000..ee4253b33be2
@@ -0,0 +1,20 @@
+* Synopsys DesignWare Cores Mobile Storage Host Controller
+
+Required properties:
+- compatible: should be one of the following:
+    "snps,dwcmshc-sdhci"  
Needs to note that there must also be an SoC specific compatible.

Currently, there's no SoC specific code in this driver, so the binding could be extended to SoC compatible if necessary. What do you think?

Thanks,
Jisheng

Rob Herring

maintainer

2018-07-16 21:59 UTC #4 lore raw

Re: [PATCH v2 1/2] dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC

Quoted 28 lines · Jisheng Zhang

Hi Rob,
Quoted 10 lines · On Wed, 11 Jul 2018 10:12:06 -0600 Rob Herring wrote:
Quoted 9 lines · Jisheng Zhang
Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller can support eMMC/SD/SDIO. Add the bindings.
Signed-off-by Jisheng Zhang <[email protected]>
---
 .../bindings/mmc/sdhci-of-dwcmshc.txt         | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
Quoted 13 lines
Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt line 5
Quoted 11 lines
Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt new file +5 -0
new file mode 100644
index 000000000000..ee4253b33be2
@@ -0,0 +1,20 @@
+* Synopsys DesignWare Cores Mobile Storage Host Controller
+
+Required properties:
+- compatible: should be one of the following:
+    "snps,dwcmshc-sdhci"  
Needs to note that there must also be an SoC specific compatible.

Quoted 2 lines

Currently, there's no SoC specific code in this driver, so the binding could be extended to SoC compatible if necessary. What do you think?

Doesn't matter what's in the driver, it can use this compatible.

But experience has shown that a compatible for a licensed IP is never sufficient. There are versions of the blocks, configuration options, and integration differences.

I'm not asking you to add any SoC specific compatible now unless you are working on a particular SoC, but just state one is needed.

Rob

Jisheng Zhang

author

2018-07-06 07:23 UTC #5 lore raw

PATCH v2 2/2 mmc: sdhci-of-dwcmshc: add SDHCI OF Synopsys DWC MSHC driver

In reply to Jisheng Zhang

Add a driver for SDHCI OF Synopsys DesignWare Cores Mobile Storage

Signed-off-by Jisheng Zhang <[email protected]>

---
 drivers/mmc/host/Kconfig            |  11 +++
 drivers/mmc/host/Makefile           |   1 +
 drivers/mmc/host/sdhci-of-dwcmshc.c | 116 ++++++++++++++++++++++++++++
 3 files changed, 128 insertions(+)
 create mode 100644 drivers/mmc/host/sdhci-of-dwcmshc.c

drivers/mmc/host/Kconfig +11 -0

index 0581c199c996..694d0828215d 100644
@@ -176,6 +176,17 @@ config MMC_SDHCI_OF_HLWD
 
 	  If unsure, say N.
 
+config MMC_SDHCI_OF_DWCMSHC
+	tristate "SDHCI OF support for the Synopsys DWC MSHC"
+	depends on MMC_SDHCI_PLTFM
+	depends on OF
+	depends on COMMON_CLK
+	help
+	  This selects Synopsys DesignWare Cores Mobile Storage Controller
+	  support.
+	  If you have a controller with this interface, say Y or M here.
+	  If unsure, say N.
+
 config MMC_SDHCI_CADENCE
 	tristate "SDHCI support for the Cadence SD/SDIO/eMMC controller"
 	depends on MMC_SDHCI_PLTFM

drivers/mmc/host/Makefile +1 -0

index 85dc1322c3de..a18fbba1b97e 100644
@@ -82,6 +82,7 @@ obj-$(CONFIG_MMC_SDHCI_OF_ARASAN)	+= sdhci-of-arasan.o
 obj-$(CONFIG_MMC_SDHCI_OF_AT91)		+= sdhci-of-at91.o
 obj-$(CONFIG_MMC_SDHCI_OF_ESDHC)	+= sdhci-of-esdhc.o
 obj-$(CONFIG_MMC_SDHCI_OF_HLWD)		+= sdhci-of-hlwd.o
+obj-$(CONFIG_MMC_SDHCI_OF_DWCMSHC)	+= sdhci-of-dwcmshc.o
 obj-$(CONFIG_MMC_SDHCI_BCM_KONA)	+= sdhci-bcm-kona.o
 obj-$(CONFIG_MMC_SDHCI_IPROC)		+= sdhci-iproc.o
 obj-$(CONFIG_MMC_SDHCI_MSM)		+= sdhci-msm.o

drivers/mmc/host/sdhci-of-dwcmshc.c new file +116 -0

116 lines not on this page · raw message

Signature · 1 line

2.18.0

Ulf Hansson

Applied

2018-07-09 11:32 UTC #6 lore raw

In reply to Jisheng Zhang

Quoted 18 lines · Jisheng Zhang

Add support for Synopsys SDHCI compatible DesignWare Cores Mobile Storage Host Controller which can support eMMC/SD/SDIO.
Since v1:
- move the dt bindings into a separate patch
Jisheng Zhang (2):
dt: bindings: Add bindings for SDHCI Synopsys DWC MSHC
mmc: sdhci-of-dwcmshc: add SDHCI OF Synopsys DWC MSHC dirver
 .../bindings/mmc/sdhci-of-dwcmshc.txt         |  20 +++
 drivers/mmc/host/Kconfig                      |  11 ++
 drivers/mmc/host/Makefile                     |   1 +
 drivers/mmc/host/sdhci-of-dwcmshc.c           | 116 ++++++++++++++++++
 4 files changed, 148 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-of-dwcmshc.txt
 create mode 100644 drivers/mmc/host/sdhci-of-dwcmshc.c

Quoted 3 lines

--
2.18.0

Thanks, applied for next!

Kind regards
Uffe