runqueue: Remove trailing whitespace
PATCH 1/4 runqueue: Remove trailing whitespace
--- bitbake/lib/bb/runqueue.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/bb/runqueue.py +1 -1
@@ -1061,7 +1061,7 @@ class RunQueueData: # Create a whitelist usable by the stamp checks self.stampfnwhitelist = {} - for mc in self.taskData: + for mc in self.taskData: self.stampfnwhitelist[mc] = [] for entry in self.stampwhitelist.split(): if entry not in self.taskData[mc].build_targets:
Signature · 1 line
2.17.1
PATCH 2/4 siggen: Delete trailing whitespace
--- bitbake/lib/bb/siggen.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
bitbake/lib/bb/siggen.py +2 -2
@@ -347,7 +347,7 @@ class SignatureGeneratorBasicHash(SignatureGeneratorBasic): def stampcleanmask(self, stampbase, fn, taskname, extrainfo): return self.stampfile(stampbase, fn, taskname, extrainfo, clean=True) - + def invalidate_task(self, task, d, fn): bb.note("Tainting hash to force rebuild of task %s, %s" % (fn, task)) bb.build.write_taint(task, d, fn)
@@ -636,7 +636,7 @@ def compare_sigfiles(a, b, recursecb=None, color=False, collapsed=False): if collapsed: output.extend(recout) else: - # If a dependent hash changed, might as well print the line above and then defer to the changes in + # If a dependent hash changed, might as well print the line above and then defer to the changes in # that hash since in all likelyhood, they're the same changes this task also saw. output = [output[-1]] + recout
Signature · 1 line
2.17.1
PATCH 3/4 runqueue: Remove unused variable
In reply to Joshua Watt--- bitbake/lib/bb/runqueue.py | 2 -- 1 file changed, 2 deletions(-)
bitbake/lib/bb/runqueue.py +0 -2
@@ -1892,8 +1892,6 @@ class RunQueueExecuteTasks(RunQueueExecute): alldeps = 0 if alldeps == 1: self.setbuildable(revdep) - fn = fn_from_tid(revdep) - taskname = taskname_from_tid(revdep) logger.debug(1, "Marking task %s as buildable", revdep) def task_complete(self, task):
Signature · 1 line
2.17.1
PATCH 4/4 runqueue: Stop on first unsatisfied dependency
In reply to Joshua Watt--- bitbake/lib/bb/runqueue.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
bitbake/lib/bb/runqueue.py +4 -3
@@ -1886,11 +1886,12 @@ class RunQueueExecuteTasks(RunQueueExecute): continue if revdep in self.runq_buildable: continue - alldeps = 1 + alldeps = True for dep in self.rqdata.runtaskentries[revdep].depends: if dep not in self.runq_complete: - alldeps = 0 - if alldeps == 1: + alldeps = False + break + if alldeps: self.setbuildable(revdep) logger.debug(1, "Marking task %s as buildable", revdep)
Signature · 1 line
2.17.1
Re: [PATCH 4/4] runqueue: Stop on first unsatisfied dependency
Hi Joshua
Quoted 1 line · CEST Joshua Watt
runqueue: Stop on first unsatisfied dependency
Richard merged this already, but for future non-trivial patches could you please include a commit message that explains the change (particularly why the change is being made, rather than just restating what's been changed).
Thanks,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Re: [PATCH 4/4] runqueue: Stop on first unsatisfied dependency
Quoted 9 lines · Paul Eggleton
Hi Joshua
Quoted 1 line · CEST Joshua Watt
runqueue: Stop on first unsatisfied dependency
Richard merged this already, but for future non-trivial patches could you please include a commit message that explains the change (particularly why the change is being made, rather than just restating what's been changed).
Yes, sorry. I will try to be more diligent in the future.
Thanks,
Joshua Watt
Quoted 10 lines
Thanks,
Paul--
Paul Eggleton
Intel Open Source Technology Centre