selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress
Subsystems (3)
RFC PATCH v2 1/1 selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress
In the past we've warned when ADJ_OFFSET was in progress, usually caused by ntpd or some other time adjusting daemon running in non steady sate, which can cause the skew calculations to be incorrect
Thus, this patch sets a flag which we check if the clock was being adjusted when we fail so that we don't cause false negatives.
---
v2: Widened the checks to look for other clock adjustments that
could happen, as suggested by Miroslav
--- tools/testing/selftests/timers/raw_skew.c | 5 +++++ 1 file changed, 5 insertions(+)
tools/testing/selftests/timers/raw_skew.c +5 -0
@@ -134,6 +134,11 @@ int main(int argv, char **argc)printf (" %lld.%i(act)" , ppm/1000 ,abs ((int )(ppm%1000 )));if (llabs (eppm - ppm) >1000 ) { +if (tx1.offset || tx2.offset || + tx1.freq != tx2.freq || tx1.tick != tx2.tick) { +printf (" [SKIP]\n" ); +return ksft_exit_skip ("The clock was adjusted externally. Shutdown NTPd or other time sync daemons\n" ); + }printf (" [FAILED]\n" );return ksft_exit_fail (); }
Signature · 6 lines
2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Miroslav Lichvar
reviewerQuoted 6 lines · John Stultz
In the past we've warned when
ADJ_OFFSETwas in progress, usually caused by ntpd or some other time adjusting daemon running in non steady sate, which can cause the skew calculations to be incorrectThus, this patch sets a flag which we check if the clock was being adjusted when we fail so that we don't cause false negatives.
The commit message might need an update as the code no longer sets a flag. Other than that, it looks good to me.
Thanks,
Quoted 17 lines
tools/testing/selftests/timers/raw_skew.c +5
-0@@ -134,6 +134,11 @@ int main(int argv, char **argc)printf (" %lld.%i(act)" , ppm/1000 ,abs ((int )(ppm%1000 )));if (llabs (eppm - ppm) >1000 ) { +if (tx1.offset || tx2.offset || + tx1.freq != tx2.freq || tx1.tick != tx2.tick) { +printf (" [SKIP]\n" ); +return ksft_exit_skip ("The clock was adjusted externally. Shutdown NTPd or other time sync daemons\n" ); + }printf (" [FAILED]\n" );return ksft_exit_fail (); }Signature · 1 line
2.7.4
Signature · 5 lines
Miroslav Lichvar -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html