Skip to contentSkip to conversation

dmaengine: idma64: Support dmaengine_terminate_sync()

PATCH New Andy Shevchenko 1 participant 1 message Jul 10, 2018

Subsystems (2)
dmaengine Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 dmaengine: idma64: Support dmaengine_terminate_sync()

It appears that the driver misses the support of dmaengine_terminate_sync(). Since many of callers expects this behaviour implement the new device_synchronize() callback to allow proper synchronization when stopping a channel.

Fixes b36f09c3c441 ("dmaengine: Add transfer termination synchronization support")
Signed-off-by Andy Shevchenko <[email protected]>

---

Fixes tag is just an anchor for anyone who would like to see this change backported.

 drivers/dma/idma64.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/dma/idma64.c +8 -0
index e5c911200bdb..1fbf9cb9b742 100644
@@ -496,6 +496,13 @@ static int idma64_terminate_all(struct dma_chan *chan)
 	return 0;
 }
 
+static void idma64_synchronize(struct dma_chan *chan)
+{
+	struct idma64_chan *idma64c = to_idma64_chan(chan);
+
+	vchan_synchronize(&idma64c->vchan);
+}
+
 static int idma64_alloc_chan_resources(struct dma_chan *chan)
 {
 	struct idma64_chan *idma64c = to_idma64_chan(chan);

@@ -583,6 +590,7 @@ static int idma64_probe(struct idma64_chip *chip)
 	idma64->dma.device_pause = idma64_pause;
 	idma64->dma.device_resume = idma64_resume;
 	idma64->dma.device_terminate_all = idma64_terminate_all;
+	idma64->dma.device_synchronize = idma64_synchronize;
 
 	idma64->dma.src_addr_widths = IDMA64_BUSWIDTHS;
 	idma64->dma.dst_addr_widths = IDMA64_BUSWIDTHS;