Skip to contentSkip to conversation

arm: dts: zynq: Improvements to Zybo z7 board

PATCH New Luis Araneda 2 participants 5 messages Jul 12, 2018 – Jul 17, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm: dts: zynq: Improvements to Zybo z7 board

This patchset corrects and improves the device-tree of the Zybo Z7 board

The first patch correct the RAM size
( supersedes https://lkml.org/lkml/2018/6/26/965 )

The second patch introduce the use of GPIO constants to replace a literal

Finally, the third patch adds a gpio-leds node with one LED

Luis Araneda (3):
arm: dts: zynq: Fix memory size on the Zybo Z7 board
arm: dts: zynq: Use gpio constants for the Zybo Z7 board
arm: dts: zynq: Add LEDs to the Zybo Z7 board

 arch/arm/boot/dts/zynq-zybo-z7.dts | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/3 arm: dts: zynq: Fix memory size on the Zybo Z7 board

According to the reference manual, the board has two Micron MT41K256M16HA-125 DDR3L memory ICs, which have 512 MiB each

Tested on a ZYBO-Z7-20 board

---
 arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/zynq-zybo-z7.dts +1 -1
index 1e713dc98920..bc81ebee50fe 100644
@@ -13,7 +13,7 @@
 
 	memory at 0 {
 		device_type = "memory";
-		reg = <0x0 0x20000000>;
+		reg = <0x0 0x40000000>;
 	};
 
 	chosen {
Signature · 1 line
2.18.0
#2 lore raw

PATCH 2/3 arm: dts: zynq: Use gpio constants for the Zybo Z7 board

In reply to Luis Araneda

Include GPIO dt-bindings and use GPIO_ACTIVE_* constants to improve readability

---
 arch/arm/boot/dts/zynq-zybo-z7.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/zynq-zybo-z7.dts +2 -1
index bc81ebee50fe..b68a5e921464 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0+
 /dts-v1/;
 #include "zynq-7000.dtsi"
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Zynq ZYBO Z7 Development Board";
@@ -24,7 +25,7 @@
 	usb_phy0: phy0 {
 		#phy-cells = <0>;
 		compatible = "usb-nop-xceiv";
-		reset-gpios = <&gpio0 46 1>;
+		reset-gpios = <&gpio0 46 GPIO_ACTIVE_LOW>;
 	};
 };
 
Signature · 1 line
2.18.0
#3 lore raw

PATCH 3/3 arm: dts: zynq: Add LEDs to the Zybo Z7 board

In reply to Luis Araneda

Add an LED node, connected to the Processing System (PS)

---
 arch/arm/boot/dts/zynq-zybo-z7.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm/boot/dts/zynq-zybo-z7.dts +9 -0
index b68a5e921464..710076c9bc19 100644
@@ -22,6 +22,15 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	gpio-leds {
+		compatible = "gpio-leds";
+
+		ld4 {
+			label = "zynq-zybo-z7:green:ld4";
+			gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
+		};
+	};
+
 	usb_phy0: phy0 {
 		#phy-cells = <0>;
 		compatible = "usb-nop-xceiv";
Signature · 1 line
2.18.0
#4 lore raw

cover arm: dts: zynq: Improvements to Zybo z7 board

In reply to Luis Araneda
Quoted 12 lines · Luis Araneda

This patchset corrects and improves the device-tree of the Zybo Z7 board

The first patch correct the RAM size
( supersedes https://lkml.org/lkml/2018/6/26/965 )

The second patch introduce the use of GPIO constants to replace a literal

Finally, the third patch adds a gpio-leds node with one LED

Quoted 8 lines

Luis Araneda (3):
arm: dts: zynq: Fix memory size on the Zybo Z7 board
arm: dts: zynq: Use gpio constants for the Zybo Z7 board
arm: dts: zynq: Add LEDs to the Zybo Z7 board

 arch/arm/boot/dts/zynq-zybo-z7.dts | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

Applied all.

Thanks,
Michal