Skip to contentSkip to conversation

clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent

PATCH Applied Gregory CLEMENT 2 participants 2 messages Jul 13, 2018 – Jul 25, 2018

Subsystems (2)
lore
Share & tools
lore

Gregory CLEMENT

author maintainer
#0 lore raw

PATCH 1/1 clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent

The return value of the get_parent operation is a u8, whereas a -EINVAL was returned. This wrong value was return if the value was bigger that the number of parent but this case was already handled by the core.

So we can just remove this chunk of code to fix the issue.

Fixes 9818a7a4fd10 ("clk: mvebu: armada-37xx-periph: prepare cpu clk to

be used with DVFS")

---
 drivers/clk/mvebu/armada-37xx-periph.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/clk/mvebu/armada-37xx-periph.c +0 -3
index a51edaab0c5c..287e98a7cff4 100644
@@ -426,9 +426,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw)
 		val &= pm_cpu->mask_mux;
 	}
 
-	if (val >= num_parents)
-		return -EINVAL;
-
 	return val;
 }
 
Signature · 1 line
2.18.0
maintainer Applied
#1 lore raw

Quoting Gregory CLEMENT (2018-07-13 03:27:26)

Quoted 11 lines

The return value of the get_parent operation is a u8, whereas a -EINVAL was returned. This wrong value was return if the value was bigger that the number of parent but this case was already handled by the core.

So we can just remove this chunk of code to fix the issue.

Fixes 9818a7a4fd10 ("clk: mvebu: armada-37xx-periph: prepare cpu clk to

be used with DVFS")

---

Applied to clk-next

This is actually a good point I've never considered. We should go fix all the drivers that return a negative value to return a number that's greater than the number of clks that are the parents and then we can still get 'errors' from this clk_op.