ks7010_sdio:Fix checkpatch out of memory warning
PATCH 1/1 ks7010_sdio:Fix checkpatch out of memory warning
* Patch fixes checkpatch warning "Possible unnecessary 'out of memory' message"
--- drivers/staging/ks7010/ks7010_sdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/ks7010/ks7010_sdio.c +1 -3
@@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func) card =sdio_get_drvdata (func); pp =kzalloc (hif_align_size (sizeof (*pp)),GFP_KERNEL ); -if (!pp) { -netdev_err (card->priv->net_dev,"allocate memory failed..\n" ); +if (!pp)return -ENOMEM ; - } size =sizeof (*pp) -sizeof (pp->header.size); pp->header.size =cpu_to_le16 ((uint16_t )size);
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 4 lines · RAGHU Halharvi
* Patch fixes checkpatch warning "Possible unnecessary 'out of memory' message"
Signed-off-by RAGHU Halharvi <[email protected]>
Next time please put "staging:" in the subject line, as a prefix, like all other patches for this driver have.
thanks,
greg k-h
Greg KH
maintainerRe: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
In reply to RAGHU HalharviQuoted 13 lines · RAGHU Halharvi
* Patch fixes checkpatch warning "Possible unnecessary 'out of memory' message"
Signed-off-by RAGHU Halharvi <[email protected]>--- drivers/staging/ks7010/ks7010_sdio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/staging/ks7010/ks7010_sdio.c +0
-0
drivers/staging/ks7010/ks7010_sdio.c static int send_stop_request(struct sdio_func *func) · line 963
Quoted 8 lines
drivers/staging/ks7010/ks7010_sdio.c +1
-3@@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func) card =sdio_get_drvdata (func); pp =kzalloc (hif_align_size (sizeof (*pp)),GFP_KERNEL ); -if (!pp) { -netdev_err (card->priv->net_dev,"allocate memory failed..\n" ); +if (!pp)return -ENOMEM ; - }
This change has already been done in my tree, please always work against linux-next at the least, and ideally staging.git, so that you do not duplicate work others have already done.
thanks,
greg k-h