Skip to contentSkip to conversation

dm: Complete CONFIG_BLK migration

PATCH New Simon Glass 7 participants 18 messages Jun 23, 2018 – Nov 22, 2018 Block layer

lore
Share & tools
lore
#0 lore raw

cover dm: Complete CONFIG_BLK migration

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

+../board/freescale/common/sdhc_boot.c: In function 'mmc_get_env_addr':
+../board/freescale/common/sdhc_boot.c:31:9: error: 'struct mmc' has no member named 'block_dev'
+ n = mmc->block_dev.block_read(&mmc->block_dev, 0, 1, tmp_buf);
+ ^
+../board/freescale/common/sdhc_boot.c:31:36: error: 'struct mmc' has no member named 'block_dev'
+ ^
+make[2]: *** [board/freescale/common/sdhc_boot.o] Error 1
+make[1]: *** [board/freescale/common] Error 2
+../common/usb_storage.c: In function 'usb_stor_probe_device':
+../common/usb_storage.c:207:30: error: 'struct usb_device' has no member named 'dev'
+ ^
+../common/usb_storage.c:217:32: error: 'struct usb_device' has no member named 'dev'
+ ^
+../board/gdsys/p1022/sdhc_boot.c: In function 'mmc_get_env_addr':
+../board/gdsys/p1022/sdhc_boot.c:46:9: error: 'struct mmc' has no member named 'block_dev' +../board/gdsys/p1022/sdhc_boot.c:46:36: error: 'struct mmc' has no member named 'block_dev'
+make[2]: *** [board/gdsys/p1022/sdhc_boot.o] Error 1
+make[1]: *** [board/gdsys/p1022] Error 2
+In file included from ../include/common.h:47:0,
+ from ../drivers/mmc/arm_pl180_mmci.c:14:
+../drivers/mmc/arm_pl180_mmci.c: In function ?arm_pl180_mmci_init?:
+../drivers/mmc/arm_pl180_mmci.c:398:14: error: ?struct mmc? has no member named ?block_dev?
+ (*mmc)->block_dev.devnum);
+ ^
+../include/log.h:134:26: note: in definition of macro ?debug_cond?
+ printf(pr_fmt(fmt), ##args); \
+ ^~~~
+../drivers/mmc/arm_pl180_mmci.c:397:2: note: in expansion of macro ?debug?
+ debug("registered mmc interface number is:%d\n",
+ ^~~~~
+make[3]: *** [drivers/mmc/arm_pl180_mmci.o] Error 1
+drivers/built-in.o: In function `blk_list_part':
+build/../drivers/block/blk-uclass.c:205: undefined reference to `part_print'
+drivers/built-in.o: In function `blk_print_part_devnum':
+build/../drivers/block/blk-uclass.c:224: undefined reference to `part_print'
+drivers/built-in.o: In function `blk_list_devices':
+build/../drivers/block/blk-uclass.c:244: undefined reference to `dev_print'
+drivers/built-in.o: In function `blk_print_device_num':
+build/../drivers/block/blk-uclass.c:257: undefined reference to `dev_print'
+drivers/built-in.o: In function `blk_show_device':
+build/../drivers/block/blk-uclass.c:275: undefined reference to `dev_print'
+drivers/built-in.o: In function `blk_prepare_device':
+build/../drivers/block/blk-uclass.c:455: undefined reference to `part_init'
+drivers/built-in.o: In function `pic32_sdhci_probe':
+../drivers/mmc/pic32_sdhci.c:(.text.pic32_sdhci_probe+0xd8): undefined reference to `add_sdhci' +../drivers/ata/dwc_ahsata.c: In function ?ahci_init_one?:
+../drivers/ata/dwc_ahsata.c:875:21: error: ?struct blk_desc? has no member named ?priv?
+ sata_dev_desc[pdev].priv = uc_priv;
+ ^
+../drivers/ata/dwc_ahsata.c: In function ?init_sata?:
+../drivers/ata/dwc_ahsata.c:898:30: error: ?struct blk_desc? has no member named ?priv?
+ uc_priv = sata_dev_desc[dev].priv;
+../drivers/ata/dwc_ahsata.c: In function ?reset_sata?:
+../drivers/ata/dwc_ahsata.c:913:30: error: ?struct blk_desc? has no member named ?priv? +../drivers/ata/dwc_ahsata.c: In function ?sata_port_status?:
+../drivers/ata/dwc_ahsata.c:934:24: error: ?struct blk_desc? has no member named ?priv?
+ if (sata_dev_desc[dev].priv == NULL)
+ ^
+../drivers/ata/dwc_ahsata.c:937:30: error: ?struct blk_desc? has no member named ?priv? +../drivers/ata/dwc_ahsata.c: In function ?sata_read?:
+../drivers/ata/dwc_ahsata.c:948:51: error: ?struct blk_desc? has no member named ?priv?
+ struct ahci_uc_priv *uc_priv = sata_dev_desc[dev].priv;
+ ^
+../drivers/ata/dwc_ahsata.c: In function ?sata_write?:
+../drivers/ata/dwc_ahsata.c:956:51: error: ?struct blk_desc? has no member named ?priv? +../drivers/ata/dwc_ahsata.c: In function ?scan_sata?:
+../drivers/ata/dwc_ahsata.c:964:51: error: ?struct blk_desc? has no member named ?priv?
+make[3]: *** [drivers/ata/dwc_ahsata.o] Error 1
w+../drivers/mmc/pic32_sdhci.c: In function 'pic32_sdhci_probe':
w+../drivers/mmc/pic32_sdhci.c:60:2: warning: implicit declaration of function 'add_sdhci' [-Wimplicit-function-declaration]

Simon Glass (2):
RFC: dm: Enable CONFIG_BLK
RFC: dm: Force CONFIG_BLK for all boards with DM

 drivers/block/Kconfig | 2 +-
 drivers/core/Kconfig  | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.18.0.rc2.346.g013aa6912e-goog
#1 lore raw

PATCH 1/2 RFC: dm: Enable CONFIG_BLK

As per the migration plan in MIGRATION.txt all boards should now be migrated to use CONFIG_BLK.

The following boards 145 fail to build with this change:

    A10-OLinuXino-Lime
    A20-Olimex-SOM-EVB
    A20-OLinuXino-Lime
    A20-OLinuXino-Lime2
    A20-OLinuXino_MICRO
    A33-OLinuXino
    Ainol_AW1
    arndale
    at91sam9260ek_dataflash_cs0
    at91sam9260ek_dataflash_cs1
    at91sam9260ek_nandflash
    at91sam9261ek_dataflash_cs0
    at91sam9261ek_dataflash_cs3
    at91sam9261ek_nandflash
    at91sam9g10ek_dataflash_cs0
    at91sam9g10ek_dataflash_cs3
    at91sam9g10ek_nandflash
    at91sam9g20ek_dataflash_cs0
    at91sam9g20ek_dataflash_cs1
    at91sam9g20ek_nandflash
    at91sam9xeek_dataflash_cs0
    at91sam9xeek_dataflash_cs1
    at91sam9xeek_nandflash
    ba10_tv_box
    Bananapi
    Bananapro
    Chuwi_V7_CW0825
    clearfog
    controlcenterdc
    corvus
    Cubieboard
    Cubieboard2
    Cubieboard4
    Cubietruck
    da850_am18xxevm
    da850evm
    db-88f6820-gp
    db-mv784mp-gp
    draco
    dserve_dsrv9703c
    etamin
    ethernut5
    ga10h_v1_1
    gt90h_v4
    gurnard
    Hyundai_A7HD
    i12-tvbox
    icnova-a20-swac
    inet1
    iNet_3F
    iNet_3W
    inet86dz
    inet97fv2
    inet9f_rev03
    iNet_D978_rev2
    Itead_Ibox_A20
    jesurun_q5
    k2e_evm
    k2e_hs_evm
    k2hk_evm
    k2hk_hs_evm
    k2l_evm
    Lamobo_R1
    Linksprite_pcDuino
    Linksprite_pcDuino3_Nano
    ls1021aiot_qspi
    ls1021aiot_sdcard
    ls1021aqds_ddr4_nor
    ls1021aqds_ddr4_nor_lpuart
    ls1021aqds_nand
    ls1021aqds_nor
    ls1021aqds_nor_lpuart
    ls1021aqds_nor_SECURE_BOOT
    ls1021aqds_qspi
    ls1021aqds_sdcard_ifc
    ls1021aqds_sdcard_qspi
    ls1021atwr_nor
    ls1021atwr_nor_lpuart
    ls1021atwr_nor_SECURE_BOOT
    ls1021atwr_qspi
    ls1021atwr_sdcard_ifc
    ls1021atwr_sdcard_ifc_SECURE_BOOT
    ls1021atwr_sdcard_qspi
    lschlv2
    lsxhl
    ma5d4evk
    Marsboard_A10
    Mele_A1000
    Mele_M3
    Mele_M5
    Merrii_A80_Optimus
    Mini-X
    mk802
    mk802ii
    MK808C
    MSI_Primo73
    nanopi_neo
    nanopi_neo_air
    odroid-xu3
    omap3_beagle
    omap3_evm
    omapl138_lcdk
    Orangepi
    orangepi_2
    orangepi_lite
    Orangepi_mini
    orangepi_one
    orangepi_pc
    orangepi_pc_plus
    orangepi_plus
    orangepi_plus2e
    orangepi_zero
    parrot_r16
    peach-pi
    peach-pit
    pm9261
    pm9263
    polaroid_mid2407pxe03
    polaroid_mid2809pxe04
    pov_protab2_ips9
    pxm2
    q8_a23_tablet_800x480
    q8_a33_tablet_1024x600
    q8_a33_tablet_800x480
    rastaban
    rut
    Sinlinx_SinA33
    smdk5250
    smdk5420
    smdkv310
    snow
    socfpga_is1
    spring
    sun8i_a23_evb
    Sunchip_CX-A99
    sunxi_Gemei_G9
    taurus
    theadorable_debug
    thuban
    ti816x_evm
    vinco
    Wexler_TAB7200
    Wits_Pro_A20_DKT
    Yones_Toptech_BD1078

I propose to create a patch to remove these if they are not converted by the time of the next release. I am copying all maintainers to make sure that no one missed the earlier messages.

The problems relate to MMC, SATA and USB.

A further 28 boards explicitly disabled CONFIG_BLK and will be the subject of a later patch.

---

 drivers/block/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/Kconfig +1 -1
index f9502b36ba..9189cb4249 100644
@@ -1,7 +1,7 @@
 config BLK
 	bool "Support block devices"
 	depends on DM
-	default y if DM_MMC
+	default y
 	help
 	  Enable support for block devices, such as SCSI, MMC and USB
 	  flash sticks. These provide a block-level interface which permits
Signature · 1 line
2.18.0.rc2.346.g013aa6912e-goog
#2 lore raw

PATCH 2/2 RFC: dm: Force CONFIG_BLK for all boards with DM

In reply to Simon Glass

This forces CONFIG_BLK to be used for all boards. At present it causes significant fallout.

---

 drivers/core/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/core/Kconfig +1 -0
index e8ba20ca82..daaafb187d 100644
@@ -2,6 +2,7 @@ menu "Generic Driver Options"
 
 config DM
 	bool "Enable Driver Model"
+	select BLK
 	help
 	  This config option enables Driver Model. This brings in the core
 	  support, including scanning of platform data on start-up. If
Signature · 1 line
2.18.0.rc2.346.g013aa6912e-goog
#3 lore raw

cover dm: Complete CONFIG_BLK migration

In reply to Simon Glass
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180627/3a8e3637/attachment.sig>
#4 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

I would rather temporarily remove USB support on my board than lose it completely, but I am not the best person to go into the USB drivers. I might be able to give it a shot in time, but I am fairly booked right now.

adam

Quoted 7 lines

--
Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#5 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 86 lines · Adam Ford
Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum
Quoted 7 lines

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

Derald

Quoted 17 lines

I would rather temporarily remove USB support on my board than lose it completely, but I am not the best person to go into the USB drivers. I might be able to give it a shot in time, but I am fairly booked right now.

adam

Quoted 7 lines

--
Tom
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#6 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 90 lines · Derald D. Woods
Quoted 89 lines · Adam Ford
Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180629/8b0dae52/attachment.sig>
#7 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 98 lines · Tom Rini
Quoted 96 lines · Derald D. Woods
Quoted 93 lines · Adam Ford
Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

Quoted 4 lines
Quoted 1 line

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Does this mean the deadline can/will be extended?

adam

Quoted 3 lines

--
Tom

#8 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 100 lines · Adam Ford
Quoted 98 lines · Tom Rini
Quoted 96 lines · Derald D. Woods
Quoted 93 lines · Adam Ford
Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

adam

Quoted 5 lines

adam

Quoted 3 lines

--
Tom

#9 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 106 lines · Adam Ford
Quoted 105 lines · Adam Ford
Quoted 102 lines · Tom Rini
Quoted 90 lines · Derald D. Woods
Quoted 89 lines · Adam Ford
Quoted 66 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Quoted 7 lines
Quoted 1 line

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

I'd be strongly opposed to kicking out boards based on some ad-hoc deadline. The deadline should be extended if there aren't resources to complete the migration.

Signature · 2 lines
Best regards,
Marek Vasut
#10 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 138 lines · On Fri, 13 Jul 2018 16:53:53 +0200 Marek Vasut <[email protected]> wrote:
Quoted 129 lines · Adam Ford
Quoted 127 lines · Adam Ford
Quoted 123 lines · Tom Rini
Quoted 110 lines · Derald D. Woods
Quoted 109 lines · Adam Ford
Quoted 84 lines · Tom Rini
Quoted 73 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT

Quoted 8 lines

controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no
member named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target
'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Quoted 7 lines
Quoted 1 line

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

Quoted 4 lines

I'd be strongly opposed to kicking out boards based on some ad-hoc deadline. The deadline should be extended if there aren't resources to complete the migration.

I can give an example of Odroid XU3....

It looked on the beginning as it was missing some USB support, but it tuned out that the root cause is the lack of support for DM_MMC and DM_REGULATOR (which are necessary for CONFIG_BLK).

The simple switch to DM_MMC in the case of exynos brings this board unusable as the eMMC/SD card is not working anymore.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180713/276b6711/attachment.sig>

#11 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 147 lines · Lukasz Majewski
Quoted 138 lines · On Fri, 13 Jul 2018 16:53:53 +0200 Marek Vasut <[email protected]> wrote:
Quoted 129 lines · Adam Ford
Quoted 127 lines · Adam Ford
Quoted 123 lines · Tom Rini
Quoted 110 lines · Derald D. Woods
Quoted 109 lines · Adam Ford
Quoted 84 lines · Tom Rini
Quoted 73 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT

Quoted 8 lines

controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no
member named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target
'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Quoted 7 lines
Quoted 1 line

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

Quoted 4 lines

I'd be strongly opposed to kicking out boards based on some ad-hoc deadline. The deadline should be extended if there aren't resources to complete the migration.

Quoted 8 lines

I can give an example of Odroid XU3....

It looked on the beginning as it was missing some USB support, but it tuned out that the root cause is the lack of support for DM_MMC and DM_REGULATOR (which are necessary for CONFIG_BLK).

The simple switch to DM_MMC in the case of exynos brings this board unusable as the eMMC/SD card is not working anymore.

For the omap3_logic board, DM_MMC is already enabled, but I enabled DM_REGULATOR, however this wasn't sufficient.

I get errors in usb_storage.c

common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

From a stock omap3_logic_defconfig, if I enable CONFIG_BLK and disable CONFIG_USB_STORAGE and it builds and loads successfully. So I think seems like we might have some different issues going based on different platforms.

adam

Quoted 11 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

#12 lore raw

cover dm: Complete CONFIG_BLK migration

Quoted 174 lines · Adam Ford
Quoted 147 lines · Lukasz Majewski
Quoted 138 lines · On Fri, 13 Jul 2018 16:53:53 +0200 Marek Vasut <[email protected]> wrote:
Quoted 129 lines · Adam Ford
Quoted 127 lines · Adam Ford
Quoted 123 lines · Tom Rini
Quoted 110 lines · Derald D. Woods
Quoted 109 lines · Adam Ford
Quoted 84 lines · Tom Rini
Quoted 73 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT

Quoted 8 lines

controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no
member named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target
'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Quoted 7 lines
Quoted 1 line

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

Quoted 4 lines

I'd be strongly opposed to kicking out boards based on some ad-hoc deadline. The deadline should be extended if there aren't resources to complete the migration.

Quoted 8 lines

I can give an example of Odroid XU3....

It looked on the beginning as it was missing some USB support, but it tuned out that the root cause is the lack of support for DM_MMC and DM_REGULATOR (which are necessary for CONFIG_BLK).

The simple switch to DM_MMC in the case of exynos brings this board unusable as the eMMC/SD card is not working anymore.

For the omap3_logic board, DM_MMC is already enabled, but I enabled DM_REGULATOR, however this wasn't sufficient.

I get errors in usb_storage.c

common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no member
named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum
Quoted 6 lines

scripts/Makefile.build:278: recipe for target 'common/usb_storage.o' failed

From a stock omap3_logic_defconfig, if I enable CONFIG_BLK and disable CONFIG_USB_STORAGE and it builds and loads successfully. So I think seems like we might have some different issues going based on different platforms.

I investigated this a bit further. The Mass storage driver is assuming that when CONFIG_BLK that DM_USB is also present. Enabling DM_USB fixes the USB Storage build error, but then breaks USB. I looked through the USB drivers, and it appears as if the glue for OMAP2+ (excluding am33x) hasn't been updated for DM_USB, so I guess it's more the platform's driver.

adam

Quoted 14 lines

adam

Quoted 11 lines

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de

#13 lore raw

cover dm: Complete CONFIG_BLK migration

In reply to Lukasz Majewski
Quoted 146 lines · Lukasz Majewski
Quoted 138 lines · On Fri, 13 Jul 2018 16:53:53 +0200 Marek Vasut <[email protected]> wrote:
Quoted 129 lines · Adam Ford
Quoted 127 lines · Adam Ford
Quoted 123 lines · Tom Rini
Quoted 110 lines · Derald D. Woods
Quoted 109 lines · Adam Ford
Quoted 84 lines · Tom Rini
Quoted 73 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT

Quoted 8 lines

controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no
member named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target
'common/usb_storage.o' failed

Quoted 7 lines
Quoted 4 lines

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

Quoted 7 lines
Quoted 1 line

Does this mean the deadline can/will be extended?

gentile nudge. I haven't heard anything on what direction we should head. I don't personally have time right now to work on migrating the USB Storage driver to CONFIG_BLK, but if it means getting kicked out of U-Boot, I'll remove the feature from my board as a temporary solution.

Quoted 4 lines

I'd be strongly opposed to kicking out boards based on some ad-hoc deadline. The deadline should be extended if there aren't resources to complete the migration.

Quoted 8 lines

I can give an example of Odroid XU3....

It looked on the beginning as it was missing some USB support, but it tuned out that the root cause is the lack of support for DM_MMC and DM_REGULATOR (which are necessary for CONFIG_BLK).

The simple switch to DM_MMC in the case of exynos brings this board unusable as the eMMC/SD card is not working anymore.

dwmmc should be easy to fix, it works on socfpga with dm.

Signature · 2 lines
Best regards,
Marek Vasut
#14 lore raw

cover dm: Complete CONFIG_BLK migration

In reply to Tom Rini

Hi Tom,

Quoted 117 lines · Derald D. Woods
Quoted 116 lines · Adam Ford
Quoted 113 lines
Quoted 84 lines · Tom Rini
Quoted 73 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT

Quoted 8 lines

controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 3 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

I looked at the omap3_logic board, and if I turned on the CONFIG_BLK option, some items in USB break.

LD drivers/mtd/built-in.o
common/usb_storage.c: In function ‘usb_stor_probe_device’:
common/usb_storage.c:207:32: error: ‘struct usb_device’ has no member named ‘dev’; did you mean ‘devnum’?

  data = dev_get_platdata(udev->dev);
                                ^~~
                                devnum
common/usb_storage.c:217:34: error: ‘struct usb_device’ has no
member named ‘dev’; did you mean ‘devnum’?
   ret = blk_create_devicef(udev->dev, "usb_storage_blk", str,
                                  ^~~
                                  devnum

CC drivers/mtd/nand/nand.o
scripts/Makefile.build:278: recipe for target
'common/usb_storage.o' failed

If I turn off the USB stuff and some of the other items dependent on USB, the issues goes away. I wonder if this may be affecting other uses as well.

Quoted 5 lines
Quoted 1 line

This is what I see on omap3-evm also.

It looks like the USB mass storage gadget code needs converting, to unblock a number of platforms from being converted fully to BLK.

I do have Odroid-XU3, so I will look into this during the weekend.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180629/2daf125d/attachment.sig>

#15 lore raw

cover dm: Complete CONFIG_BLK migration

In reply to Tom Rini
Quoted 65 lines · Tom Rini
Quoted 55 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series is just a test to see what boards would have to be removed if we required CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper omap3_zoom1 tbs2910 Mele_A1000G_quad

am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3 am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0 Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500 warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2 A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som-imx7 am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020 Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2 Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2 Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76 kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT BSC9132QDS_SDCARD_DDRCLK100_SECURE

P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB-PB_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT

Quoted 8 lines

P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB-PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT controlcenterd_TRAILBLAZER

Quoted 4 lines

So, how are the maintainers CC'd on this feeling about the deadline? It was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

So. What is the right model for this to work? Some boards may build cleanly, but may not actually boot. One can make something build by trimming things out of the config and get the board off the 'reap' list. But that is not quite the point of all this. Right. A failed build may mean you have been adding things as you can. Now your stuck trying to keep up with a moving target.

Is there a bootable reference board for each architecture variant?

I will help with the conversion work. Some good references will speed up the process. For me, at least. Just being honest.

Derald

Quoted 4 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#16 lore raw

cover dm: Complete CONFIG_BLK migration

In reply to Tom Rini
Quoted 100 lines · Tom Rini
Quoted 90 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series
is just a test to see what boards would have to be removed if we required
CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the
next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow
CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the
relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad
am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3
am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc
am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0
Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500
warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it
wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl
stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2
A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite
apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som- imx7
am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020
Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2
Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero
pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt
gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2
Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf
mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot
UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry
xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76
kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic
pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot
am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi
am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT
P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB- PB_NAND_SECBOOT
BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT
T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT

Quoted 8 lines

BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB- PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT
controlcenterd_TRAILBLAZER

Quoted 4 lines

So, how are the maintainers CC'd on this feeling about the deadline? It
was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

My board was added around this time according to the email list it was added on June 12th, 11 days before this email went out. I have not changed anything that would affect this in the meantime, and there was zero followups until today. I feel a bit caught off guard by it all. is there a doc somewhere that outlines the needed changes?

Dennis

#17 lore raw

cover dm: Complete CONFIG_BLK migration

Hi Dennis,

Quoted 107 lines · Dennis Gilmore
Quoted 100 lines · Tom Rini
Quoted 90 lines · Simon Glass

The time has come to migrate all boards to use CONFIG_BLK. This series
is just a test to see what boards would have to be removed if we required
CONFIG_BLK, as we plan to after the next release.

This should help maintainers see what is impacted.

Hopefully maintainers will be able to convert their boards over in the
next month so we we can avoid having to remove any boards.

The goal is to have all boards use driver model. But so far, we do allow
CONFIG_DM to not be defined.

For 'Force BLK', here is the buildman output showing failed boards and the
relatively small number of command errors:

03: Force BLK

      mips:  +   pic32mzdask
       arm:  +   mixtile_loftq colibri_imx6_nospl sniper

omap3_zoom1 tbs2910 Mele_A1000G_quad
am335x_igep003x mx6ul_14x14_evk mk802_a10s am43xx_hs_evm devkit3250 pcm051_rev3
am57xx_hs_evm Empire_electronix_m712 Auxtek-T003 pcm058 zc5202 am335x_shc
am335x_shc_ict Hummingbird_A31 vining_2000 am335x_evm_usbspl ot1200_spl igep00x0
Mele_I7 Wobo_i5 r7-tv-dongle liteboard omap3_overo am335x_boneblack evb-ast2500
warp7 gwventana_gw5904 cairo A13-OLinuXinoM mccmon6_sd apalis_imx6_nospl_it
wandboard birdland_bav335a colibri_imx7 colibri_imx6 inet_q972 xpress_spl
stm32f429-evaluation udoo_neo igep0032 Mele_M9 A13-OLinuXino inet98v_rev2
A10s-OLinuXino-M riotboard snapper9260 am43xx_evm pfla02 mx6qsabrelite
apalis_imx6_nospl_com s5p_goni colibri_pxa270 snapper9g20 Yones_Toptech_BS1078_V2 am335x_shc_sdboot_prompt k2g_hs_evm cl-som- imx7
am335x_shc_sdboot vf610twr_nand stm32f469-discovery am335x_evm_nor mx53cx9020
Empire_electronix_d709 vf610twr cm_t43 pengwyn stm32f746-disco Sinovoip_BPI_M2
Sinovoip_BPI_M3 Sinlinx_SinA31s pico-imx7d am43xx_evm_rtconly LicheePi_Zero
pcm051_rev1 mccmon6_nor mx6sabreauto display5_factory am335x_shc_prompt
gwventana_nand Bananapi_M2_Ultra Auxtek-T004 tbs_a711 cm_t335 h8_homlet_v2
Colombus am43xx_evm_usbhost_boot chiliboard am335x_baltos colibri_vf
mx6ul_9x9_evk kp_imx6q_tpc bk4r1 udoo difrnce_dit4350 am335x_evm_norboot
UTOO_P66 iNet_86VS marsboard MSI_Primo81 apalis_imx6 bananapi_m2_berry
xilinx_zynqmp_r5 birdland_bav335b am43xx_evm_qspiboot CSQ_CS908 Ampe_A76
kp_imx53 am335x_evm_spiboot Cubietruck_plus k2g_evm mx6sabresd omap3_logic
pepper colorfly_e708_q1 pcm052 gwventana_emmc am335x_boneblack_vboot
am335x_shc_netboot xpress ot1200 cgtqmx6eval zc5601 devkit8000 dh_imx6 mx6cuboxi
am57xx_evm am335x_sl50 q8_a13_tablet sksimx6

microblaze:  +   microblaze-generic
   powerpc:  +   P1010RDB-PA_36BIT_NOR_SECBOOT

BSC9132QDS_SDCARD_DDRCLK100_SECURE P1010RDB-PB_SPIFLASH_SECBOOT T1024QDS_DDR4_SECURE_BOOT controlcenterd_36BIT_SDCARD BSC9132QDS_SDCARD_DDRCLK133_SECURE P1010RDB-PA_SPIFLASH_SECBOOT BSC9132QDS_NAND_DDRCLK133_SECURE P1010RDB-PA_36BIT_SPIFLASH_SECBOOT P2041RDB_SECURE_BOOT P5020DS_NAND_SECURE_BOOT
P1010RDB-PB_36BIT_NOR_SECBOOT BSC9132QDS_NOR_DDRCLK100_SECURE P3041DS_SECURE_BOOT T1042D4RDB_SECURE_BOOT T1042RDB_SECURE_BOOT T4240QDS_SECURE_BOOT P1010RDB-PB_36BIT_SPIFLASH_SECBOOT P1010RDB- PB_NAND_SECBOOT
BSC9132QDS_SPIFLASH_DDRCLK100_SECURE P3041DS_NAND_SECURE_BOOT T4160QDS_SECURE_BOOT T2080RDB_SECURE_BOOT B4860QDS_SECURE_BOOT P4080DS_SECURE_BOOT T2080QDS_SECURE_BOOT P5040DS_SECURE_BOOT P1010RDB-PB_36BIT_NAND_SECBOOT controlcenterd_36BIT_SDCARD_DEVELOP P1010RDB-PA_NAND_SECBOOT BSC9132QDS_SPIFLASH_DDRCLK133_SECURE P1010RDB-PA_NOR_SECBOOT controlcenterd_TRAILBLAZER_DEVELOP P5020DS_SECURE_BOOT
T1024QDS_SECURE_BOOT T1040QDS_SECURE_BOOT

Quoted 8 lines

BSC9132QDS_NOR_DDRCLK133_SECURE T1024RDB_SECURE_BOOT P5040DS_NAND_SECURE_BOOT P1010RDB- PA_36BIT_NAND_SECBOOT T1042RDB_PI_NAND_SECURE_BOOT T1040RDB_SECURE_BOOT T1040D4RDB_SECURE_BOOT BSC9132QDS_NAND_DDRCLK100_SECURE P1010RDB-PB_NOR_SECBOOT T1023RDB_SECURE_BOOT
controlcenterd_TRAILBLAZER

Quoted 4 lines

So, how are the maintainers CC'd on this feeling about the deadline? It
was supposed to be 2018.05, but it's looking like we would enforce it for 2018.09 at this point in time.

Quoted 5 lines

My board was added around this time according to the email list it was added on June 12th, 11 days before this email went out. I have not changed anything that would affect this in the meantime, and there was zero followups until today. I feel a bit caught off guard by it all. is there a doc somewhere that outlines the needed changes?

Yes please see doc/driver-model/MIGRATION.txt

Basically you should enable CONFIG_BLK (and CONFIG_SPL_BLK if possible) for your board. Is it helios4?

Regards,
Simon