staging: comedi: comedi_internal.h: Avoid '(' at the end of line
PATCH 1/1 staging: comedi: comedi_internal.h: Avoid '(' at the end of line
Bring function argument 'struct comedi_subdevice *s' to the previous line to avoid ending the line with open parenthesis. Issue found by checkpatch.
--- drivers/staging/comedi/comedi_internal.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/comedi/comedi_internal.h +1 -2
@@ -32,8 +32,7 @@ void comedi_buf_map_get(struct comedi_buf_map *bm);int comedi_buf_map_put (struct comedi_buf_map *bm);int comedi_buf_map_access (struct comedi_buf_map *bm,unsigned long offset,void *buf,int len,int write); -struct comedi_buf_map *comedi_buf_map_from_subdev_get ( -struct comedi_subdevice *s); +struct comedi_buf_map *comedi_buf_map_from_subdev_get (struct comedi_subdevice *s);unsigned int comedi_buf_write_n_available (struct comedi_subdevice *s);unsigned int comedi_buf_write_n_allocated (struct comedi_subdevice *s);void comedi_device_cancel_all (struct comedi_device *dev);
Signature · 1 line
2.17.1
Greg Kroah-Hartman
maintainerQuoted 3 lines · Nishad Kamdar
Bring function argument 'struct
comedi_subdevice*s' to the previous line to avoid ending the line with open parenthesis. Issue found by checkpatch.
But now the code has another checkpatch violation, too long of a line. You can go back and forth submitting the same change over and over for forever :)
Let's just leave this as-is, thanks.
greg k-h
Quoted 5 lines · Greg Kroah-Hartman
Quoted 3 lines · Nishad Kamdar
Bring function argument 'struct
comedi_subdevice*s' to the previous line to avoid ending the line with open parenthesis. Issue found by checkpatch.
Quoted 7 lines
But now the code has another checkpatch violation, too long of a line. You can go back and forth submitting the same change over and over for forever :)
Let's just leave this as-is, thanks.
greg k-h
Ok noted. Thanks for reviewing.
regards,
nishad kamdar