Skip to contentSkip to conversation

<wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware

PATCH New Christoph Engelbert 3 participants 4 messages Jul 16, 2018 – Jul 19, 2018

lore
Share & tools
lore

Christoph Engelbert

author
#0 lore raw

PATCH 1/1 <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware

With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll fallback to using crda, but the direct way is preferred.

This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with kernels of 4.15 or later.

Signed-off-by Christoph Engelbert <[email protected]>
---
 package/wireless-regdb/wireless-regdb.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/wireless-regdb/wireless-regdb.mk +4 -0
index e9283a00e2..829374edcf 100644
@@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS
 		$(TARGET_DIR)/usr/lib/crda/regulatory.bin
 	$(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \
 		$(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem
+	$(INSTALL) -m 644 -D -T $(@D)/regulatory.db \
+		$(TARGET_DIR)/lib/firmware/regulatory.db
+	$(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \
+		$(TARGET_DIR)/lib/firmware/regulatory.db.p7s
 endef
 
 $(eval $(generic-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware

Hello,

Quoted 11 lines · Christoph Engelbert

With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll fallback to using crda, but the direct way is preferred.

This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with kernels of 4.15 or later.

Signed-off-by Christoph Engelbert <[email protected]>
---
 package/wireless-regdb/wireless-regdb.mk | 4 ++++
 1 file changed, 4 insertions(+)

Thanks for your contribution, I've applied your patch. However, I would like to recommend a few improvements for your future contributions, if possible:

- No need to enclose the package name between < and > in the commit title, i.e just "package: description" is enough.

- When sending new iterations, please change the patch subject prefix to PATCH v2, PATCH v3, etc. You can do that with "git format-patch -v2" or git format-patch --subject-prefix="PATCH v2"

- Also when sending new iterations, adding a changelog below the "---" sign is very nice, because it allows the people reviewing your patch understand what has changed.

- Finally, the commit log description should be wrapped to 72 characters.

But again: I applied your patch after doing minor fixes in the commit title and commit log, so those recommendations are valid for your future contributions only :-)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
author
#2 lore raw

PATCH 1/1 <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware

Hey Thomas,

Thanks for applying the patch. I?ll take your recommendations into consideration next time. Guess that was probably not the last patch to send ;-) Especially since (at the moment) I?m fighting myself through the process to get a full blown nanopi neo air working from the buildroot process.

Thanks,
Chris

Quoted 51 lines · Thomas Petazzoni

Hello,

Quoted 11 lines · Christoph Engelbert

With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll fallback to using crda, but the direct way is preferred.

This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with kernels of 4.15 or later.

Signed-off-by Christoph Engelbert <[email protected]>

---
package/wireless-regdb/wireless-regdb.mk | 4 ++++

1 file changed, 4 insertions(+)

Thanks for your contribution, I've applied your patch. However, I would like to recommend a few improvements for your future contributions, if possible:

- No need to enclose the package name between < and > in the commit title, i.e just "package: description" is enough.

- When sending new iterations, please change the patch subject prefix to PATCH v2, PATCH v3, etc. You can do that with "git format-patch -v2" or git format-patch --subject-prefix="PATCH v2"

- Also when sending new iterations, adding a changelog below the "---" sign is very nice, because it allows the people reviewing your patch understand what has changed.

- Finally, the commit log description should be wrapped to 72 characters.

But again: I applied your patch after doing minor fixes in the commit title and commit log, so those recommendations are valid for your future contributions only :-)

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
#3 lore raw

PATCH 1/1 <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware

In reply to Christoph Engelbert
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Christoph" == Christoph Engelbert <[email protected]> writes:

With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll fallback to using crda, but the direct way is preferred.

This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with kernels of 4.15 or later.

Signed-off-by Christoph Engelbert <[email protected]>

Committed to 2018.02.x and 2018.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard