cutelyst: new package
PATCH 1/1 cutelyst: new package
A C++ Web Framework built on top of Qt, using
the simple approach of Catalyst (Perl) framework.
--- package/Config.in | 1 + package/cutelyst/Config.in | 8 ++++++++ package/cutelyst/cutelyst.hash | 2 ++ package/cutelyst/cutelyst.mk | 17 +++++++++++++++++ 4 files changed, 28 insertions(+) create mode 100644 package/cutelyst/Config.in create mode 100644 package/cutelyst/cutelyst.hash create mode 100644 package/cutelyst/cutelyst.mk
package/Config.in +1 -0
@@ -314,6 +314,7 @@ comment "Other GUIs" source "package/kf5/Config.in" if BR2_PACKAGE_QT || BR2_PACKAGE_QT5 comment "QT libraries and helper libraries" + source "package/cutelyst/Config.in" source "package/grantlee/Config.in" source "package/qextserialport/Config.in" source "package/qjson/Config.in"
package/cutelyst/Config.in new file +8 -0
@@ -0,0 +1,8 @@ +config BR2_PACKAGE_CUTELYST + bool "cutelyst" + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5 && BR2_PACKAGE_QT5BASE_SQL + select BR2_PACKAGE_QT5BASE_GUI + help + A C++ Web Framework built on top of Qt, using the simple approach of Catalyst (Perl) framework. + + https://cutelyst.org
package/cutelyst/cutelyst.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally calculated after checking pgp signature +sha256 781e5da74ff5a03df415c70e9af0290d6aff5731d9f1978bf1bd4052bfe9cf05 cutelyst-2.5.0.tar.gz
package/cutelyst/cutelyst.mk new file +17 -0
@@ -0,0 +1,17 @@ +################################################################################ +# +# cutelyst +# +################################################################################ + +CUTELYST_VERSION = 2.5.0 +CUTELYST_SOURCE = cutelyst-$(CUTELYST_VERSION).tar.gz +CUTELYST_SITE = https://github.com/cutelyst/cutelyst/archive/v$(CUTELYST_VERSION) +CUTELYST_INSTALL_STAGING = YES +CUTELYST_SUPPORTS_IN_SOURCE_BUILD = NO +CUTELYST_LICENSE = LGPL-2.1+ +CUTELYST_LICENSE_FILES = COPYING.LIB +CUTELYST_DEPENDENCIES = qt5base +CUTELYST_MAKE = $(MAKE1) + +$(eval $(cmake-package))
Signature · 1 line
2.17.1
PATCH 1/1 cutelyst: new package
Hello Daniel,
Quoted 4 lines · Daniel Nicoletti
A C++ Web Framework built on top of Qt, using
the simple approach of Catalyst (Perl) framework.Signed-off-by Daniel Nicoletti <[email protected]>
Thanks for this contribution, see a few comments below.
package/cutelyst/Config.in line 3
Quoted 9 lines
package/cutelyst/Config.in new file +3
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_CUTELYST + bool "cutelyst" + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5 && BR2_PACKAGE_QT5BASE_SQL
Why do you have a depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE ? This dependency is not used by anything in qt5base.
Also, depending on BR2_PACKAGE_QT5BASE_SQL is not necessary, as this option is always true (which makes me wonder why we still have it).
package/cutelyst/Config.in line 6
Quoted 3 lines
package/cutelyst/Config.in new file +3
-0+ select BR2_PACKAGE_QT5BASE_GUI + help + A C++ Web Framework built on top of Qt, using the simple approach of Catalyst (Perl) framework.
This line is too long. Please run your package through ./utils/check-package to fix coding style issues.
package/cutelyst/cutelyst.hash line 2
Quoted 8 lines
package/cutelyst/cutelyst.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated after checking pgp signature +sha256 781e5da74ff5a03df415c70e9af0290d6aff5731d9f1978bf1bd4052bfe9cf05 cutelyst-2.5.0.tar.gz
We like to have a hash for the license file as well.
package/cutelyst/cutelyst.hash
Quoted 9 lines
package/cutelyst/cutelyst.hash new file +9
-0+CUTELYST_VERSION = 2.5.0 +CUTELYST_SOURCE = cutelyst-$(CUTELYST_VERSION).tar.gz +CUTELYST_SITE = https://github.com/cutelyst/cutelyst/archive/v$(CUTELYST_VERSION) +CUTELYST_INSTALL_STAGING = YES +CUTELYST_SUPPORTS_IN_SOURCE_BUILD = NO +CUTELYST_LICENSE = LGPL-2.1+ +CUTELYST_LICENSE_FILES = COPYING.LIB +CUTELYST_DEPENDENCIES = qt5base +CUTELYST_MAKE = $(MAKE1)
It really doesn't build in parallel ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 cutelyst: new package
Em ter, 17 de jul de 2018 ?s 04:01, Thomas Petazzoni <[email protected]> escreveu:
Quoted 2 lines
Hello Daniel,
Hi!
Quoted 9 lines · Daniel Nicoletti
Quoted 4 lines
A C++ Web Framework built on top of Qt, using
the simple approach of Catalyst (Perl) framework.Signed-off-by Daniel Nicoletti <[email protected]>Thanks for this contribution, see a few comments below.
Quoted 12 lines
package/cutelyst/Config.in line 3
Quoted 9 lines
package/cutelyst/Config.in new file +3
-0@@ -0,0 +1,8 @@ +config BR2_PACKAGE_CUTELYST + bool "cutelyst" + depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5 && BR2_PACKAGE_QT5BASE_SQLWhy do you have a depends on
BR2_PACKAGE_QT5_JSCORE_AVAILABLE? This dependency is not used by anything in qt5base.
I based on the grantlee package, I actually thought this means QJson..
Quoted 3 lines
Also, depending on
BR2_PACKAGE_QT5BASE_SQLis not necessary, as this option is always true (which makes me wonder why we still have it).
Ok, will remove both deps
Quoted 7 lines
package/cutelyst/Config.in line 6
Quoted 4 lines
package/cutelyst/Config.in new file +3
-0+ select BR2_PACKAGE_QT5BASE_GUI + help + A C++ Web Framework built on top of Qt, using the simple approach of Catalyst (Perl) framework.This line is too long. Please run your package through ./utils/check-package to fix coding style issues.
sure
Quoted 11 lines
package/cutelyst/cutelyst.hash line 2
Quoted 9 lines
package/cutelyst/cutelyst.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally calculated after checking pgp signature +sha256 781e5da74ff5a03df415c70e9af0290d6aff5731d9f1978bf1bd4052bfe9cf05 cutelyst-2.5.0.tar.gzWe like to have a hash for the license file as well.
a hash of the license file included in the tarball?
Quoted 10 lines
package/cutelyst/cutelyst.hash
Quoted 10 lines
package/cutelyst/cutelyst.hash new file +9
-0+CUTELYST_VERSION = 2.5.0 +CUTELYST_SOURCE = cutelyst-$(CUTELYST_VERSION).tar.gz +CUTELYST_SITE = https://github.com/cutelyst/cutelyst/archive/v$(CUTELYST_VERSION) +CUTELYST_INSTALL_STAGING = YES +CUTELYST_SUPPORTS_IN_SOURCE_BUILD = NO +CUTELYST_LICENSE = LGPL-2.1+ +CUTELYST_LICENSE_FILES = COPYING.LIB +CUTELYST_DEPENDENCIES = qt5base +CUTELYST_MAKE = $(MAKE1)
Oops sorry, was trying to find a build issue yesterday and forgot to remove.
Quoted 10 lines
It really doesn't build in parallel ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering
https://bootlin.com
Signature · 3 lines
Daniel Nicoletti KDE Developer - http://dantti.wordpress.com
PATCH 1/1 cutelyst: new package
Hello,
Quoted 3 lines · Daniel Nicoletti
Quoted 2 lines
Why do you have a depends on
BR2_PACKAGE_QT5_JSCORE_AVAILABLE? This dependency is not used by anything in qt5base.I based on the grantlee package, I actually thought this means QJson..
Grantlee has the BR2_PACKAGE_QT5_JSCORE_AVAILABLE dependency because it selects the BR2_PACKAGE_QT5SCRIPT option.
Since you don't select BR2_PACKAGE_QT5SCRIPT, there is no reason to depend on BR2_PACKAGE_QT5_JSCORE_AVAILABLE.
Quoted 2 lines
Quoted 1 line
We like to have a hash for the license file as well.
a hash of the license file included in the tarball?
Yes. This allows us to detect when license files are modified, and therefore to check if the license terms have been changed.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com