drm/nouveau: Fix bogus indenting in nouveau_hwmon.c
Subsystems (3)
Lyude Paul
maintainerPATCH 1/1 drm/nouveau: Fix bogus indenting in nouveau_hwmon.c
--- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/nouveau/nouveau_hwmon.c +2 -2
@@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr,static int nouveau_read (struct device *dev,enum hwmon_sensor_types type,u32 attr, -int channel,long *val) +int channel,long *val) {switch (type) {case hwmon_chip:
@@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,static int nouveau_write (struct device *dev,enum hwmon_sensor_types type,u32 attr, -int channel,long val) +int channel,long val) {switch (type) {case hwmon_temp:
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
isn't there like 1 space missing for each change? Or maybe my client is messed up, but please align it with the first letter of the parameters not the "(".
With that fixed: Reviewed-by: Karol Herbst <[email protected]>
Quoted 30 lines · Lyude Paul
Signed-off-by Lyude Paul <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/nouveau/nouveau_hwmon.c +2
-3@@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr,static int nouveau_read (struct device *dev,enum hwmon_sensor_types type,u32 attr, -int channel,long *val) +int channel,long *val) {switch (type) {case hwmon_chip:@@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,static int nouveau_write (struct device *dev,enum hwmon_sensor_types type,u32 attr, -int channel,long val) +int channel,long val) {switch (type) {case hwmon_temp: --2.17.1
Quoted 4 lines
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau
_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau
Lyude Paul
maintainerI think that is an issue with your client? It seems to come up fine if I apply it locally and look at it with gvim
Quoted 46 lines · Karol Herbst
isn't there like 1 space missing for each change? Or maybe my client is messed up, but please align it with the first letter of the parameters not the "(".
With that fixed: Reviewed-by: Karol Herbst <[email protected]>
Quoted 39 lines · Lyude Paul
Signed-off-by Lyude Paul <[email protected]>--- drivers/gpu/drm/nouveau/nouveau_hwmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/nouveau/nouveau_hwmon.c +1
-1@@ -655,7 +655,7 @@ nouveau_read_string(struct device *dev, enum hwmon_sensor_types type, u32 attr, static int nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, - int channel, long *val) + int channel, long *val) {switch (type) { case hwmon_chip:drivers/gpu/drm/nouveau/nouveau_hwmon.c +1
-1@@ -677,7 +677,7 @@ nouveau_read(struct device *dev, enum hwmon_sensor_types type, u32 attr, static int nouveau_write(struct device *dev, enum hwmon_sensor_types type, u32 attr, - int channel, long val) + int channel, long val) {switch (type) { case hwmon_temp:--
2.17.1_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau
Signature · 2 lines
Cheers, Lyude Paul