Skip to contentSkip to conversation

nvmet: Don't use uuid_le type

PATCH New Andy Shevchenko 3 participants 3 messages Jul 17, 2018

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH v2 1/1 nvmet: Don't use uuid_le type

Don't use sizeof(uuid_le) where none of the parameters is type of uuid_le. Since both arguments are u8 [16], use size of destination there.

Moreover, uuid_le is a deprecated type, and nvmet is using uuid_t already.

Signed-off-by Andy Shevchenko <andriy.shevchenko at linux.intel.com>

---

- use sizeof(dest)

 drivers/nvme/target/admin-cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/admin-cmd.c +1 -1
index 38803576d5e1..51a35faa88e3 100644
@@ -308,7 +308,7 @@ static void nvmet_execute_identify_ns(struct nvmet_req *req)
 	 */
 	id->nmic = (1 << 0);
 
-	memcpy(&id->nguid, &ns->nguid, sizeof(uuid_le));
+	memcpy(&id->nguid, &ns->nguid, sizeof(id->nguid));
 
 	id->lbaf[0].ds = ns->blksize_shift;
Signature · 1 line
2.18.0
#1 lore raw

PATCH v2 1/1 nvmet: Don't use uuid_le type

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

Signature · 6 lines
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850