Skip to contentSkip to conversation

ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

PATCH In review Hans de Goede 3 participants 6 messages Jul 1, 2018 – Jul 19, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

---
 sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
sound/soc/intel/boards/bytcr_rt5640.c +10 -0
index 7456566c5648..718f022b3aa0 100644
@@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 		},
 		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
 	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · Hans de Goede

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

Did this get rolled up into some other series?

#2 lore raw

Hi,

Quoted 5 lines · Mark Brown
Quoted 2 lines · Hans de Goede

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

Did this get rolled up into some other series?

No this patch is still pending / waiting for you to merge it.

Regards,

Hans

maintainer
#3 lore raw
Quoted 8 lines · Hans de Goede
Quoted 5 lines · Mark Brown
Quoted 2 lines · Hans de Goede

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

Did this get rolled up into some other series?

No this patch is still pending / waiting for you to merge it.

I'm still waiting for Pierre to review it so...

Acked-by on v1 1/1
#4 lore raw
In reply to Hans de Goede
Quoted 4 lines · Hans de Goede

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

Sorry about the delay, I missed this patch.

Quoted 25 lines
---
  sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
  1 file changed, 10 insertions(+)
sound/soc/intel/boards/bytcr_rt5640.c +10 -0
index 7456566c5648..718f022b3aa0 100644
@@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
  		},
  		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
  	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
  	{
  		.matches = {
  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
maintainer
#5 lore raw

Applied "ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet" to the asoc tree

In reply to Hans de Goede

The patch

ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet 9" tablet

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 9ee6f8a8cbbd203fb0a844f937007a9525422697 Mon Sep 17 00:00:00 2001

From: Hans de Goede <[email protected]>
Date: Sun, 1 Jul 2018 11:30:23 +0200
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for the "Connect Tablet
9" tablet

Add a quirk for the "Connect Tablet 9" tablet, this tablet has a mono-speaker. Otherwise it works fine with the defaults.

---
 sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
sound/soc/intel/boards/bytcr_rt5640.c +10 -0
index 657910a08261..d32844f94d74 100644
@@ -486,6 +486,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 		},
 		.driver_data = (void *)(BYT_RT5640_DMIC1_MAP),
 	},
+	{	/* Connect Tablet 9 */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Connect"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Tablet 9"),
+		},
+		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+					BYT_RT5640_MONO_SPEAKER |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
+	},
 	{
 		.matches = {
 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
Signature · 1 line
2.18.0