Skip to contentSkip to conversation

clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

PATCH Applied Krzysztof Kozlowski 3 participants 4 messages Jul 18, 2018 – Jul 26, 2018

Subsystems (3)
Common clk Arm Samsung Exynos Samsung SoC clock drivers
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 clk: samsung: Remove unused mout_user_aclk400_mcuisp_p4x12 variable

Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:

drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
 1 file changed, 2 deletions(-)
drivers/clk/samsung/clk-exynos4412-isp.c +0 -2
index d5f1ccb36300..cfaa057035ad 100644
@@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
 	E4X12_GATE_ISP1,
 };
 
-PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
-
 static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
 	DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
 	DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
Signature · 1 line
2.14.1
#1 lore raw

Speaking of the ISP clocks driver, I wonder why this one was never merged?
https://patches.linaro.org/patch/115531/

- Tobias

Quoted 24 lines · Krzysztof Kozlowski

Remove unused 'mout_user_aclk400_mcuisp_p4x12' variable to fix GCC warning:

drivers/clk/samsung/clk-exynos4412-isp.c:40:27: warning:
'mout_user_aclk400_mcuisp_p4x12' defined but not used [-Wunused-const-variable=]

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 drivers/clk/samsung/clk-exynos4412-isp.c | 2 --
 1 file changed, 2 deletions(-)
drivers/clk/samsung/clk-exynos4412-isp.c +0 -2
index d5f1ccb36300..cfaa057035ad 100644
@@ -37,8 +37,6 @@ static const unsigned long exynos4x12_clk_isp_save[] __initconst = {
 	E4X12_GATE_ISP1,
 };
 
-PNAME(mout_user_aclk400_mcuisp_p4x12) = { "fin_pll", "div_aclk400_mcuisp", };
-
 static struct samsung_div_clock exynos4x12_isp_div_clks[] = {
 	DIV(CLK_ISP_DIV_ISP0, "div_isp0", "aclk200", E4X12_DIV_ISP0, 0, 3),
 	DIV(CLK_ISP_DIV_ISP1, "div_isp1", "aclk200", E4X12_DIV_ISP0, 4, 3),
author maintainer
#2 lore raw
Quoted 2 lines · Tobias Jakobi

Speaking of the ISP clocks driver, I wonder why this one was never merged?
https://patches.linaro.org/patch/115531/

Thanks for reminding this!

It seems that Sylwester is out of office so we'll have to wait for reply.

Best regards,
Krzysztof