Skip to contentSkip to conversation

dt-bindings: thermal: samsung: Add SPDX license identifier

PATCH In review Krzysztof Kozlowski 3 participants 6 messages Jul 18, 2018 – Jul 27, 2018

Subsystems (3)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: thermal: samsung: Add SPDX license identifier

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
include/dt-bindings/thermal/thermal_exynos.h +1 -11
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * thermal_exynos.h - Samsung EXYNOS TMU device tree definitions
  *
  *  Copyright (C) 2014 Samsung Electronics
  *  Lukasz Majewski <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
  */
 
 #ifndef _EXYNOS_THERMAL_TMU_DT_H
Signature · 1 line
2.14.1
#1 lore raw

Hi,

include/dt-bindings/thermal/thermal_exynos.h line 1

Quoted 13 lines · Krzysztof Kozlowski

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
include/dt-bindings/thermal/thermal_exynos.h +1 -0
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */

This code should be GPL-2.0 only, original license statement is most likely result of using wrong file as the source of copy-paste. So I would like to have the license fixed first before doing conversion to SPDX.

Quoted 9 lines
include/dt-bindings/thermal/thermal_exynos.h +0 -4
 /*
  * thermal_exynos.h - Samsung EXYNOS TMU device tree definitions
  *
  *  Copyright (C) 2014 Samsung Electronics
  *  Lukasz Majewski <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or

include/dt-bindings/thermal/thermal_exynos.h line 9

Quoted 10 lines
include/dt-bindings/thermal/thermal_exynos.h +0 -7
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
  */
 
 #ifndef _EXYNOS_THERMAL_TMU_DT_H

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

author maintainer
#2 lore raw
Quoted 11 lines · Bartlomiej Zolnierkiewicz

Hi,

Quoted 7 lines · Krzysztof Kozlowski

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
Quoted 11 lines

include/dt-bindings/thermal/thermal_exynos.h line 1

Quoted 6 lines
include/dt-bindings/thermal/thermal_exynos.h +1 -0
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */

This code should be GPL-2.0 only, original license statement is most likely result of using wrong file as the source of copy-paste. So I would like to have the license fixed first before doing conversion to SPDX.

If you think that's the case, then it makes sense and please go ahead. As fair as I remember this required signed-off from all contributors... so probably just Lukasz and Eduardo?

Best regards,
Krzysztof

#3 lore raw
Quoted 24 lines · Krzysztof Kozlowski
Quoted 11 lines · Bartlomiej Zolnierkiewicz

Hi,

Quoted 7 lines · Krzysztof Kozlowski

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
Quoted 11 lines

include/dt-bindings/thermal/thermal_exynos.h line 1

Quoted 6 lines
include/dt-bindings/thermal/thermal_exynos.h +1 -0
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */

This code should be GPL-2.0 only, original license statement is most likely result of using wrong file as the source of copy-paste. So I would like to have the license fixed first before doing conversion to SPDX.

Quoted 3 lines

If you think that's the case, then it makes sense and please go ahead. As fair as I remember this required signed-off from all contributors... so probably just Lukasz and Eduardo?

git blame shows just Lukasz so his Ack should be enough.

I'm also fine with doing it in one patch like i.e. in commit a80ea4cb944e ("pata_bk3710: clarify license version and use SPDX header"), if you are also fine with it could you please re-spin the patch (+Cc: Lukasz)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

author maintainer
#4 lore raw
Quoted 29 lines · Bartlomiej Zolnierkiewicz
Quoted 24 lines · Krzysztof Kozlowski
Quoted 11 lines · Bartlomiej Zolnierkiewicz

Hi,

Quoted 7 lines · Krzysztof Kozlowski

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
Quoted 11 lines

include/dt-bindings/thermal/thermal_exynos.h line 1

Quoted 6 lines
include/dt-bindings/thermal/thermal_exynos.h +1 -0
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */

This code should be GPL-2.0 only, original license statement is most likely result of using wrong file as the source of copy-paste. So I would like to have the license fixed first before doing conversion to SPDX.

Quoted 3 lines

If you think that's the case, then it makes sense and please go ahead. As fair as I remember this required signed-off from all contributors... so probably just Lukasz and Eduardo?

Quoted 5 lines

git blame shows just Lukasz so his Ack should be enough.

I'm also fine with doing it in one patch like i.e. in commit a80ea4cb944e ("pata_bk3710: clarify license version and use SPDX header"), if you are also fine with it could you please re-spin the patch (+Cc: Lukasz)?

I do not have interest in changing the license, I do not want to deal with possible legal issues so I'll skip it.

I am fine however with abandoning this patch if you or someone else sends license change + SPDX.

Best regards,
Krzysztof

#5 lore raw
Quoted 27 lines · Krzysztof Kozlowski
Quoted 25 lines · Bartlomiej Zolnierkiewicz
Quoted 24 lines · Krzysztof Kozlowski
Quoted 22 lines · Bartlomiej Zolnierkiewicz

Hi,

include/dt-bindings/thermal/thermal_exynos.h line 1

Quoted 13 lines · Krzysztof Kozlowski

Replace GPL license statement with SPDX license identifier (GPL-2.0+).

---
 include/dt-bindings/thermal/thermal_exynos.h | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
include/dt-bindings/thermal/thermal_exynos.h +1 -0
index 0646500bca69..642e4e7f4084 100644
@@ -1,19 +1,9 @@
+/* SPDX-License-Identifier: GPL-2.0+ */

This code should be GPL-2.0 only, original license statement is most likely result of using wrong file as the source of copy-paste. So I would like to have the license fixed first before doing conversion to SPDX.

Quoted 5 lines
Quoted 5 lines
Quoted 3 lines

If you think that's the case, then it makes sense and please go ahead. As fair as I remember this required signed-off from all contributors... so probably just Lukasz and Eduardo?

git blame shows just Lukasz so his Ack should be enough.

You probably want to have his ack yes.

Quoted 8 lines
Quoted 4 lines

I'm also fine with doing it in one patch like i.e. in commit a80ea4cb944e ("pata_bk3710: clarify license version and use SPDX header"), if you are also fine with it could you please re-spin the patch (+Cc: Lukasz)?

I do not have interest in changing the license, I do not want to deal with possible legal issues so I'll skip it.

:-)

Quoted 3 lines

I am fine however with abandoning this patch if you or someone else sends license change + SPDX.

If that is the case, I am skipping this patch. Ping me / RESEND in case you still want this. :-)

Quoted 2 lines

Best regards,
Krzysztof