drm/print: Fix DRM_DEBUG_DP macro
Subsystems (2)
PATCH 1/1 drm/print: Fix DRM_DEBUG_DP macro
This isn't supposed to take dev as an argument, I guess no one noticed!
Signed-off-by Lyude Paul <[email protected]>
--- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/drm/drm_print.h +1 -1
@@ -310,7 +310,7 @@ void drm_err(const char *format, ...);#define DRM_DEV_DEBUG_DP (dev, fmt, ...) \ drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) -#define DRM_DEBUG_DP (dev, fmt, ...) \ +#define DRM_DEBUG_DP (fmt, ...) \ drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)#define _DRM_DEV_DEFINE_DEBUG_RATELIMITED (dev, category, fmt, ...) \
Signature · 1 line
2.17.1
Quoted 1 line · Lyude Paul
This isn't supposed to take dev as an argument, I guess no one noticed!
Apparently no one using it... Why don't we just kill it?
Quoted 2 lines
Signed-off-by Lyude Paul <[email protected]>
anyways, if you prefer to keep or have plans to use:
Reviewed-by Rodrigo Vivi <[email protected]>
Quoted 24 lines
--- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/drm/drm_print.h +1
-1@@ -310,7 +310,7 @@ void drm_err(const char *format, ...);#define DRM_DEV_DEBUG_DP (dev, fmt, ...) \ drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) -#define DRM_DEBUG_DP (dev, fmt, ...) \ +#define DRM_DEBUG_DP (fmt, ...) \ drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)#define _DRM_DEV_DEFINE_DEBUG_RATELIMITED (dev, category, fmt, ...) \Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 4 lines · Rodrigo Vivi
Quoted 1 line · Lyude Paul
This isn't supposed to take dev as an argument, I guess no one noticed!
Apparently no one using it... Why don't we just kill it?
Yeah-I've got plans to hopefully use this at some point in the future
Quoted 37 lines
Quoted 3 lines
Signed-off-by Lyude Paul <[email protected]>anyways, if you prefer to keep or have plans to use:
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 28 lines
--- include/drm/drm_print.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/drm/drm_print.h +1
-1@@ -310,7 +310,7 @@ void drm_err(const char *format, ...);#define DRM_DEV_DEBUG_DP (dev, fmt, ...) \ drm_dev_dbg(dev, DRM_UT_DP, fmt, ## __VA_ARGS__) -#define DRM_DEBUG_DP (dev, fmt, ...) \ +#define DRM_DEBUG_DP (fmt, ...) \
drm_dbg(DRM_UT_DP, fmt, ## __VA_ARGS__)#define
_DRM_DEV_DEFINE_DEBUG_RATELIMITED(dev, category, fmt, ...)
\Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 2 lines
Cheers, Lyude Paul