omap3: beagle: re-enable EFI support after the following commit removed it by mistake:
PATCH 1/1 omap3: beagle: re-enable EFI support after the following commit removed it by mistake:
commit d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
ARM: omap3: beagle: Enable DM_SERIAL, update distro usage and NAND layout
--- configs/omap3_beagle_defconfig | 3 --- 1 file changed, 3 deletions(-)
configs/omap3_beagle_defconfig +0 -3
@@ -32,8 +32,6 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0" CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:512k(spl),1920k(u-boot),128k(u-boot-env),128k(dtb),6m(kernel),-(rootfs)" CONFIG_CMD_UBI=y # CONFIG_ISO_PARTITION is not set -# CONFIG_EFI_PARTITION is not set -CONFIG_SPL_PARTITION_UUIDS=y CONFIG_OF_CONTROL=y CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y
@@ -79,4 +77,3 @@ CONFIG_USB_ETHER_SMSC95XX=y CONFIG_FAT_WRITE=y CONFIG_BCH=y CONFIG_SPL_OF_LIBFDT=y -# CONFIG_EFI_LOADER is not set
Signature · 1 line
2.18.0
PATCH 1/1 omap3: beagle: re-enable EFI support after the following commit removed it by mistake:
Quoted 2 lines · Guillaume GARDET
commit
d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
ARM: omap3: beagle: EnableDM_SERIAL, update distro usage and NAND layout
I have found no compile or runtime issues, on my BeagleBoard Rev. C4 or xM, with the current default configuration. At least, for my non-EFI boot environment.
The following items are brought in from the EFI config additions:
+CONFIG_SMBIOS_PRODUCT_NAME="beagle"
+CONFIG_CMD_BOOTEFI=y
+CONFIG_CMD_BOOTEFI_HELLO_COMPILE=y
+CONFIG_EFI_PARTITION=y
+CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=128
+CONFIG_EFI_PARTITION_ENTRIES_OFF=0
+CONFIG_SPL_EFI_PARTITION=y
+CONFIG_OF_LIBFDT_OVERLAY=y
+CONFIG_GENERATE_SMBIOS_TABLE=y
+CONFIG_SMBIOS_MANUFACTURER="ti"
+CONFIG_EFI_LOADER=y
I would change the commit message though. It was not a mistake. It was removed to provide a minimal set of configuration options for the base BSP type of setup. Using EFI is a choice. In fact, I tested my changes on 3 different OMAP3 boards. So there has been no period of not working in the basic board configuration. Provably.
So if EFI is required, even though one may not use it, this is a don't care for me. My boards boot just fine without EFI.
Derald
Quoted 29 lines
Signed-off-by Guillaume GARDET <[email protected]>Cc Derald D. Woods <[email protected]>Cc Tom Rini <[email protected]>--- configs/omap3_beagle_defconfig | 3 --- 1 file changed, 3 deletions(-)configs/omap3_beagle_defconfig +0
-3@@ -32,8 +32,6 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0" CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:512k(spl),1920k(u-boot),128k(u-boot-env),128k(dtb),6m(kernel),-(rootfs)" CONFIG_CMD_UBI=y # CONFIG_ISO_PARTITION is not set -# CONFIG_EFI_PARTITION is not set -CONFIG_SPL_PARTITION_UUIDS=y CONFIG_OF_CONTROL=y CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y@@ -79,4 +77,3 @@ CONFIG_USB_ETHER_SMSC95XX=y CONFIG_FAT_WRITE=y CONFIG_BCH=y CONFIG_SPL_OF_LIBFDT=y -# CONFIG_EFI_LOADER is not setSignature · 1 line
2.18.0
PATCH 1/1 omap3: beagle: re-enable EFI support after the following commit removed it by mistake:
Hi Derald,
Le 19/07/2018 à 01:47, Derald D. Woods a écrit :
Quoted 7 lines · Guillaume GARDET
Quoted 2 lines
commit
d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
ARM: omap3: beagle: EnableDM_SERIAL, update distro usage and NAND layoutI have found no compile or runtime issues, on my BeagleBoard Rev. C4 or xM, with the current default configuration. At least, for my non-EFI boot environment.
It is related to EFI options since I use GPT partitions (and EFI/Grub2 to boot). That is why you did not find anything.
Quoted 15 lines
The following items are brought in from the EFI config additions:
(quoted diff) +11
-0+CONFIG_SMBIOS_PRODUCT_NAME="beagle" +CONFIG_CMD_BOOTEFI=y +CONFIG_CMD_BOOTEFI_HELLO_COMPILE=y +CONFIG_EFI_PARTITION=y +CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=128 +CONFIG_EFI_PARTITION_ENTRIES_OFF=0 +CONFIG_SPL_EFI_PARTITION=y +CONFIG_OF_LIBFDT_OVERLAY=y +CONFIG_GENERATE_SMBIOS_TABLE=y +CONFIG_SMBIOS_MANUFACTURER="ti" +CONFIG_EFI_LOADER=y
Quoted 8 lines
I would change the commit message though. It was not a mistake. It was removed to provide a minimal set of configuration options for the base BSP type of setup. Using EFI is a choice. In fact, I tested my changes on 3 different OMAP3 boards. So there has been no period of not working in the basic board configuration. Provably.
So if EFI is required, even though one may not use it, this is a don't care for me. My boards boot just fine without EFI.
The thing is you introduced a regression with your commit, since EFI was supported previously. And you did not explicitly stated that you disabled it on purpose. So, it sounds like a mistake to me. If you don't care about EFI, it is your choice, but please do not break setup of others. A use case is openSUSE which relies on EFI/Grub2 to boot.
Please note that EFI is now a default feature in U-Boot, so, please, let it enabled.
Guillaume
Quoted 32 lines
Derald
Quoted 29 lines
Signed-off-by Guillaume GARDET <[email protected]>Cc Derald D. Woods <[email protected]>Cc Tom Rini <[email protected]>--- configs/omap3_beagle_defconfig | 3 --- 1 file changed, 3 deletions(-)configs/omap3_beagle_defconfig +0
-3@@ -32,8 +32,6 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0" CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:512k(spl),1920k(u-boot),128k(u-boot-env),128k(dtb),6m(kernel),-(rootfs)" CONFIG_CMD_UBI=y # CONFIG_ISO_PARTITION is not set -# CONFIG_EFI_PARTITION is not set -CONFIG_SPL_PARTITION_UUIDS=y CONFIG_OF_CONTROL=y CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y@@ -79,4 +77,3 @@ CONFIG_USB_ETHER_SMSC95XX=y CONFIG_FAT_WRITE=y CONFIG_BCH=y CONFIG_SPL_OF_LIBFDT=y -# CONFIG_EFI_LOADER is not setSignature · 1 line
2.18.0
PATCH 1/1 omap3: beagle: re-enable EFI support after the following commit removed it by mistake:
Quoted 7 lines · Guillaume Gardet
Hi Derald,
Quoted 3 lines · Derald D. Woods
Quoted 2 lines · Guillaume GARDET
commit
d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
ARM: omap3: beagle: EnableDM_SERIAL, update distro usage and NAND
Quoted 9 lines
layout
Quoted 4 lines
I have found no compile or runtime issues, on my BeagleBoard Rev. C4 or xM, with the current default configuration. At least, for my non-EFI boot environment.
It is related to EFI options since I use GPT partitions (and EFI/Grub2 to boot). That is why you did not find anything.
That is the piece that I do not use.
Quoted 32 lines
Quoted 15 lines
The following items are brought in from the EFI config additions:
(quoted diff) +11
-0+CONFIG_SMBIOS_PRODUCT_NAME="beagle" +CONFIG_CMD_BOOTEFI=y +CONFIG_CMD_BOOTEFI_HELLO_COMPILE=y +CONFIG_EFI_PARTITION=y +CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=128 +CONFIG_EFI_PARTITION_ENTRIES_OFF=0 +CONFIG_SPL_EFI_PARTITION=y +CONFIG_OF_LIBFDT_OVERLAY=y +CONFIG_GENERATE_SMBIOS_TABLE=y +CONFIG_SMBIOS_MANUFACTURER="ti" +CONFIG_EFI_LOADER=yQuoted 8 lines
I would change the commit message though. It was not a mistake. It was removed to provide a minimal set of configuration options for the base BSP type of setup. Using EFI is a choice. In fact, I tested my changes on 3 different OMAP3 boards. So there has been no period of not working in the basic board configuration. Provably.
So if EFI is required, even though one may not use it, this is a don't care for me. My boards boot just fine without EFI.
The thing is you introduced a regression with your commit, since EFI was supported previously. And you did not explicitly stated that you disabled it on purpose. So, it sounds like a mistake to me.
If you don't care about EFI, it is your choice, but please do not break setup of others. A use case is openSUSE which relies on EFI/Grub2 to boot. Please note that EFI is now a default feature in U-Boot, so, please, let it enabled.
Quoted 2 lines
Guillaume
I am not a novice and my series received the usual mailing list oversight. Maybe even more than one iteration. As I stated, this is a don't care for me. EFI is not mandatory to function/boot. The bare minimum case was the target of the series.
I acknowledge your commit.
Derald
Quoted 38 lines
Quoted 9 lines
Derald
Quoted 4 lines
Signed-off-by Guillaume GARDET <[email protected]>Cc Derald D. Woods <[email protected]>Cc Tom Rini <[email protected]>Quoted 5 lines
Review
Quoted 5 lines
--- configs/omap3_beagle_defconfig | 3 --- 1 file changed, 3 deletions(-)(quoted diff) +0
-0b/configs/omap3_beagle_defconfig
Quoted 5 lines
configs/omap3_beagle_defconfig CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0" · line 32
Quoted 5 lines
index
a37a38f881..1e1a391d7f100644configs/omap3_beagle_defconfig +0
-0@@ -32,8 +32,6 @@ CONFIG_MTDIDS_DEFAULT="nand0=omap2-nand.0"
CONFIG_MTDPARTS_DEFAULT="mtdparts=omap2-nand.0:512k(spl),1920k(u-boot),128k(u-boot-env),128k(dtb),6m(kernel),-(rootfs)"Quoted 15 lines
Quoted 15 lines
configs/omap3_beagle_defconfig +0
-4CONFIG_CMD_UBI=y # CONFIG_ISO_PARTITION is not set -# CONFIG_EFI_PARTITION is not set -CONFIG_SPL_PARTITION_UUIDS=y CONFIG_OF_CONTROL=y CONFIG_ENV_IS_IN_NAND=y CONFIG_SPL_DM=y@@ -79,4 +77,3 @@ CONFIG_USB_ETHER_SMSC95XX=y CONFIG_FAT_WRITE=y CONFIG_BCH=y CONFIG_SPL_OF_LIBFDT=y -# CONFIG_EFI_LOADER is not set --2.18.0
Quoted 6 lines · Guillaume GARDET
commit
d233ccb1d84b901f7e23e6d9b4f2c6a57198b23b
ARM: omap3: beagle: EnableDM_SERIAL, update distro usage and NAND layoutSigned-off-by Guillaume GARDET <[email protected]>Cc Derald D. Woods <[email protected]>Cc Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180726/071365f9/attachment.sig>